From: Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
To: Arnd Bergmann <arnd@arndb.de>,
Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Joao Pinto <Joao.Pinto@synopsys.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] dmaengine: dw-edma: fix __iomem type confusion
Date: Fri, 21 Jun 2019 09:35:20 +0000 [thread overview]
Message-ID: <DM6PR12MB4010E0D6F45C386E4A7C634ADAE70@DM6PR12MB4010.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAK8P3a1qhj_YYTo8aKgbdufjMFXfa3WNdqY6m=222fFxOcQaZg@mail.gmail.com>
On Fri, Jun 21, 2019 at 10:1:1, Arnd Bergmann <arnd@arndb.de> wrote:
> On Fri, Jun 21, 2019 at 10:53 AM Gustavo Pimentel
> <Gustavo.Pimentel@synopsys.com> wrote:
>
> > >
> > > static struct dentry *base_dir;
> > > static struct dw_edma *dw;
> > > -static struct dw_edma_v0_regs *regs;
> > > +static struct dw_edma_v0_regs __iomem *regs;
> >
> > Shouldn't the __iomem be next to dw_edma_v0_regs instead of the variable
> > name? I saw other drivers putting the __iomem next to the variable type,
> > therefore I assume it's the typical coding style.
>
> Yes, that seems more common indeed. Do you want to fix up
> both patches yourself when you apply them or should I send a new version?
If you could do that, it will be great.
Thanks.
>
> Arnd
prev parent reply other threads:[~2019-06-21 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 13:18 [PATCH] dmaengine: dw-edma: fix __iomem type confusion Arnd Bergmann
2019-06-21 8:53 ` Gustavo Pimentel
2019-06-21 9:01 ` Arnd Bergmann
2019-06-21 9:35 ` Gustavo Pimentel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB4010E0D6F45C386E4A7C634ADAE70@DM6PR12MB4010.namprd12.prod.outlook.com \
--to=gustavo.pimentel@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).