From: Biju Das <biju.das.jz@bp.renesas.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH 3/3] dmaengine: sh: rz-dmac: Add device_pause() callback
Date: Fri, 31 Mar 2023 15:42:47 +0000 [thread overview]
Message-ID: <OS0PR01MB59228D6D501A1CDA259E54A1868F9@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <ZCbPdEyAcvRUwyLz@matsya>
Hi Vinod,
Thanks for the feedback.
> Subject: Re: [PATCH 3/3] dmaengine: sh: rz-dmac: Add device_pause() callback
>
> On 24-03-23, 09:49, Biju Das wrote:
> > The device_pause() callback is needed for serial DMA (RZ/G2L SCIFA).
> > Add support for device_pause() callback.
> >
> > Based on a patch in the BSP by Long Luu <long.luu.ur@renesas.com>
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > drivers/dma/sh/rz-dmac.c | 20 ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index
> > 3625925d9f9f..a0cfb8f75534 100644
> > --- a/drivers/dma/sh/rz-dmac.c
> > +++ b/drivers/dma/sh/rz-dmac.c
> > @@ -822,6 +822,25 @@ static enum dma_status rz_dmac_tx_status(struct
> dma_chan *chan,
> > return status;
> > }
> >
> > +static int rz_dmac_device_pause(struct dma_chan *chan) {
> > + struct rz_dmac_chan *channel = to_rz_dmac_chan(chan);
> > + struct rz_dmac *dmac = to_rz_dmac(chan->device);
> > + unsigned int i;
> > + u32 chstat;
> > +
> > + for (i = 0; i < 1024; i++) {
> > + chstat = rz_dmac_ch_readl(channel, CHSTAT, 1);
> > + if (!(chstat & CHSTAT_EN))
> > + break;
> > + udelay(1);
> > + }
> > +
> > + rz_dmac_set_dmars_register(dmac, channel->index, 0);
> > +
> > + return 0;
> > +}
> > +
> > /*
> > * ----------------------------------------------------------------------
> -------
> > * IRQ handling
> > @@ -1111,6 +1130,7 @@ static int rz_dmac_probe(struct platform_device
> *pdev)
> > engine->device_terminate_all = rz_dmac_terminate_all;
> > engine->device_issue_pending = rz_dmac_issue_pending;
> > engine->device_synchronize = rz_dmac_device_synchronize;
> > + engine->device_pause = rz_dmac_device_pause;
>
> No resume?
OK, will add resume.
+static int rz_dmac_device_resume(struct dma_chan *chan)
+{
+ struct rz_dmac_chan *channel = to_rz_dmac_chan(chan);
+ struct rz_dmac *dmac = to_rz_dmac(chan->device);
+
+ rz_dmac_set_dmars_register(dmac, channel->index, channel->mid_rid);
+
+ return 0;
+}
Cheers,
Biju
>
> >
> > engine->copy_align = DMAENGINE_ALIGN_1_BYTE;
> > dma_set_max_seg_size(engine->dev, U32_MAX);
> > --
> > 2.25.1
>
> --
> ~Vinod
prev parent reply other threads:[~2023-03-31 15:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 9:49 [PATCH 0/3] RZ/G2L DMAC enhancements Biju Das
2023-03-24 9:49 ` [PATCH 1/3] dmaengine: sh: rz-dmac: Reinitialize lmdescriptor head Biju Das
2023-03-31 12:14 ` Vinod Koul
2023-03-31 15:20 ` Biju Das
2023-04-05 9:23 ` Biju Das
2023-03-24 9:49 ` [PATCH 2/3] dmaengine: sh: rz-dmac: Add device_tx_status() callback Biju Das
2023-03-31 12:16 ` Vinod Koul
2023-03-31 15:25 ` Biju Das
2023-03-24 9:49 ` [PATCH 3/3] dmaengine: sh: rz-dmac: Add device_pause() callback Biju Das
2023-03-31 12:17 ` Vinod Koul
2023-03-31 15:42 ` Biju Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB59228D6D501A1CDA259E54A1868F9@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=dmaengine@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).