* [PATCH] dmaengine: sh: rz-dmac: Add DMA clock handling
@ 2021-09-22 11:04 Biju Das
2021-09-23 9:22 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Biju Das @ 2021-09-22 11:04 UTC (permalink / raw)
To: Vinod Koul
Cc: Biju Das, Lad Prabhakar, dmaengine, Geert Uytterhoeven,
Chris Paterson, Biju Das, linux-renesas-soc
Currently, DMA clocks are turned on by the bootloader.
This patch adds support for DMA clock handling so that
the driver manages the DMA clocks.
Fixes: 5000d37042a6 ("dmaengine: sh: Add DMAC driver for RZ/G2L SoC")
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
drivers/dma/sh/rz-dmac.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c
index f9f30cbeccbe..52a1419370d7 100644
--- a/drivers/dma/sh/rz-dmac.c
+++ b/drivers/dma/sh/rz-dmac.c
@@ -18,6 +18,7 @@
#include <linux/of_dma.h>
#include <linux/of_platform.h>
#include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
@@ -872,6 +873,9 @@ static int rz_dmac_probe(struct platform_device *pdev)
/* Initialize the channels. */
INIT_LIST_HEAD(&dmac->engine.channels);
+ pm_runtime_enable(&pdev->dev);
+ pm_runtime_resume_and_get(&pdev->dev);
+
for (i = 0; i < dmac->n_channels; i++) {
ret = rz_dmac_chan_probe(dmac, &dmac->channels[i], i);
if (ret < 0)
@@ -925,6 +929,9 @@ static int rz_dmac_probe(struct platform_device *pdev)
channel->lmdesc.base_dma);
}
+ pm_runtime_put(&pdev->dev);
+ pm_runtime_disable(&pdev->dev);
+
return ret;
}
@@ -943,6 +950,8 @@ static int rz_dmac_remove(struct platform_device *pdev)
}
of_dma_controller_free(pdev->dev.of_node);
dma_async_device_unregister(&dmac->engine);
+ pm_runtime_put(&pdev->dev);
+ pm_runtime_disable(&pdev->dev);
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: sh: rz-dmac: Add DMA clock handling
2021-09-22 11:04 [PATCH] dmaengine: sh: rz-dmac: Add DMA clock handling Biju Das
@ 2021-09-23 9:22 ` Geert Uytterhoeven
2021-09-23 9:25 ` Biju Das
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-09-23 9:22 UTC (permalink / raw)
To: Biju Das
Cc: Vinod Koul, Lad Prabhakar, dmaengine, Chris Paterson, Biju Das,
Linux-Renesas
Hi Biju,
On Wed, Sep 22, 2021 at 1:17 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Currently, DMA clocks are turned on by the bootloader.
> This patch adds support for DMA clock handling so that
> the driver manages the DMA clocks.
>
> Fixes: 5000d37042a6 ("dmaengine: sh: Add DMAC driver for RZ/G2L SoC")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Thanks for your patch!
> --- a/drivers/dma/sh/rz-dmac.c
> +++ b/drivers/dma/sh/rz-dmac.c
> @@ -18,6 +18,7 @@
> #include <linux/of_dma.h>
> #include <linux/of_platform.h>
> #include <linux/platform_device.h>
> +#include <linux/pm_runtime.h>
> #include <linux/slab.h>
> #include <linux/spinlock.h>
>
> @@ -872,6 +873,9 @@ static int rz_dmac_probe(struct platform_device *pdev)
> /* Initialize the channels. */
> INIT_LIST_HEAD(&dmac->engine.channels);
>
> + pm_runtime_enable(&pdev->dev);
> + pm_runtime_resume_and_get(&pdev->dev);
I know this cannot fail in the real world, but I think you should handle
failure here, else the junior janitor crowd will send a follow-up patch
adding such handling...
> +
> for (i = 0; i < dmac->n_channels; i++) {
> ret = rz_dmac_chan_probe(dmac, &dmac->channels[i], i);
> if (ret < 0)
> @@ -925,6 +929,9 @@ static int rz_dmac_probe(struct platform_device *pdev)
> channel->lmdesc.base_dma);
> }
>
> + pm_runtime_put(&pdev->dev);
> + pm_runtime_disable(&pdev->dev);
> +
> return ret;
> }
>
> @@ -943,6 +950,8 @@ static int rz_dmac_remove(struct platform_device *pdev)
> }
> of_dma_controller_free(pdev->dev.of_node);
> dma_async_device_unregister(&dmac->engine);
> + pm_runtime_put(&pdev->dev);
> + pm_runtime_disable(&pdev->dev);
>
> return 0;
> }
Regardless:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] dmaengine: sh: rz-dmac: Add DMA clock handling
2021-09-23 9:22 ` Geert Uytterhoeven
@ 2021-09-23 9:25 ` Biju Das
0 siblings, 0 replies; 3+ messages in thread
From: Biju Das @ 2021-09-23 9:25 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Vinod Koul, Prabhakar Mahadev Lad, dmaengine, Chris Paterson,
Biju Das, Linux-Renesas
Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH] dmaengine: sh: rz-dmac: Add DMA clock handling
>
> Hi Biju,
>
> On Wed, Sep 22, 2021 at 1:17 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > Currently, DMA clocks are turned on by the bootloader.
> > This patch adds support for DMA clock handling so that the driver
> > manages the DMA clocks.
> >
> > Fixes: 5000d37042a6 ("dmaengine: sh: Add DMAC driver for RZ/G2L SoC")
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/drivers/dma/sh/rz-dmac.c
> > +++ b/drivers/dma/sh/rz-dmac.c
> > @@ -18,6 +18,7 @@
> > #include <linux/of_dma.h>
> > #include <linux/of_platform.h>
> > #include <linux/platform_device.h>
> > +#include <linux/pm_runtime.h>
> > #include <linux/slab.h>
> > #include <linux/spinlock.h>
> >
> > @@ -872,6 +873,9 @@ static int rz_dmac_probe(struct platform_device
> *pdev)
> > /* Initialize the channels. */
> > INIT_LIST_HEAD(&dmac->engine.channels);
> >
> > + pm_runtime_enable(&pdev->dev);
> > + pm_runtime_resume_and_get(&pdev->dev);
>
> I know this cannot fail in the real world, but I think you should handle
> failure here, else the junior janitor crowd will send a follow-up patch
> adding such handling...
OK. Will handle the failure in next version.
Regards,
Biju
>
> > +
> > for (i = 0; i < dmac->n_channels; i++) {
> > ret = rz_dmac_chan_probe(dmac, &dmac->channels[i], i);
> > if (ret < 0)
> > @@ -925,6 +929,9 @@ static int rz_dmac_probe(struct platform_device
> *pdev)
> > channel->lmdesc.base_dma);
> > }
> >
> > + pm_runtime_put(&pdev->dev);
> > + pm_runtime_disable(&pdev->dev);
> > +
> > return ret;
> > }
> >
> > @@ -943,6 +950,8 @@ static int rz_dmac_remove(struct platform_device
> *pdev)
> > }
> > of_dma_controller_free(pdev->dev.of_node);
> > dma_async_device_unregister(&dmac->engine);
> > + pm_runtime_put(&pdev->dev);
> > + pm_runtime_disable(&pdev->dev);
> >
> > return 0;
> > }
>
> Regardless:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-23 9:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-22 11:04 [PATCH] dmaengine: sh: rz-dmac: Add DMA clock handling Biju Das
2021-09-23 9:22 ` Geert Uytterhoeven
2021-09-23 9:25 ` Biju Das
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).