dmaengine.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>
Cc: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH] dt-bindings: dmaengine: dma-common: Revise the dma-channel-mask property
Date: Wed, 28 Aug 2019 10:00:30 +0000	[thread overview]
Message-ID: <TYAPR01MB45449A32980BD5A48D0FC2C0D8A30@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <3b06567c-8cfe-bfec-3973-c3e7cf71a18b@ti.com>

Hi Peter-san,

> From: Peter Ujfalusi, Sent: Wednesday, August 28, 2019 6:39 PM
> 
> Hi Shimoda-san,
> 
> On 28/08/2019 11.55, Yoshihiro Shimoda wrote:
> > Hi Peter,
> >
> >> From: Peter Ujfalusi, Sent: Wednesday, August 28, 2019 4:25 PM
> >>
> >> On 28/08/2019 9.39, Yoshihiro Shimoda wrote:
> >>> The commit b37e3534ac42 ("dt-bindings: dmaengine: Add YAML schemas
> >>> for the generic DMA bindings") changed the property from
> >>> dma-channel-mask to dma-channel-masks. So, this patch revises it.
> >>>
> >>> Fixes: b37e3534ac42 ("dt-bindings: dmaengine: Add YAML schemas for the generic DMA bindings")
> >>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >>> ---
> >>>  Documentation/devicetree/bindings/dma/dma-common.yaml | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/dma/dma-common.yaml
> >> b/Documentation/devicetree/bindings/dma/dma-common.yaml
> >>> index 0141af0..ed0a49a 100644
> >>> --- a/Documentation/devicetree/bindings/dma/dma-common.yaml
> >>> +++ b/Documentation/devicetree/bindings/dma/dma-common.yaml
> >>> @@ -24,7 +24,7 @@ properties:
> >>>      description:
> >>>        Used to provide DMA controller specific information.
> >>>
> >>> -  dma-channel-masks:
> >>> +  dma-channel-mask:
> >>>      $ref: /schemas/types.yaml#definitions/uint32
> >>
> >> How this mask supposed to be used for controllers having more than 32
> >> channels (64, 300+)?
> >
> > I found "dma-channels" property as 40 in arch/arm/boot/dts/ste-u300.dts.
> > However, since arch/arm64/boot/dts/hisilicon/hi3660.dtsi already has
> > the dma-channel-mask property, I think we should not change the property name.
> 
> I'm not asking it to be changed, I just wondered how I could use this
> generic property for DMA controllers having more channels than u32
> bitfield could describe. An array of multiple u32 to cover the number of
> channels would probably something which can be done, but it would need
> update for the documentation to make sure that it is used consistently.
> 
> I'm asking this because of: https://patchwork.kernel.org/patch/11111619/

Oops, I'm sorry for misunderstanding your question.

As you said, I also think that you can use this generic property if we update
the document from uint32 to uint32-array like below:

-      $ref: /schemas/types.yaml#definitions/uint32
+      $ref: /schemas/types.yaml#definitions/uint32-array

Best regards,
Yoshihiro Shimoda

> >
> > Best regards,
> > Yoshihiro Shimoda
> >
> >>>      description:
> >>>        Bitmask of available DMA channels in ascending order that are
> >>>
> >>
> >> - Péter
> >>
> >> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> >> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> 
> - Péter
> 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  reply	other threads:[~2019-08-28 10:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28  6:39 [PATCH] dt-bindings: dmaengine: dma-common: Revise the dma-channel-mask property Yoshihiro Shimoda
2019-08-28  7:25 ` Peter Ujfalusi
2019-08-28  8:55   ` Yoshihiro Shimoda
2019-08-28  9:38     ` Peter Ujfalusi
2019-08-28 10:00       ` Yoshihiro Shimoda [this message]
2019-08-28  7:30 ` Geert Uytterhoeven
2019-08-28  8:57   ` Yoshihiro Shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYAPR01MB45449A32980BD5A48D0FC2C0D8A30@TYAPR01MB4544.jpnprd01.prod.outlook.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).