dmaengine Archive on lore.kernel.org
 help / color / Atom feed
From: Robin Gong <yibin.gong@nxp.com>
To: Frieder Schrempf <frieder.schrempf@kontron.de>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"vkoul@kernel.org" <vkoul@kernel.org>,
	"will.deacon@arm.com" <will.deacon@arm.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"martin.fuzzey@flowbird.group" <martin.fuzzey@flowbird.group>,
	"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"matthias.schiffer@ew.tq-group.com" 
	<matthias.schiffer@ew.tq-group.com>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH v10 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script
Date: Thu, 23 Jul 2020 10:24:24 +0000
Message-ID: <VE1PR04MB66385FC4FE591EAFA8CB7D8289760@VE1PR04MB6638.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1b04e4e6-ca26-3f45-e353-af81e03f85a7@kontron.de>

On 2020/07/23 17:04 Frieder Schrempf <frieder.schrempf@kontron.de> wrote: 
> Hi Robin,
> 
> On 30.06.20 15:31, Robin Gong wrote:
> > Add 'fw_loaded' and 'is_ram_script' to check if the script used by
> > channel is ram script and it's loaded or not, so that could prevent
> > meaningless following malloc dma descriptor and bd allocate in
> > sdma_transfer_init(), otherwise memory may be consumed out potentially
> > without free in case that spi fallback into pio while dma transfer
> > failed by sdma firmware not ready(next ERR009165 patch depends on sdma
> RAM scripts/firmware).
> >
> > Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> > Acked-By: Vinod Koul <vkoul@kernel.org>
> > ---
> >   drivers/dma/imx-sdma.c | 13 +++++++++++++
> >   1 file changed, 13 insertions(+)
> >
> > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index
> > 5411e01e..ce1c83e 100644
> > --- a/drivers/dma/imx-sdma.c
> > +++ b/drivers/dma/imx-sdma.c
> > @@ -379,6 +379,7 @@ struct sdma_channel {
> >   	enum dma_status			status;
> >   	struct imx_dma_data		data;
> >   	struct work_struct		terminate_worker;
> > +	bool				is_ram_script;
> >   };
> >
> >   #define IMX_DMA_SG_LOOP		BIT(0)
> > @@ -443,6 +444,7 @@ struct sdma_engine {
> >   	struct sdma_buffer_descriptor	*bd0;
> >   	/* clock ratio for AHB:SDMA core. 1:1 is 1, 2:1 is 0*/
> >   	bool				clk_ratio;
> > +	bool                            fw_loaded;
> >   };
> >
> >   static int sdma_config_write(struct dma_chan *chan, @@ -929,6 +931,7
> > @@ static void sdma_get_pc(struct sdma_channel *sdmac,
> >   	case IMX_DMATYPE_SSI_DUAL:
> >   		per_2_emi = sdma->script_addrs->ssish_2_mcu_addr;
> >   		emi_2_per = sdma->script_addrs->mcu_2_ssish_addr;
> > +		sdmac->is_ram_script = true;
> >   		break;
> >   	case IMX_DMATYPE_SSI_SP:
> >   	case IMX_DMATYPE_MMC:
> > @@ -943,6 +946,7 @@ static void sdma_get_pc(struct sdma_channel
> *sdmac,
> >   		per_2_emi = sdma->script_addrs->asrc_2_mcu_addr;
> >   		emi_2_per = sdma->script_addrs->asrc_2_mcu_addr;
> >   		per_2_per = sdma->script_addrs->per_2_per_addr;
> > +		sdmac->is_ram_script = true;
> >   		break;
> >   	case IMX_DMATYPE_ASRC_SP:
> >   		per_2_emi = sdma->script_addrs->shp_2_mcu_addr;
> > @@ -1339,6 +1343,11 @@ static struct sdma_desc
> *sdma_transfer_init(struct sdma_channel *sdmac,
> >   {
> >   	struct sdma_desc *desc;
> >
> > +	if (!sdmac->sdma->fw_loaded && sdmac->is_ram_script) {
> > +		dev_err(sdmac->sdma->dev, "sdma firmware not ready!\n");
> > +		goto err_out;
> > +	}
> 
> I tried your v10 patches on next-20200722 with i.MX8MM and it mostly
> seems to work fine.
> 
> When I tried first, I had the imx-sdma driver compiled into the kernel, so it
> didn't load the firmware and fell back to the ROM scripts.
> With this, SPI transactions work just fine, but I got the above error message
> printed continuously when sending data in SPI3 via spidev.
That's caused by you didn't load ram firmware as this patch set described.
Please follow below steps to load firmware manually if you don't want to
use NXP official Yocto release package:

1. Get sdma firmware from below linux-firmware and copy it to your
local rootfs /lib/firmware/imx/sdma.
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/imx/sdma
2. Load firmware manually:
        echo 1 > /sys/$DEVPATH/loading
        cat $MY_FW_DIR/$FIRMWARE > /sys/$DEVPATH/data
        echo 0 > /sys/$DEVPATH/loading
Please refer to Documentation/driver-api/firmware/fallback-mechanisms.rst
and load the firmware in 60s (firmware fallback loading timeout) from kernel
boot up.

> 
> When I build imx-sdma as a module, the firmware is loaded correctly and
> everything works as expected.
I guess that's not related with sdma building as module. If sdma build as
module, spi will fall to pio mode at spi-imx driver probe phase so that the above
warning log never to be walked. Would you please add some debug info to double
confirm?  
> 
> Can you have a look at this and provide a fix?
> 
> Thanks,
> Frieder

  reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30 13:31 [PATCH v10 00/12] add ecspi ERR009165 for i.mx6/7 soc family Robin Gong
2020-06-30 13:31 ` [PATCH v10 01/12] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Robin Gong
2020-06-30 13:31 ` [PATCH v10 02/12] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Robin Gong
2020-06-30 13:31 ` [PATCH v10 03/12] Revert "dmaengine: imx-sdma: refine to load context only once" Robin Gong
2020-06-30 13:31 ` [PATCH v10 04/12] dmaengine: imx-sdma: remove duplicated sdma_load_context Robin Gong
2020-06-30 13:31 ` [PATCH v10 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script Robin Gong
2020-07-15  5:57   ` Vinod Koul
2020-07-23  9:03   ` Frieder Schrempf
2020-07-23 10:24     ` Robin Gong [this message]
2020-07-23 11:12       ` Robin Gong
2020-07-23 11:51         ` Frieder Schrempf
2020-07-23 14:11           ` Robin Gong
2020-06-30 13:31 ` [PATCH v10 06/12] dmaengine: imx-sdma: add mcu_2_ecspi script Robin Gong
2020-06-30 13:31 ` [PATCH v10 07/12] spi: imx: fix ERR009165 Robin Gong
2020-06-30 13:31 ` [PATCH v10 08/12] spi: imx: remove ERR009165 workaround on i.mx6ul Robin Gong
2020-06-30 13:31 ` [PATCH v10 09/12] spi: imx: add new i.mx6ul compatible name in binding doc Robin Gong
2020-06-30 13:31 ` [PATCH v10 10/12] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul Robin Gong
2020-06-30 13:31 ` [PATCH v10 11/12] dma: imx-sdma: add i.mx6ul compatible name Robin Gong
2020-06-30 13:31 ` [PATCH v10 12/12] dmaengine: imx-sdma: add uart rom script Robin Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VE1PR04MB66385FC4FE591EAFA8CB7D8289760@VE1PR04MB6638.eurprd04.prod.outlook.com \
    --to=yibin.gong@nxp.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dan.j.williams@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=martin.fuzzey@flowbird.group \
    --cc=matthias.schiffer@ew.tq-group.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vkoul@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git