From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F68C18E5C for ; Tue, 10 Mar 2020 09:02:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8AB1A2464B for ; Tue, 10 Mar 2020 09:02:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="qgbv5wUk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726776AbgCJJCN (ORCPT ); Tue, 10 Mar 2020 05:02:13 -0400 Received: from mail-eopbgr50081.outbound.protection.outlook.com ([40.107.5.81]:53731 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726389AbgCJJCN (ORCPT ); Tue, 10 Mar 2020 05:02:13 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DCXQyxpaLT+WkrtRxVDRdgbcsaIxVen22sGb9V8uA9TjFYd96L3Z6RglW2nHbRHiR2jUxAv0+LM7Du4UrwYDV4H75OsgAwAGVZSYeTjce/NcyIUG856W8m9Tqnx5DDRCLwhkL1i7lT7DPGSzDWt6G9pV41zEjQpLOb2fpnM7m0WtISY+IhsRkIe77N6MvCBhZkqwH2pcEvacweAnAl1ZS+pHN8bu0b0pVZN84uoeppVdAw7rOjdGQFV6mPW95QBMnl347wu5mlrlezpSvqIXa0yio2C1ELr8fsfWv6kv4ygJSjIXVhoJ8gao7Pf7pLHluz432tPC8xQx6Fdu/16zKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fCrgOZ0DeDIjIMZC/9xKzqmm+35+mySyLhnDR1fMF7Y=; b=clTv9f7H93ZN4vzxce2JJjc3gsGFS0wvoI3CZFzLSDO8zTil0UCeNbzXfIpAP6IllqQ39p/rs2Ypr7LSXs46NJ3SImo7TJauk55XRo6Jg2WFnEMjKZbljsRDUV8kXsr+7FNN+uZiXn05/tYwQpFZgykb8bGzGUjDjjuFhvW1KB7JjfMQYaAT0EKaC1pXpX/3WtU83Y9Jyavkpr0d5Wc8pW57wTNl3utjHSnvKaeyMVXQEzt3MS87qz5QfhRd5a4N5SswT1d5+Hky5ElyJmWf9/xaDllOD+aangqQiBuyjueGhS0UnLPQhUE8urpq8Ur5O8FUxLbG/47qE8SBjwXn3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fCrgOZ0DeDIjIMZC/9xKzqmm+35+mySyLhnDR1fMF7Y=; b=qgbv5wUkaW3ebLVLwzy8XZ+Lepjes8xweWqGEn3LqX+CkXwIyUhPW4t+AkglAsI/0SAtSyJKs593NUxvFhYhFrAA50H8nbyNwEqky/r9nuLbwS9qmma6wXkdQFhs0R5IIRZtDZHd2TAsnHXWlGewuRWGg+M+fgMbirjVW2c/fN0= Received: from VE1PR04MB6638.eurprd04.prod.outlook.com (20.179.232.15) by VE1PR04MB6749.eurprd04.prod.outlook.com (10.255.118.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.17; Tue, 10 Mar 2020 09:02:09 +0000 Received: from VE1PR04MB6638.eurprd04.prod.outlook.com ([fe80::490:6caa:24b:4a31]) by VE1PR04MB6638.eurprd04.prod.outlook.com ([fe80::490:6caa:24b:4a31%6]) with mapi id 15.20.2793.013; Tue, 10 Mar 2020 09:02:09 +0000 From: Robin Gong To: =?iso-8859-1?Q?Uwe_Kleine-K=F6nig?= CC: Sascha Hauer , "vkoul@kernel.org" , "shawnguo@kernel.org" , "broonie@kernel.org" , "robh+dt@kernel.org" , "festevam@gmail.com" , "dan.j.williams@intel.com" , "mark.rutland@arm.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "l.stach@pengutronix.de" , "martin.fuzzey@flowbird.group" , "kernel@pengutronix.de" , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "dmaengine@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: RE: [RESEND v6 06/13] spi: imx: fix ERR009165 Thread-Topic: [RESEND v6 06/13] spi: imx: fix ERR009165 Thread-Index: AQHV9oxXftoGpg9l0ka8yr0vqbewZqhBcOwAgAAKFSCAAAYlgIAABlYA Date: Tue, 10 Mar 2020 09:02:08 +0000 Message-ID: References: <1583839922-22699-1-git-send-email-yibin.gong@nxp.com> <1583839922-22699-7-git-send-email-yibin.gong@nxp.com> <20200310073920.GR3335@pengutronix.de> <20200310083725.sb6cufp5wznvxcji@pengutronix.de> In-Reply-To: <20200310083725.sb6cufp5wznvxcji@pengutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yibin.gong@nxp.com; x-originating-ip: [92.121.68.129] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 72b9ad52-1ecd-43ff-f5a0-08d7c4d1b6dd x-ms-traffictypediagnostic: VE1PR04MB6749:|VE1PR04MB6749: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2582; x-forefront-prvs: 033857D0BD x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(396003)(366004)(376002)(136003)(39860400002)(346002)(199004)(189003)(81156014)(66476007)(8936002)(64756008)(66556008)(66446008)(76116006)(66946007)(8676002)(54906003)(186003)(71200400001)(26005)(7696005)(316002)(81166006)(66574012)(6506007)(4326008)(7416002)(478600001)(966005)(45080400002)(2906002)(6916009)(33656002)(52536014)(5660300002)(86362001)(9686003)(55016002);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR04MB6749;H:VE1PR04MB6638.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bhKnSoLwZCTBQpoDUd/QHyDXqZgdNNYvuR38libsVOK1iu7XFcHDaeqy4PdwRk6fHAxheXJJLRDquOZeEO2Ta4znYqjcB483O/sYzwbp1E69UajzplFcG9pe1pWCVBfQ807/gbZVYO48q4nV3BzVHdQgRpHJHEGOaO1AOml+cjI8AlcTlvUC9nG6YYgXvNO9KhkNLFM5HTwqJc4V03FcIBY0XhVwo89ZJaWb5XRtTzDhAjCHVuEMRZ4rirLhRw790NFUs04NVMZ2XkOdRBzEdP0JR+eDcfW0epk2N5EKykHrZnTDHqVa7PanGuFySCbPlPrXNh3TplLEPJ7tCN2sku9tTIw1UbG7rsyIFsF/Ce02x+mcgvzr01c8zUo57Wq4nVr1eHbjJ3Pkgpf2n6940EUYjundh5tBPNa0HI6gjyl4oAINA2M+Jcc8EIOouE1/Es/apODdbH56q4P8NBOuqQt2VNBJ+BY4NxGoy6WsTOBFA3xvNgXEbsX8E/hOHyMcjnuBoDPNEcz5DBKCbVkGZg== x-ms-exchange-antispam-messagedata: jxTSNTu9eneTnlaC2cDz1Sl/j9hqaLwEVIQp+0hm/6SCv5Iv6Zni8R7gx70bq29I41BGOOiYg3wp0wUVd4HxCPrInwzMn60fCLOexBNaoqOLLXLqKKjuMoho6Gttreve3L4yZ7YsFYYIux3GEl94FA== Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72b9ad52-1ecd-43ff-f5a0-08d7c4d1b6dd X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2020 09:02:09.0213 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ojr/6iNY6CL0R+gsu7DaB+7f9xJLgXGET1HN0goQTSDCSSwvPwmke2eN69iILeWkV32zIABiL9Y7Gj2WGCP1aA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6749 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 2020/03/10 Uwe Kleine-K=F6nig wrote: >=20 > Hello, >=20 > On Tue, Mar 10, 2020 at 08:27:41AM +0000, Robin Gong wrote: > > On 2020/03/10 Sascha Hauer wrote: > > > On Tue, Mar 10, 2020 at 07:31:55PM +0800, Robin Gong wrote: > > > > writel(ctrl, spi_imx->base + MX51_ECSPI_CTRL); > > > > > > > > @@ -612,12 +613,14 @@ static int mx51_ecspi_prepare_transfer(struct > > > > spi_imx_data *spi_imx, > > > > > > > > static void mx51_setup_wml(struct spi_imx_data *spi_imx) { > > > > + u32 tx_wml =3D 0; > > > > + > > > > /* > > > > * Configure the DMA register: setup the watermark > > > > * and enable DMA request. > > > > */ > > > > writel(MX51_ECSPI_DMA_RX_WML(spi_imx->wml - 1) | > > > > - MX51_ECSPI_DMA_TX_WML(spi_imx->wml) | > > > > + MX51_ECSPI_DMA_TX_WML(tx_wml) | > > > > > > tx_wml is never assigned any other value than 0. Drop the variable. > > That's prepared for 07/13 patch which may assign spi_imx->wml to tx_wml= . >=20 > Then this belongs into patch 7, right? Okay, understood your concern. Then I'll drop tx_wml to make it clear. >=20 > Best regards > Uwe >=20 > -- > Pengutronix e.K. | Uwe Kleine-K=F6nig > | > Industrial Linux Solutions | > https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fwww.p > engutronix.de%2F&data=3D02%7C01%7Cyibin.gong%40nxp.com%7Cca6f14 > 28f4224fa79f1d08d7c4ce4a41%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0 > %7C0%7C637194262606339591&sdata=3DkI9HAyC%2FG3qmrIrLmfUDJ7dac > %2FOEDBtDm4oeRyak1xE%3D&reserved=3D0 |