RE: [PATCH v14 00/12] add ecspi ERR009165 for i.mx6/7 soc family

From: Robin Gong <yibin.gong@nxp.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Vinod <vkoul@kernel.org>, "Mark Rutland" <mark.rutland@arm.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Will Deacon" <will.deacon@arm.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Martin Fuzzey" <martin.fuzzey@flowbird.group>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Matthias Schiffer" <matthias.schiffer@ew.tq-group.com>,
	"Schrempf Frieder" <frieder.schrempf@kontron.de>,
	"Marco Felsch" <m.felsch@pengutronix.de>,
	"Clark Wang" <xiaoning.wang@nxp.com>,
	linux-spi <linux-spi@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: RE: [PATCH v14 00/12] add ecspi ERR009165 for i.mx6/7 soc family
Date: Tue, 15 Jun 2021 01:55:29 +0000	[thread overview]
Message-ID: <VE1PR04MB6688017E125D42C5DCB3C17D89309@VE1PR04MB6688.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAOMZO5CNjpek0vkDrMyTmfbnr2cLcquck6QQBqXLBiyTDKPXvA@mail.gmail.com>

On 06/11/21 21:51 Fabio Estevam <festevam@gmail.com> wrote: 
> Hi Robin,
> 
> On Wed, Apr 7, 2021 at 4:15 AM Robin Gong <yibin.gong@nxp.com> wrote:
> >
> > There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO
> > transfer to be send twice in DMA mode. Please get more information from:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.
> >
> nxp.com%2Fdocs%2Fen%2Ferrata%2FIMX6DQCE.pdf&amp;data=04%7C01%7
> Cyibin.g
> >
> ong%40nxp.com%7Cab59d4a2e95a4351e48708d92cdffc09%7C686ea1d3bc2
> b4c6fa92
> >
> cd99c5c301635%7C0%7C1%7C637590162781662129%7CUnknown%7CTWF
> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC
> I6Mn0%3D%7C1000&amp;sdata=DIbrrAYvpoJ4lKrkDJYvyoixR9DcMCgVDwuW
> gI5fuVw%3D&amp;reserved=0. The workaround is adding new sdma ram
> script which works in XCH  mode as PIO inside sdma instead of SMC mode,
> meanwhile, 'TX_THRESHOLD' should be 0. The issue should be exist on all
> legacy i.mx6/7 soc family before i.mx6ul.
> > NXP fix this design issue from i.mx6ul, so newer chips including
> > i.mx6ul/ 6ull/6sll do not need this workaroud anymore. All other
> > i.mx6/7/8 chips still need this workaroud. This patch set add new
> 'fsl,imx6ul-ecspi'
> > for ecspi driver and 'ecspi_fixed' in sdma driver to choose if need
> > errata or not.
> > The first two reverted patches should be the same issue, though, it
> > seems 'fixed' by changing to other shp script. Hope Sean or Sascha
> > could have the chance to test this patch set if could fix their issues.
> > Besides, enable sdma support for i.mx8mm/8mq and fix ecspi1 not work
> > on i.mx8mm because the event id is zero.
> >
> > PS:
> >    Please get sdma firmware from below linux-firmware and copy it to
> > your local rootfs /lib/firmware/imx/sdma.
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
> >
> kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ffirmware%2Flinux-fir
> mw
> >
> are.git%2Ftree%2Fimx%2Fsdma&amp;data=04%7C01%7Cyibin.gong%40nxp.c
> om%7C
> >
> ab59d4a2e95a4351e48708d92cdffc09%7C686ea1d3bc2b4c6fa92cd99c5c301
> 635%7C
> >
> 0%7C1%7C637590162781662129%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi
> MC4wLjAwMDA
> >
> iLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=uL
> %2F
> >
> 6w%2F7JF76dqTfKYk4BT%2F5flWr0d3U2O86ABSq2UhI%3D&amp;reserved=0
> 
> Without this series, SPI DMA does not work on i.MX8MM:
> 
>  [   41.315984] spi_master spi1: I/O Error in DMA RX
> 
> I applied your series and SPI DMA works now:
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Thanks Fabio.
Hello Vinod, Mark, 
Is my patch set good enough to merge? I remember someone else are
requesting it from last year like Fabio.