From: Peng Ma <peng.ma@nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Wen He <wen.he_1@nxp.com>, Jiaheng Fan <jiaheng.fan@nxp.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [RFT] dmaengine: fsl-qdma: Handle invalid qdma-queue0 IRQ
Date: Mon, 21 Oct 2019 09:54:20 +0000 [thread overview]
Message-ID: <VI1PR04MB443161476574A4424B0B55B2ED690@VI1PR04MB4431.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20191004150826.6656-1-krzk@kernel.org>
Hi Krzysztof,
Thanks for your patch.
Reviewed-by: Peng Ma <peng.ma@nxp.com>
Tested-by: Peng Ma <peng.ma@nxp.com>
Best Regards,
Peng
>-----Original Message-----
>From: Krzysztof Kozlowski <krzk@kernel.org>
>Sent: 2019年10月4日 23:08
>To: Vinod Koul <vkoul@kernel.org>; Dan Williams <dan.j.williams@intel.com>;
>Peng Ma <peng.ma@nxp.com>; Wen He <wen.he_1@nxp.com>; Jiaheng Fan
><jiaheng.fan@nxp.com>; Krzysztof Kozlowski <krzk@kernel.org>;
>dmaengine@vger.kernel.org; linux-kernel@vger.kernel.org
>Subject: [EXT] [RFT] dmaengine: fsl-qdma: Handle invalid qdma-queue0 IRQ
>
>Caution: EXT Email
>
>platform_get_irq_byname() might return -errno which later would be cast to an
>unsigned int and used in IRQ handling code leading to usage of wrong ID and
>errors about wrong irq_base.
>
>Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
>---
>
>Not marking as cc-stable as this was not reproduced and not tested.
>---
> drivers/dma/fsl-qdma.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c index
>06664fbd2d91..89792083d62c 100644
>--- a/drivers/dma/fsl-qdma.c
>+++ b/drivers/dma/fsl-qdma.c
>@@ -1155,6 +1155,9 @@ static int fsl_qdma_probe(struct platform_device
>*pdev)
> return ret;
>
> fsl_qdma->irq_base = platform_get_irq_byname(pdev,
>"qdma-queue0");
>+ if (fsl_qdma->irq_base < 0)
>+ return fsl_qdma->irq_base;
>+
> fsl_qdma->feature = of_property_read_bool(np, "big-endian");
> INIT_LIST_HEAD(&fsl_qdma->dma_dev.channels);
>
>--
>2.17.1
next prev parent reply other threads:[~2019-10-21 9:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 15:08 [RFT] dmaengine: fsl-qdma: Handle invalid qdma-queue0 IRQ Krzysztof Kozlowski
2019-10-21 9:54 ` Peng Ma [this message]
2019-11-02 16:26 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB443161476574A4424B0B55B2ED690@VI1PR04MB4431.eurprd04.prod.outlook.com \
--to=peng.ma@nxp.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=jiaheng.fan@nxp.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=wen.he_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).