From: Peng Ma <peng.ma@nxp.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
Leo Li <leoyang.li@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
Subject: RE: [EXT] Re: [V3 2/2] dmaengine: fsl-dpaa2-qdma: Add NXP dpaa2 qDMA controller driver for Layerscape SoCs
Date: Fri, 14 Jun 2019 01:41:59 +0000 [thread overview]
Message-ID: <VI1PR04MB4431BAEE4E97C33FD81965BAEDEE0@VI1PR04MB4431.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190613110325.GD9160@vkoul-mobl.Dlink>
Hi Vinod,
>-----Original Message-----
>From: Vinod Koul <vkoul@kernel.org>
>Sent: 2019年6月13日 19:03
>To: Peng Ma <peng.ma@nxp.com>
>Cc: dan.j.williams@intel.com; Leo Li <leoyang.li@nxp.com>;
>linux-kernel@vger.kernel.org; dmaengine@vger.kernel.org
>Subject: Re: [EXT] Re: [V3 2/2] dmaengine: fsl-dpaa2-qdma: Add NXP dpaa2
>qDMA controller driver for Layerscape SoCs
>
>Caution: EXT Email
>
>On 10-06-19, 09:51, Peng Ma wrote:
>
>> >> + goto err;
>> >> +
>> >> + comp_temp->fl_virt_addr =
>> >> + (void *)((struct dpaa2_fd *)
>> >> + comp_temp->fd_virt_addr + 1);
>> >
>> >casts and pointer math, what could go wrong!! This doesnt smell right!
>> >
>> >> + comp_temp->fl_bus_addr = comp_temp->fd_bus_addr +
>> >> + sizeof(struct dpaa2_fd);
>> >
>> >why not use fl_virt_addr and get the bus_address?
>> What you mean is I should use virt_to_phys to get the bus_address?
>
>Yes instead of maintaining both pointers, just use one and then when required
>use one to get other. For bus address I would prefer dma_map_single rather
>than virt_to_phys()
[Peng Ma] ok, thanks, I have already send V4 for this series patch, Please review it in your spare time.
Patchwork link: https://patchwork.kernel.org/project/linux-dmaengine/list/?series=131767
Best Regars,
Peng
>--
>~Vinod
next prev parent reply other threads:[~2019-06-14 1:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 7:22 [V3,1/2] dmaengine: fsl-dpaa2-qdma: Add the DPDMAI(Data Path DMA Interface) support Peng Ma
2019-04-09 7:22 ` [V3 1/2] " Peng Ma
2019-04-09 7:22 ` [V3,2/2] dmaengine: fsl-dpaa2-qdma: Add NXP dpaa2 qDMA controller driver for Layerscape SoCs Peng Ma
2019-04-09 7:22 ` [V3 2/2] " Peng Ma
2019-04-29 5:32 ` [V3,2/2] " Vinod Koul
2019-04-29 5:32 ` [V3 2/2] " Vinod Koul
2019-06-10 9:51 ` [EXT] " Peng Ma
2019-06-13 11:03 ` Vinod Koul
2019-06-14 1:41 ` Peng Ma [this message]
2019-04-26 12:45 ` [V3,1/2] dmaengine: fsl-dpaa2-qdma: Add the DPDMAI(Data Path DMA Interface) support Vinod Koul
2019-04-26 12:45 ` [V3 1/2] " Vinod Koul
2019-05-28 4:47 ` [EXT] " Peng Ma
2019-05-28 9:46 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB4431BAEE4E97C33FD81965BAEDEE0@VI1PR04MB4431.eurprd04.prod.outlook.com \
--to=peng.ma@nxp.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).