From: Robin Gong <yibin.gong@nxp.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"plyatov@gmail.com" <plyatov@gmail.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: [EXT] Re: [PATCH v2 08/15] dt-bindings: spi: imx: add i.mx6ul to state errata fixed
Date: Sun, 5 May 2019 08:47:21 +0000 [thread overview]
Message-ID: <VI1PR04MB45436B23E821F02C43502D6489370@VI1PR04MB4543.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190502065939.nyejomrsowhy6xox@pengutronix.de>
> On Fri, Apr 26, 2019 at 08:05:51AM +0000, Robin Gong wrote:
> > ERR009165 fixed from i.mx6ul, add it to show the errata fixed.
> >
> > Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> > ---
> > Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> > b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> > index 2d32641..32c4263d 100644
> > --- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> > +++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> > @@ -10,6 +10,8 @@ Required properties:
> > - "fsl,imx35-cspi" for SPI compatible with the one integrated on i.MX35
> > - "fsl,imx51-ecspi" for SPI compatible with the one integrated on i.MX51
> > - "fsl,imx53-ecspi" for SPI compatible with the one integrated on
> > i.MX53 and later Soc
> > + - "fsl,imx6ul-ecspi" ERR009165 fixed on i.MX6UL and later Soc
> > +
> > + (https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fw
> > +
> ww.nxp.com%2Fdocs%2Fen%2Ferrata%2FIMX6DQCE.pdf&data=02%7C01
> %7Cyi
> > +
> bin.gong%40nxp.com%7Cc36708a8219843ffe1d308d6cecbc512%7C686ea1d
> 3bc2b
> > +
> 4c6fa92cd99c5c301635%7C0%7C1%7C636923771907346428&sdata=9e
> 8c8GK2
> > + hSE90rzyArm8elog9dwNqn4Jeoeff79XwI4%3D&reserved=0)
>
> I wouldn't mention this errata in the binding documentation. Just state that
> fsl,imx6ul-ecspi is designed to be used on i.MX6UL. And that it might also be
> used on later SoCs as a "fallback compatible" is a detail that is so common that
Eh...Maybe add one flag member in 'struct spi_imx_devtype_data' to state errata fixed
is better?
> I would expect it not being worth mentioning. So for me it would also be OK to
> drop "fsl,imx53-ecspi" from the list as this is only used like:
>
> compatible = "fsl,imx53-ecspi", "fsl,imx51-ecspi";
>
> (But note that I have no authority here.)
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-König
> |
> Industrial Linux Solutions |
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe
> ngutronix.de%2F&data=02%7C01%7Cyibin.gong%40nxp.com%7Cc36708
> a8219843ffe1d308d6cecbc512%7C686ea1d3bc2b4c6fa92cd99c5c301635%7
> C0%7C1%7C636923771907346428&sdata=McF9ueExCPpCq5Nxa6iJ9h53
> 9d9fO4DIW2IaS90ZdpQ%3D&reserved=0 |
next prev parent reply other threads:[~2019-05-05 8:47 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 8:05 [PATCH v2 00/15] add ecspi ERR009165 for i.mx6/7 soc family Robin Gong
2019-04-26 8:05 ` [v2,01/15] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Robin Gong
2019-04-26 8:05 ` [PATCH v2 01/15] " Robin Gong
2019-04-26 8:05 ` [v2,02/15] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Robin Gong
2019-04-26 8:05 ` [PATCH v2 02/15] " Robin Gong
2019-04-26 8:05 ` [v2,03/15] Revert "dmaengine: imx-sdma: refine to load context only once" Robin Gong
2019-04-26 8:05 ` [PATCH v2 03/15] " Robin Gong
2019-04-26 8:05 ` [v2,04/15] dmaengine: imx-sdma: remove dupilicated sdma_load_context Robin Gong
2019-04-26 8:05 ` [PATCH v2 04/15] " Robin Gong
2019-04-26 8:05 ` [v2,05/15] dmaengine: imx-sdma: add mcu_2_ecspi script Robin Gong
2019-04-26 8:05 ` [PATCH v2 05/15] " Robin Gong
2019-04-26 8:05 ` [v2,06/15] spi: imx: fix ERR009165 Robin Gong
2019-04-26 8:05 ` [PATCH v2 06/15] " Robin Gong
2019-04-26 9:07 ` [v2,06/15] " Lucas Stach
2019-04-26 9:07 ` [PATCH v2 06/15] " Lucas Stach
2019-04-26 9:22 ` [v2,06/15] " Robin Gong
2019-04-26 9:22 ` [EXT] Re: [PATCH v2 06/15] " Robin Gong
2019-04-26 9:37 ` [v2,06/15] " Lucas Stach
2019-04-26 9:37 ` [EXT] Re: [PATCH v2 06/15] " Lucas Stach
2019-04-26 9:53 ` [v2,06/15] " Robin Gong
2019-04-26 9:53 ` [EXT] Re: [PATCH v2 06/15] " Robin Gong
2019-04-26 8:05 ` [v2,07/15] spi: imx: remove ERR009165 workaround on i.mx6ul Robin Gong
2019-04-26 8:05 ` [PATCH v2 07/15] " Robin Gong
2019-04-26 9:09 ` [v2,07/15] " Lucas Stach
2019-04-26 9:09 ` [PATCH v2 07/15] " Lucas Stach
2019-04-26 9:32 ` [v2,07/15] " Robin Gong
2019-04-26 9:32 ` [EXT] Re: [PATCH v2 07/15] " Robin Gong
2019-04-26 8:05 ` [v2,08/15] dt-bindings: spi: imx: add i.mx6ul to state errata fixed Robin Gong
2019-04-26 8:05 ` [PATCH v2 08/15] " Robin Gong
2019-05-01 20:07 ` [v2,08/15] " Rob Herring
2019-05-01 20:07 ` [PATCH v2 08/15] " Rob Herring
2019-05-05 8:55 ` [EXT] " Robin Gong
2019-05-02 6:59 ` [v2,08/15] " Uwe Kleine-König
2019-05-02 6:59 ` [PATCH v2 08/15] " Uwe Kleine-König
2019-05-05 8:47 ` Robin Gong [this message]
2019-04-26 8:05 ` [v2,09/15] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul Robin Gong
2019-04-26 8:05 ` [PATCH v2 09/15] " Robin Gong
2019-04-26 8:06 ` [v2,10/15] dt-bindings: dma: imx-sdma: add i.mx6ul/6sx compatible name Robin Gong
2019-04-26 8:06 ` [PATCH v2 10/15] " Robin Gong
2019-05-01 20:07 ` [v2,10/15] " Rob Herring
2019-05-01 20:07 ` [PATCH v2 10/15] " Rob Herring
2019-04-26 8:06 ` [v2,11/15] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm Robin Gong
2019-04-26 8:06 ` [PATCH v2 11/15] " Robin Gong
2019-04-26 8:06 ` [v2,12/15] ARM64: dts: freescale: imx8mm/8mq: update new compatible name for ecspi and sdma Robin Gong
2019-04-26 8:06 ` [PATCH v2 12/15] " Robin Gong
2019-04-26 8:06 ` [v2,13/15] ARM: dts: imx6ul: add dma support on ecspi Robin Gong
2019-04-26 8:06 ` [PATCH v2 13/15] " Robin Gong
2019-04-26 8:06 ` [v2,14/15] ARM: dts: imx6sll: correct ecspi/sdma compatible Robin Gong
2019-04-26 8:06 ` [PATCH v2 14/15] " Robin Gong
2019-04-26 8:06 ` [v2,15/15] arm64: defconfig: Enable SDMA on i.mx8mq/8mm Robin Gong
2019-04-26 8:06 ` [PATCH v2 15/15] " Robin Gong
2019-04-26 8:19 ` [PATCH v2 00/15] add ecspi ERR009165 for i.mx6/7 soc family Lucas Stach
2019-04-26 8:47 ` [EXT] " Robin Gong
2019-04-26 9:06 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB45436B23E821F02C43502D6489370@VI1PR04MB4543.eurprd04.prod.outlook.com \
--to=yibin.gong@nxp.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=plyatov@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).