* [PATCH v1 1/1] dmaengine: dw: Make it dependent to HAVE_IOMEM
@ 2021-03-24 12:18 Andy Shevchenko
2021-03-24 13:51 ` Serge Semin
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2021-03-24 12:18 UTC (permalink / raw)
To: Andy Shevchenko, dmaengine, linux-kernel
Cc: Viresh Kumar, Vinod Koul, kernel test robot
Some architectures do not provide devm_*() APIs. Hence make the driver
dependent on HAVE_IOMEM.
Fixes: dbde5c2934d1 ("dw_dmac: use devm_* functions to simplify code")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/dma/dw/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/dma/dw/Kconfig b/drivers/dma/dw/Kconfig
index e5162690de8f..dd4b56669d9f 100644
--- a/drivers/dma/dw/Kconfig
+++ b/drivers/dma/dw/Kconfig
@@ -10,6 +10,7 @@ config DW_DMAC_CORE
config DW_DMAC
tristate "Synopsys DesignWare AHB DMA platform driver"
+ depends on HAVE_IOMEM
select DW_DMAC_CORE
help
Support the Synopsys DesignWare AHB DMA controller. This
@@ -18,6 +19,7 @@ config DW_DMAC
config DW_DMAC_PCI
tristate "Synopsys DesignWare AHB DMA PCI driver"
depends on PCI
+ depends on HAVE_IOMEM
select DW_DMAC_CORE
help
Support the Synopsys DesignWare AHB DMA controller on the
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] dmaengine: dw: Make it dependent to HAVE_IOMEM
2021-03-24 12:18 [PATCH v1 1/1] dmaengine: dw: Make it dependent to HAVE_IOMEM Andy Shevchenko
@ 2021-03-24 13:51 ` Serge Semin
2021-03-24 14:16 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Serge Semin @ 2021-03-24 13:51 UTC (permalink / raw)
To: Andy Shevchenko
Cc: dmaengine, linux-kernel, Viresh Kumar, Vinod Koul, kernel test robot
Hi Andy
On Wed, Mar 24, 2021 at 02:18:22PM +0200, Andy Shevchenko wrote:
> Some architectures do not provide devm_*() APIs. Hence make the driver
> dependent on HAVE_IOMEM.
You must have meant "HAS_IOMEM", right?
-Sergey
>
> Fixes: dbde5c2934d1 ("dw_dmac: use devm_* functions to simplify code")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/dma/dw/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/dma/dw/Kconfig b/drivers/dma/dw/Kconfig
> index e5162690de8f..dd4b56669d9f 100644
> --- a/drivers/dma/dw/Kconfig
> +++ b/drivers/dma/dw/Kconfig
> @@ -10,6 +10,7 @@ config DW_DMAC_CORE
>
> config DW_DMAC
> tristate "Synopsys DesignWare AHB DMA platform driver"
> + depends on HAVE_IOMEM
> select DW_DMAC_CORE
> help
> Support the Synopsys DesignWare AHB DMA controller. This
> @@ -18,6 +19,7 @@ config DW_DMAC
> config DW_DMAC_PCI
> tristate "Synopsys DesignWare AHB DMA PCI driver"
> depends on PCI
> + depends on HAVE_IOMEM
> select DW_DMAC_CORE
> help
> Support the Synopsys DesignWare AHB DMA controller on the
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] dmaengine: dw: Make it dependent to HAVE_IOMEM
2021-03-24 13:51 ` Serge Semin
@ 2021-03-24 14:16 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-03-24 14:16 UTC (permalink / raw)
To: Serge Semin
Cc: dmaengine, linux-kernel, Viresh Kumar, Vinod Koul, kernel test robot
On Wed, Mar 24, 2021 at 04:51:16PM +0300, Serge Semin wrote:
> Hi Andy
>
> On Wed, Mar 24, 2021 at 02:18:22PM +0200, Andy Shevchenko wrote:
> > Some architectures do not provide devm_*() APIs. Hence make the driver
> > dependent on HAVE_IOMEM.
>
> You must have meant "HAS_IOMEM", right?
Good catch!
My memory tricked me :-)
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-24 14:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 12:18 [PATCH v1 1/1] dmaengine: dw: Make it dependent to HAVE_IOMEM Andy Shevchenko
2021-03-24 13:51 ` Serge Semin
2021-03-24 14:16 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).