* [PATCH] [v2] dmaengine: tegra20: Fix runtime PM imbalance on error
@ 2021-04-09 8:28 Dinghao Liu
2021-04-09 11:33 ` Thierry Reding
2021-04-12 9:40 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Dinghao Liu @ 2021-04-09 8:28 UTC (permalink / raw)
To: dinghao.liu, kjlu
Cc: Laxman Dewangan, Jon Hunter, Vinod Koul, Thierry Reding,
dmaengine, linux-tegra, linux-kernel
pm_runtime_get_sync() will increase the runtime PM counter
even it returns an error. Thus a pairing decrement is needed
to prevent refcount leak. Fix this by replacing this API with
pm_runtime_resume_and_get(), which will not change the runtime
PM counter on error.
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
Changelog:
v2: - Fix another similar case in tegra_dma_synchronize().
---
drivers/dma/tegra20-apb-dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index 71827d9b0aa1..b7260749e8ee 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -723,7 +723,7 @@ static void tegra_dma_issue_pending(struct dma_chan *dc)
goto end;
}
if (!tdc->busy) {
- err = pm_runtime_get_sync(tdc->tdma->dev);
+ err = pm_runtime_resume_and_get(tdc->tdma->dev);
if (err < 0) {
dev_err(tdc2dev(tdc), "Failed to enable DMA\n");
goto end;
@@ -818,7 +818,7 @@ static void tegra_dma_synchronize(struct dma_chan *dc)
struct tegra_dma_channel *tdc = to_tegra_dma_chan(dc);
int err;
- err = pm_runtime_get_sync(tdc->tdma->dev);
+ err = pm_runtime_resume_and_get(tdc->tdma->dev);
if (err < 0) {
dev_err(tdc2dev(tdc), "Failed to synchronize DMA: %d\n", err);
return;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [v2] dmaengine: tegra20: Fix runtime PM imbalance on error
2021-04-09 8:28 [PATCH] [v2] dmaengine: tegra20: Fix runtime PM imbalance on error Dinghao Liu
@ 2021-04-09 11:33 ` Thierry Reding
2021-04-12 9:40 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2021-04-09 11:33 UTC (permalink / raw)
To: Dinghao Liu
Cc: kjlu, Laxman Dewangan, Jon Hunter, Vinod Koul, dmaengine,
linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On Fri, Apr 09, 2021 at 04:28:05PM +0800, Dinghao Liu wrote:
> pm_runtime_get_sync() will increase the runtime PM counter
> even it returns an error. Thus a pairing decrement is needed
> to prevent refcount leak. Fix this by replacing this API with
> pm_runtime_resume_and_get(), which will not change the runtime
> PM counter on error.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
>
> Changelog:
>
> v2: - Fix another similar case in tegra_dma_synchronize().
> ---
> drivers/dma/tegra20-apb-dma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Looks good:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [v2] dmaengine: tegra20: Fix runtime PM imbalance on error
2021-04-09 8:28 [PATCH] [v2] dmaengine: tegra20: Fix runtime PM imbalance on error Dinghao Liu
2021-04-09 11:33 ` Thierry Reding
@ 2021-04-12 9:40 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-04-12 9:40 UTC (permalink / raw)
To: Dinghao Liu
Cc: kjlu, Laxman Dewangan, Jon Hunter, Thierry Reding, dmaengine,
linux-tegra, linux-kernel
On 09-04-21, 16:28, Dinghao Liu wrote:
> pm_runtime_get_sync() will increase the runtime PM counter
> even it returns an error. Thus a pairing decrement is needed
> to prevent refcount leak. Fix this by replacing this API with
> pm_runtime_resume_and_get(), which will not change the runtime
> PM counter on error.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-12 9:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 8:28 [PATCH] [v2] dmaengine: tegra20: Fix runtime PM imbalance on error Dinghao Liu
2021-04-09 11:33 ` Thierry Reding
2021-04-12 9:40 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).