From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB73DC47082 for ; Mon, 31 May 2021 04:09:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C32CC6120E for ; Mon, 31 May 2021 04:09:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229475AbhEaELH (ORCPT ); Mon, 31 May 2021 00:11:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:57014 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbhEaELG (ORCPT ); Mon, 31 May 2021 00:11:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 73744611CA; Mon, 31 May 2021 04:09:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622434167; bh=+96H0DiwYnLTSciM+R0oUuL+G2kj34SB/CV5Rl21cqU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mtIfzjUnkbdIwFzyEuJP1kvYfHO7nBBLXklpKDS/YZtsWHm/q787HZgZ+oXmNkutO /qvzmv5Ej382Lor4O42/lOddMjhlo2jYQYJDxZKL3wT2dnKH4/hOBRfLM2BHrHxpyy U+4zvI/5HrOhjqXQMjuPFKiYwHTZhaW4ayVLVcEVxdMtIS42CrnAwDHOmXQx2NWMjB XXP34MmZtjAYupwUvcRdcqC+XuU5h6tXfXywmjIg/ZnR4SPAM/VzupQy5K2ae/MlDe haeK695P2w3nhtLTLbZMUyTT2k79fspKDhE/NJSDTuMFrpQDcqB5DfFpG4yX+3mGof bQoEpXiojWBoQ== Date: Mon, 31 May 2021 09:39:23 +0530 From: Vinod Koul To: Dave Jiang Cc: Nikhil Rao , dmaengine@vger.kernel.org Subject: Re: [PATCH] dmaengine: idxd: Add missing cleanup for early error out in probe call Message-ID: References: <162197061707.392656.15760573520817310791.stgit@djiang5-desk3.ch.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162197061707.392656.15760573520817310791.stgit@djiang5-desk3.ch.intel.com> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 25-05-21, 12:23, Dave Jiang wrote: > The probe call stack is missing some cleanup when things fail in the > middle. Add the appropriate cleanup routines to make sure we exit > gracefully. Applied, thanks -- ~Vinod