From: Vinod Koul <vkoul@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH -next] dma: ipu: fix doc warning in ipu_irq.c
Date: Thu, 3 Jun 2021 12:31:58 +0530 [thread overview]
Message-ID: <YLh+ZrjXhPN6kxdT@vkoul-mobl> (raw)
In-Reply-To: <20210601115938.3193296-1-yangyingliang@huawei.com>
On 01-06-21, 19:59, Yang Yingliang wrote:
> Fix the following make W=1 warning:
>
> drivers/dma/ipu/ipu_irq.c:238: warning: expecting prototype for ipu_irq_map(). Prototype was for ipu_irq_unmap() instead
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/dma/ipu/ipu_irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ipu/ipu_irq.c b/drivers/dma/ipu/ipu_irq.c
> index 0d5c42f7bfa4..dc44294b79b5 100644
> --- a/drivers/dma/ipu/ipu_irq.c
> +++ b/drivers/dma/ipu/ipu_irq.c
> @@ -230,7 +230,7 @@ int ipu_irq_map(unsigned int source)
> }
>
> /**
> - * ipu_irq_map() - map an IPU interrupt source to an IRQ number
> + * ipu_irq_unmap() - map an IPU interrupt source to an IRQ number
the description does not match and should be fixed as well
> * @source: interrupt source bit position (see ipu_irq_map())
> * @return: 0 or negative error code
> */
> --
> 2.25.1
--
~Vinod
prev parent reply other threads:[~2021-06-03 7:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 11:59 [PATCH -next] dma: ipu: fix doc warning in ipu_irq.c Yang Yingliang
2021-06-03 7:01 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLh+ZrjXhPN6kxdT@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).