From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Viresh Kumar <vireshk@kernel.org>
Subject: Re: [PATCH v2 1/1] dmaengine: dw: Program xBAR hardware for Elkhart Lake
Date: Thu, 24 Jun 2021 16:48:38 +0300 [thread overview]
Message-ID: <YNSNNmd/OYxUDGhW@smile.fi.intel.com> (raw)
In-Reply-To: <YNRpkMMDE5B9NY9J@matsya>
On Thu, Jun 24, 2021 at 04:46:32PM +0530, Vinod Koul wrote:
> On 14-06-21, 16:30, Andy Shevchenko wrote:
> > Intel Elkhart Lake PSE DMA implementation is integrated with crossbar IP
> > in order to serve more hardware than there are DMA request lines available.
> >
> > Due to this, program xBAR hardware to make flexible support of PSE peripheral.
> >
> > The Device-to-Device has not been tested and it's not supported by DMA Engine,
> > but it's left in the code for the sake of documenting hardware features.
>
> Kernel does not like to keep dead code, please remove this. It can be
> added back when we have users
I would rather keep it as documentation (converted to comment perhaps).
In any case, it seems the suitable point of time to contribute will be
already after v5.14-rc1.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-06-24 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 13:30 [PATCH v2 1/1] dmaengine: dw: Program xBAR hardware for Elkhart Lake Andy Shevchenko
2021-06-24 11:16 ` Vinod Koul
2021-06-24 13:48 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNSNNmd/OYxUDGhW@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).