dmaengine.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: dmaengine@vger.kernel.org, Akinobu Mita <akinobu.mita@gmail.com>,
	Kedareswara rao Appana <appana.durga.rao@xilinx.com>,
	Michal Simek <monstr@monstr.eu>,
	Vinod Koul <vinod.koul@intel.com>
Subject: Re: [PATCH] dmaengine: xilinx: Add empty device_config function
Date: Sat, 17 Jul 2021 20:04:50 +0530	[thread overview]
Message-ID: <YPLqisxSMe6wzQuk@matsya> (raw)
In-Reply-To: <d0009412-abc1-68cb-e7c4-1a11d6ea0fe4@denx.de>

On 17-07-21, 14:01, Marek Vasut wrote:
> On 7/17/21 1:36 PM, Vinod Koul wrote:
> > On 16-07-21, 20:22, Marek Vasut wrote:
> > > Various DMA users call the dmaengine_slave_config() and expect it to
> > > succeed, but that can only succeed if .device_config is implemented.
> > > Add empty device_config function rather than patching all the places
> > > which use dmaengine_slave_config().
> > 
> > .device_config is optional, Yes the dmaengine_slave_config() will check
> > and return error...
> > 
> > I think it would make sense to handle this in caller... (ignore
> > ENOSYS..) rather than add a dummy one
> 
> That's what I was trying to avoid -- patching all the places in kernel which
> might fail. Why handle it in caller ?

And how many places would that be..? The xilinx driver using xilinx
dma right>

> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Cc: Akinobu Mita <akinobu.mita@gmail.com>
> > > Cc: Kedareswara rao Appana <appana.durga.rao@xilinx.com>
> > > Cc: Michal Simek <monstr@monstr.eu>
> > > Cc: Vinod Koul <vinod.koul@intel.com>
> > 
> > ummm..? you really need to update this :)
> 
> I had the patch around for a while indeed, it fell through the cracks.

This has to be more than 3 yrs old then!

-- 
~Vinod

  reply	other threads:[~2021-07-17 14:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-16 18:22 [PATCH] dmaengine: xilinx: Add empty device_config function Marek Vasut
2021-07-17 11:36 ` Vinod Koul
2021-07-17 12:01   ` Marek Vasut
2021-07-17 14:34     ` Vinod Koul [this message]
2021-07-17 14:48       ` Marek Vasut
2021-07-28 11:07         ` Vinod Koul
2021-07-18 19:38 ` kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2020-06-13 14:58 Marek Vasut
2020-06-14 15:38 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPLqisxSMe6wzQuk@matsya \
    --to=vkoul@kernel.org \
    --cc=akinobu.mita@gmail.com \
    --cc=appana.durga.rao@xilinx.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=monstr@monstr.eu \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).