From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54E36C07E95 for ; Tue, 20 Jul 2021 11:47:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D1406113A for ; Tue, 20 Jul 2021 11:47:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236874AbhGTLGJ (ORCPT ); Tue, 20 Jul 2021 07:06:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:47710 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237775AbhGTLD2 (ORCPT ); Tue, 20 Jul 2021 07:03:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D69946113A; Tue, 20 Jul 2021 11:43:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626781437; bh=MHZkExzU8HdUKUa0EhCAB0MiLdwoljiL9Ho9vDzs0HY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mzQ6fmwIsG8MwWggE9QSHUgeypP49IlnS6UMaR6ZMs4bdbM/D9ETK7+JGHmtY2F8s LrwgoOW4lMcPIbZMx5EQGSagD2ldDDtjYLX5OAUzUjATcDkGjlwHlg4kMBP5xUXwP+ lWJ4qgsns0ZFpV6YKHOrujoyKqKszALyffhB0ttKYEcKyRBoGY5t9+GoQacyalDvkv tA2znRT8OC4LD3kLsxJa+P93jJCGta2RvJUI70nX++3yA71LJInMElieZF8TQ8LYQZ NOtMX85HLS75eKBEqp+mZWyzLITIyzEQdka/IC+qdufQD9wdrv8RFXb9lALkaBwSry J+uopTF42Re7g== Date: Tue, 20 Jul 2021 17:13:53 +0530 From: Vinod Koul To: Greg KH Cc: Kelvin Cheung , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V5] dmaengine: Loongson1: Add Loongson1 dmaengine driver Message-ID: References: <20210704153314.6995-1-keguang.zhang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 17-07-21, 19:39, Greg KH wrote: > On Sat, Jul 17, 2021 at 08:09:45PM +0530, Vinod Koul wrote: > > On 17-07-21, 18:57, Kelvin Cheung wrote: > > > Vinod Koul 于2021年7月14日周三 下午1:14写道： > > > > > > > > On 04-07-21, 23:33, Keguang Zhang wrote: > > > > > > > > > +static struct platform_driver ls1x_dma_driver = { > > > > > + .probe = ls1x_dma_probe, > > > > > + .remove = ls1x_dma_remove, > > > > > + .driver = { > > > > > + .name = "ls1x-dma", > > > > > + }, > > > > > +}; > > > > > + > > > > > +module_platform_driver(ls1x_dma_driver); > > > > > > > > so my comment was left unanswered, who creates this device! > > > > > > Sorry! > > > This patch will create the device: https://patchwork.kernel.org/patch/12281691 > > > > Greg, looks like the above patch creates platform devices in mips, is > > that the right way..? > > I do not understand, what exactly is the question? So this patch was adding Loongson1 dmaengine driver which is a platform device. I asked about the platform device and was told that [1] creates the platform device. I am not sure if that is the recommended way given that you have been asking people to not use platform devices. [1]: https://patchwork.kernel.org/patch/12281691 So is [1] the correct approach or should this be fixed? -- ~Vinod