From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E33C07E9B for ; Tue, 20 Jul 2021 11:49:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFE9D600D1 for ; Tue, 20 Jul 2021 11:49:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237614AbhGTLId (ORCPT ); Tue, 20 Jul 2021 07:08:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:49660 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237648AbhGTLIM (ORCPT ); Tue, 20 Jul 2021 07:08:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D0E0E600D1; Tue, 20 Jul 2021 11:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626781731; bh=OBvLrQnyZF2Svj2jZQUersvmOrA/Ciz1z2w++07BYns=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZmlaK3l5Sw3ZxBWCkPqBM/dD8n+JvI/23hhA77y6YbAP8/jrZXeEXkrIzSZLon5Ot cm0QyoRBh/zfMXbQzQ3/XcbqjCFoeTPzuy9aPu8T5sbsniB6Tg98xbyg9KZn5asHlE e5HhEaTWV6TCCjLRD4QcrD5DJUhIq8BIGag5YcBw= Date: Tue, 20 Jul 2021 13:48:48 +0200 From: Greg KH To: Vinod Koul Cc: Kelvin Cheung , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V5] dmaengine: Loongson1: Add Loongson1 dmaengine driver Message-ID: References: <20210704153314.6995-1-keguang.zhang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Tue, Jul 20, 2021 at 05:13:53PM +0530, Vinod Koul wrote: > On 17-07-21, 19:39, Greg KH wrote: > > On Sat, Jul 17, 2021 at 08:09:45PM +0530, Vinod Koul wrote: > > > On 17-07-21, 18:57, Kelvin Cheung wrote: > > > > Vinod Koul 于2021年7月14日周三 下午1:14写道： > > > > > > > > > > On 04-07-21, 23:33, Keguang Zhang wrote: > > > > > > > > > > > +static struct platform_driver ls1x_dma_driver = { > > > > > > + .probe = ls1x_dma_probe, > > > > > > + .remove = ls1x_dma_remove, > > > > > > + .driver = { > > > > > > + .name = "ls1x-dma", > > > > > > + }, > > > > > > +}; > > > > > > + > > > > > > +module_platform_driver(ls1x_dma_driver); > > > > > > > > > > so my comment was left unanswered, who creates this device! > > > > > > > > Sorry! > > > > This patch will create the device: https://patchwork.kernel.org/patch/12281691 > > > > > > Greg, looks like the above patch creates platform devices in mips, is > > > that the right way..? > > > > I do not understand, what exactly is the question? > > So this patch was adding Loongson1 dmaengine driver which is a platform > device. I asked about the platform device and was told that [1] creates > the platform device. I am not sure if that is the recommended way given > that you have been asking people to not use platform devices. Yes, but this link: > [1]: https://patchwork.kernel.org/patch/12281691 Does look like a "real" platform device in that you have fixed resources for the device and no way to discover it on your own. But why are you not using DT for this? That looks like the old platform data files. thanks, greg k-h