From: Vinod Koul <vkoul@kernel.org>
To: Dave Jiang <dave.jiang@intel.com>
Cc: dmaengine@vger.kernel.org, dan.j.williams@intel.com
Subject: Re: [PATCH] dmaengine: idxd: fix sequence for pci driver remove() and shutdown()
Date: Tue, 20 Jul 2021 19:18:15 +0530 [thread overview]
Message-ID: <YPbUH7w3gHGsxRfG@matsya> (raw)
In-Reply-To: <162629983901.395844.17964803190905549615.stgit@djiang5-desk3.ch.intel.com>
On 14-07-21, 14:57, Dave Jiang wrote:
> ->shutdown() call should only be responsible for quiescing the device.
> Currently it is doing PCI device tear down. This causes issue when things
> like MMIO mapping is removed while idxd_unregister_devices() will trigger
> removal of idxd device sub-driver and still initiates MMIO writes to the
> device. Another issue is with the unregistering of idxd 'struct device',
> the memory context gets freed. So the teardown calls are accessing freed
> memory and can cause kernel oops. Move all the teardown bits that doesn't
> belong in shutdown to ->remove() call. Move unregistering of the idxd
> conf_dev 'struct device' to after doing all the teardown to free all
> the memory that's no longer needed.
Applied to fixes, thanks
--
~Vinod
prev parent reply other threads:[~2021-07-20 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 21:57 [PATCH] dmaengine: idxd: fix sequence for pci driver remove() and shutdown() Dave Jiang
2021-07-20 13:48 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPbUH7w3gHGsxRfG@matsya \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).