From: Greg KH <email@example.com> To: Sanjay R Mehta <firstname.lastname@example.org> Cc: Sanjay R Mehta <Sanju.Mehta@amd.com>, email@example.com, firstname.lastname@example.org, Thomas.Lendacky@amd.com, Shyam-sundar.Semail@example.com, Nehal-bakulchandra.Shah@amd.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: [PATCH v10 0/3] Add support for AMD PTDMA controller driver Date: Thu, 22 Jul 2021 16:19:25 +0200 [thread overview] Message-ID: <YPl+bY2z1BfkhQR9@kroah.com> (raw) In-Reply-To: <email@example.com> On Thu, Jul 22, 2021 at 07:27:51PM +0530, Sanjay R Mehta wrote: > > > On 6/20/2021 10:11 PM, Sanjay R Mehta wrote: > > From: Sanjay R Mehta <firstname.lastname@example.org> > > > > This patch series add support for AMD PTDMA controller which > > performs high bandwidth memory-to-memory and IO copy operation, > > performs DMA transfer through queue based descriptor management. > > > > AMD Processor has multiple ptdma device instances with each controller > > having single queue. The driver also adds support for for multiple PTDMA > > instances, each device will get an unique identifier and uniquely > > named resources. > > > > v10: > > - modified ISR to return IR_HANDLED only in non-error condition. > > - removed unnecessary prints, variables and made some cosmetic changes. > > - removed pt_ordinal atomic variable and instead using dev_name() > > for device name. > > - removed the cmdlist dependency and instead using vc.desc_issued list. > > - freeing the desc and list which was missing in the pt_terminate_all() > > funtion. > > - Added comment for marking PTDMA as DMA_PRIVATE. > > - removed unused pt_debugfs_lock from debufs code. > > - keeping same file permision for all the debug directoris. > > > > v9: > > - Modified the help message in Kconfig as per Randy's comment. > > - reverted the split of code for "pt_handle_active_desc" as there > > was driver hang being observerd after few iterations. > > > > v8: > > - splitted the code into different functions, one to find active desc > > and second to complete and invoke callback. > > - used FIELD_PREP & FIELD_GET instead of union struct bitfields. > > - modified all style fixes as per the comments. > > > > v7: > > - Fixed module warnings reported ( by kernel test robot <email@example.com> ). > > > > v6: > > - Removed debug artifacts and made the suggested cosmetic changes. > > - implemented and used to_pt_chan and to_pt_desc inline functions. > > - Removed src and dst address check as framework does this. > > - Removed devm_kcalloc() usage and used devm_kzalloc() api. > > - Using framework debugfs directory to store dma info. > > > > v5: > > - modified code to submit next tranction in ISR itself and removed the tasklet. > > - implemented .device_synchronize API. > > - converted debugfs code by using DEFINE_SHOW_ATTRIBUTE() > > - using dbg_dev_root for debugfs root directory. > > - removed dma_status from pt_dma_chan > > - removed module parameter cmd_queue_lenght. > > - removed global device list for multiple devics. > > - removed code related to dynamic adding/deleting to device list > > - removed pt_add_device and pt_del_device functions > > > > v4: > > - modified DMA channel and descriptor management using virt-dma layer > > instead of list based management. > > - return only status of the cookie from pt_tx_status > > - copyright year changed from 2019 to 2020 > > - removed dummy code for suspend & resume > > - used bitmask and genmask > > > > v3: > > - Fixed the sparse warnings. > > > > v2: > > - Added controller description in cover letter > > - Removed "default m" from Kconfig > > - Replaced low_address() and high_address() functions with kernel > > API's lower_32_bits & upper_32_bits(). > > - Removed the BH handler function pt_core_irq_bh() and instead > > handling transaction in irq handler itself. > > - Moved presetting of command queue registers into new function > > "init_cmdq_regs()" > > - Removed the kernel thread dependency to submit transaction. > > - Increased the hardware command queue size to 32 and adding it > > as a module parameter. > > - Removed backlog command queue handling mechanism. > > - Removed software command queue handling and instead submitting > > transaction command directly to > > hardware command queue. > > - Added tasklet structure variable in "struct pt_device". > > This is used to invoke pt_do_cmd_complete() upon receiving interrupt > > for command completion. > > - pt_core_perform_passthru() function parameters are modified and it is > > now used to submit command directly to hardware from dmaengine framew > > - Removed below structures, enums, macros and functions, as these value > > constants. Making command submission simple, > > - Removed "union pt_function" and several macros like PT_VERSION, > > PT_BYTESWAP, PT_CMD_* etc.. > > - enum pt_passthru_bitwise, enum pt_passthru_byteswap, enum pt_memty > > struct pt_dma_info, struct pt_data, struct pt_mem, struct pt_passt > > struct pt_op, > > > > Links of the review comments for v10: > > 1. https://lkml.org/lkml/2021/6/8/976 > > 2. https://lkml.org/lkml/2021/6/16/7 > > 3. https://lkml.org/lkml/2021/6/16/65 > > 4. https://lkml.org/lkml/2021/6/16/192 > > 5. https://lkml.org/lkml/2021/6/16/273 > > 6. https://lkml.org/lkml/2021/6/8/1698 > > 7. https://lkml.org/lkml/2021/6/16/8 > > 8. https://lkml.org/lkml/2021/6/9/808 > > > > Links of the review comments for v7: > > 1. https://lkml.org/lkml/2020/11/18/351 > > 2. https://lkml.org/lkml/2020/11/18/384 > > > > Links of the review comments for v5: > > 1. https://lkml.org/lkml/2020/7/3/154 > > 2. https://lkml.org/lkml/2020/8/25/431 > > 3. https://lkml.org/lkml/2020/7/3/177 > > 4. https://lkml.org/lkml/2020/7/3/186 > > > > Links of the review comments for v5: > > 1. https://lkml.org/lkml/2020/5/4/42 > > 2. https://lkml.org/lkml/2020/5/4/45 > > 3. https://lkml.org/lkml/2020/5/4/38 > > 4. https://lkml.org/lkml/2020/5/26/70 > > > > Links of the review comments for v4: > > 1. https://lkml.org/lkml/2020/1/24/12 > > 2. https://lkml.org/lkml/2020/1/24/17 > > > > Links of the review comments for v2: > > 1https://lkml.org/lkml/2019/12/27/630 > > 2. https://lkml.org/lkml/2020/1/3/23 > > 3. https://lkml.org/lkml/2020/1/3/314 > > 4. https://lkml.org/lkml/2020/1/10/100 > > > > Links of the review comments for v1: > > 1. https://lkml.org/lkml/2019/9/24/490 > > 2. https://lkml.org/lkml/2019/9/24/399 > > 3. https://lkml.org/lkml/2019/9/24/862 > > 4. https://lkml.org/lkml/2019/9/24/122 > > > > Sanjay R Mehta (3): > > dmaengine: ptdma: Initial driver for the AMD PTDMA > > dmaengine: ptdma: register PTDMA controller as a DMA resource > > dmaengine: ptdma: Add debugfs entries for PTDMA > > > > MAINTAINERS | 6 + > > drivers/dma/Kconfig | 2 + > > drivers/dma/Makefile | 1 + > > drivers/dma/ptdma/Kconfig | 13 ++ > > drivers/dma/ptdma/Makefile | 10 + > > drivers/dma/ptdma/ptdma-debugfs.c | 110 ++++++++++ > > drivers/dma/ptdma/ptdma-dev.c | 327 ++++++++++++++++++++++++++++++ > > drivers/dma/ptdma/ptdma-dmaengine.c | 389 ++++++++++++++++++++++++++++++++++++ > > drivers/dma/ptdma/ptdma-pci.c | 245 +++++++++++++++++++++++ > > drivers/dma/ptdma/ptdma.h | 334 +++++++++++++++++++++++++++++++ > > 10 files changed, 1437 insertions(+) > > create mode 100644 drivers/dma/ptdma/Kconfig > > create mode 100644 drivers/dma/ptdma/Makefile > > create mode 100644 drivers/dma/ptdma/ptdma-debugfs.c > > create mode 100644 drivers/dma/ptdma/ptdma-dev.c > > create mode 100644 drivers/dma/ptdma/ptdma-dmaengine.c > > create mode 100644 drivers/dma/ptdma/ptdma-pci.c > > create mode 100644 drivers/dma/ptdma/ptdma.h > > Hi Vinod, Greg, > > > I had re-sent this patch series as per your advice a month ago with all > the review feedback's addressed. > > Need your guidance and feedback to get this code reviewed and up-streamed. That is up to the drivers/dma/ maintainer, which is Vinod, not me :) thanks, greg k-h
prev parent reply other threads:[~2021-07-22 14:21 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-20 16:41 Sanjay R Mehta 2021-06-20 16:41 ` [PATCH v10 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA Sanjay R Mehta 2021-07-28 5:55 ` Vinod Koul 2021-07-28 9:16 ` Sanjay R Mehta 2021-06-20 16:41 ` [PATCH v10 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource Sanjay R Mehta 2021-07-28 6:15 ` Vinod Koul 2021-07-29 10:12 ` Sanjay R Mehta 2021-06-20 16:41 ` [PATCH v10 3/3] dmaengine: ptdma: Add debugfs entries for PTDMA Sanjay R Mehta 2021-07-22 13:57 ` [PATCH v10 0/3] Add support for AMD PTDMA controller driver Sanjay R Mehta 2021-07-22 14:10 ` Vinod Koul 2021-07-22 14:32 ` Sanjay R Mehta 2021-07-22 14:19 ` Greg KH [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YPl+bY2z1BfkhQR9@kroah.com \ --firstname.lastname@example.org \ --cc=Nehal-bakulchandra.Shah@amd.com \ --cc=Sanju.Mehta@amd.com \ --cc=Shyam-sundar.Semail@example.com \ --cc=Thomas.Lendacky@amd.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v10 0/3] Add support for AMD PTDMA controller driver' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).