From: Vinod Koul <vkoul@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, tony@atomide.com, nm@ti.com
Subject: Re: [PATCH] dmaengine: of-dma: router_xlate to return -EPROBE_DEFER if controller is not yet available
Date: Wed, 28 Jul 2021 12:42:18 +0530 [thread overview]
Message-ID: <YQEDUkY3BHV2OqRR@matsya> (raw)
In-Reply-To: <20210717190021.21897-1-peter.ujfalusi@gmail.com>
On 17-07-21, 22:00, Peter Ujfalusi wrote:
> If the router_xlate can not find the controller in the available DMA
> devices then it should return with -EPORBE_DEFER in a same way as the
> of_dma_request_slave_channel() does.
>
> The issue can be reproduced if the event router is registered before the
> DMA controller itself and a driver would request for a channel before the
> controller is registered.
> In of_dma_request_slave_channel():
> 1. of_dma_find_controller() would find the dma_router
> 2. ofdma->of_dma_xlate() would fail and returned NULL
> 3. -ENODEV is returned as error code
>
> with this patch we would return in this case the correct -EPROBE_DEFER and
> the client can try to request the channel later.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2021-07-28 7:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 19:00 [PATCH] dmaengine: of-dma: router_xlate to return -EPROBE_DEFER if controller is not yet available Peter Ujfalusi
2021-07-28 7:12 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQEDUkY3BHV2OqRR@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=peter.ujfalusi@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).