From: Vinod Koul <vkoul@kernel.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: dmaengine@vger.kernel.org, agross@kernel.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, thara.gopinath@gmail.com,
devicetree@vger.kernel.org, andersson@kernel.org,
bhupesh.linux@gmail.com, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v7 1/1] dma: qcom: bam_dma: Add support to initialize interconnect path
Date: Thu, 22 Sep 2022 08:08:13 +0530 [thread overview]
Message-ID: <YyvKlWgaPVV3su8f@matsya> (raw)
In-Reply-To: <20220921030649.1436434-2-bhupesh.sharma@linaro.org>
On 21-09-22, 08:36, Bhupesh Sharma wrote:
> From: Thara Gopinath <thara.gopinath@gmail.com>
>
> BAM dma engine associated with certain hardware blocks could require
> relevant interconnect pieces be initialized prior to the dma engine
> initialization. For e.g. crypto bam dma engine on sm8250. Such requirement
> is passed on to the bam dma driver from dt via the "interconnects"
> property. Add support in bam_dma driver to check whether the interconnect
> path is accessible/enabled prior to attempting driver intializations.
>
> If interconnects are not yet setup, defer the BAM DMA driver probe().
>
> Cc: Bjorn Andersson <andersson@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Thara Gopinath <thara.gopinath@gmail.com>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> [Bhupesh: Make header file inclusion alphabetical and use 'devm_of_icc_get()']
> ---
> drivers/dma/qcom/bam_dma.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c
> index 2ff787df513e..a5b0cf28ffb7 100644
> --- a/drivers/dma/qcom/bam_dma.c
> +++ b/drivers/dma/qcom/bam_dma.c
> @@ -26,6 +26,7 @@
> #include <linux/kernel.h>
> #include <linux/io.h>
> #include <linux/init.h>
> +#include <linux/interconnect.h>
> #include <linux/slab.h>
> #include <linux/module.h>
> #include <linux/interrupt.h>
> @@ -394,6 +395,7 @@ struct bam_device {
> const struct reg_offset_data *layout;
>
> struct clk *bamclk;
> + struct icc_path *mem_path;
> int irq;
>
> /* dma start transaction tasklet */
> @@ -1294,6 +1296,14 @@ static int bam_dma_probe(struct platform_device *pdev)
> if (IS_ERR(bdev->bamclk))
> return PTR_ERR(bdev->bamclk);
>
> + /* Ensure that interconnects are initialized */
> + bdev->mem_path = devm_of_icc_get(bdev->dev, "memory");
> + if (IS_ERR(bdev->mem_path)) {
> + ret = dev_err_probe(bdev->dev, PTR_ERR(bdev->mem_path),
> + "failed to acquire icc path\n");
> + return ret;
> + }
So this makes us fail on older DT where icc path may not be present.
Should this not be an optional thing?
> +
> ret = clk_prepare_enable(bdev->bamclk);
> if (ret) {
> dev_err(bdev->dev, "failed to prepare/enable clock\n");
> --
> 2.37.1
--
~Vinod
next prev parent reply other threads:[~2022-09-22 2:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 3:06 [PATCH v7 0/1] dma: qcom: bam_dma: Add support to initialize interconnect path Bhupesh Sharma
2022-09-21 3:06 ` [PATCH v7 1/1] " Bhupesh Sharma
2022-09-22 2:38 ` Vinod Koul [this message]
2022-09-23 5:10 ` Bhupesh Sharma
2022-12-28 16:15 ` Dmitry Baryshkov
2023-02-16 14:18 ` Vladimir Zapolskiy
2023-02-17 4:00 ` Bhupesh Sharma
2023-02-17 7:07 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyvKlWgaPVV3su8f@matsya \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).