* [PATCH] dmaengine: tegra: explicitly select DMA_VIRTUAL_CHANNELS
@ 2023-03-29 17:21 Mark Salter
2023-03-31 8:03 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Mark Salter @ 2023-03-29 17:21 UTC (permalink / raw)
To: Vinod Koul; +Cc: dmaengine
Enabling TEGRA186_GPC_DMA will cause this build failure unless some other
DMA driver which uses DMA_VIRTUAL_CHANNELS is enabled:
ERROR: modpost: "vchan_dma_desc_free_list" [drivers/dma/tegra186-gpc-dma.ko] undefined!
ERROR: modpost: "vchan_init" [drivers/dma/tegra186-gpc-dma.ko] undefined!
ERROR: modpost: "vchan_tx_submit" [drivers/dma/tegra186-gpc-dma.ko] undefined!
ERROR: modpost: "vchan_tx_desc_free" [drivers/dma/tegra186-gpc-dma.ko] undefined!
ERROR: modpost: "vchan_find_desc" [drivers/dma/tegra186-gpc-dma.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
Add an explicit select of DMA_VIRTUAL_CHANNELS to avoid this.
Signed-off-by: Mark Salter <msalter@redhat.com>
---
drivers/dma/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index fb7073fc034f..f5f422f9b850 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -623,6 +623,7 @@ config TEGRA186_GPC_DMA
depends on (ARCH_TEGRA || COMPILE_TEST) && ARCH_DMA_ADDR_T_64BIT
depends on IOMMU_API
select DMA_ENGINE
+ select DMA_VIRTUAL_CHANNELS
help
Support for the NVIDIA Tegra General Purpose Central DMA controller.
The DMA controller has multiple DMA channels which can be configured
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dmaengine: tegra: explicitly select DMA_VIRTUAL_CHANNELS
2023-03-29 17:21 [PATCH] dmaengine: tegra: explicitly select DMA_VIRTUAL_CHANNELS Mark Salter
@ 2023-03-31 8:03 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2023-03-31 8:03 UTC (permalink / raw)
To: Mark Salter; +Cc: dmaengine
On 29-03-23, 13:21, Mark Salter wrote:
> Enabling TEGRA186_GPC_DMA will cause this build failure unless some other
> DMA driver which uses DMA_VIRTUAL_CHANNELS is enabled:
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-31 8:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-29 17:21 [PATCH] dmaengine: tegra: explicitly select DMA_VIRTUAL_CHANNELS Mark Salter
2023-03-31 8:03 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).