* [PATCH] dmaengine: sh: rz-dmac: Remove unused rz_dmac_chan.*_word_size
@ 2023-03-27 9:48 Geert Uytterhoeven
2023-03-27 9:53 ` Biju Das
2023-03-31 12:00 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2023-03-27 9:48 UTC (permalink / raw)
To: Vinod Koul, Biju Das; +Cc: dmaengine, linux-renesas-soc, Geert Uytterhoeven
The src_word_size and dst_word_size members of the rz_dmac_chan
structure were never used, so they can be removed.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/dma/sh/rz-dmac.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c
index 6b62e01ba658ac13..9479f29692d3e3d7 100644
--- a/drivers/dma/sh/rz-dmac.c
+++ b/drivers/dma/sh/rz-dmac.c
@@ -67,8 +67,6 @@ struct rz_dmac_chan {
struct rz_dmac_desc *desc;
int descs_allocated;
- enum dma_slave_buswidth src_word_size;
- enum dma_slave_buswidth dst_word_size;
dma_addr_t src_per_address;
dma_addr_t dst_per_address;
@@ -603,9 +601,7 @@ static int rz_dmac_config(struct dma_chan *chan,
u32 val;
channel->src_per_address = config->src_addr;
- channel->src_word_size = config->src_addr_width;
channel->dst_per_address = config->dst_addr;
- channel->dst_word_size = config->dst_addr_width;
val = rz_dmac_ds_to_val_mapping(config->dst_addr_width);
if (val == CHCFG_DS_INVALID)
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] dmaengine: sh: rz-dmac: Remove unused rz_dmac_chan.*_word_size
2023-03-27 9:48 [PATCH] dmaengine: sh: rz-dmac: Remove unused rz_dmac_chan.*_word_size Geert Uytterhoeven
@ 2023-03-27 9:53 ` Biju Das
2023-03-31 12:00 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Biju Das @ 2023-03-27 9:53 UTC (permalink / raw)
To: Geert Uytterhoeven, Vinod Koul; +Cc: dmaengine, linux-renesas-soc
Hi Geert,
Thanks for the patch.
> -----Original Message-----
> From: Geert Uytterhoeven <geert+renesas@glider.be>
> Sent: Monday, March 27, 2023 10:49 AM
> To: Vinod Koul <vkoul@kernel.org>; Biju Das <biju.das.jz@bp.renesas.com>
> Cc: dmaengine@vger.kernel.org; linux-renesas-soc@vger.kernel.org; Geert
> Uytterhoeven <geert+renesas@glider.be>
> Subject: [PATCH] dmaengine: sh: rz-dmac: Remove unused
> rz_dmac_chan.*_word_size
>
> The src_word_size and dst_word_size members of the rz_dmac_chan structure
> were never used, so they can be removed.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Cheers,
Biju
> ---
> drivers/dma/sh/rz-dmac.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index
> 6b62e01ba658ac13..9479f29692d3e3d7 100644
> --- a/drivers/dma/sh/rz-dmac.c
> +++ b/drivers/dma/sh/rz-dmac.c
> @@ -67,8 +67,6 @@ struct rz_dmac_chan {
> struct rz_dmac_desc *desc;
> int descs_allocated;
>
> - enum dma_slave_buswidth src_word_size;
> - enum dma_slave_buswidth dst_word_size;
> dma_addr_t src_per_address;
> dma_addr_t dst_per_address;
>
> @@ -603,9 +601,7 @@ static int rz_dmac_config(struct dma_chan *chan,
> u32 val;
>
> channel->src_per_address = config->src_addr;
> - channel->src_word_size = config->src_addr_width;
> channel->dst_per_address = config->dst_addr;
> - channel->dst_word_size = config->dst_addr_width;
>
> val = rz_dmac_ds_to_val_mapping(config->dst_addr_width);
> if (val == CHCFG_DS_INVALID)
> --
> 2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: sh: rz-dmac: Remove unused rz_dmac_chan.*_word_size
2023-03-27 9:48 [PATCH] dmaengine: sh: rz-dmac: Remove unused rz_dmac_chan.*_word_size Geert Uytterhoeven
2023-03-27 9:53 ` Biju Das
@ 2023-03-31 12:00 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-03-31 12:00 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Biju Das, dmaengine, linux-renesas-soc
On 27-03-23, 11:48, Geert Uytterhoeven wrote:
> The src_word_size and dst_word_size members of the rz_dmac_chan
> structure were never used, so they can be removed.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-31 12:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-27 9:48 [PATCH] dmaengine: sh: rz-dmac: Remove unused rz_dmac_chan.*_word_size Geert Uytterhoeven
2023-03-27 9:53 ` Biju Das
2023-03-31 12:00 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).