From: Jon Hunter <jonathanh@nvidia.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
<dmaengine@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
Sameer Pujar <spujar@nvidia.com>
Subject: Re: [RESEND PATCH] dmaengine: tegra210-adma: Don't program FIFO threshold
Date: Wed, 10 Jul 2019 10:11:54 +0100 [thread overview]
Message-ID: <ac13d007-4b42-c3af-70db-de06703eb154@nvidia.com> (raw)
In-Reply-To: <20190705130531.GE2911@vkoul-mobl>
On 05/07/2019 14:05, Vinod Koul wrote:
> On 05-07-19, 10:15, Jon Hunter wrote:
>> From: Jonathan Hunter <jonathanh@nvidia.com>
>>
>> The Tegra210 ADMA supports two modes for transferring data to a FIFO
>> which are ...
>>
>> 1. Transfer data to/from the FIFO as soon as a single burst can be
>> transferred.
>> 2. Transfer data to/from the FIFO based upon FIFO thresholds, where
>> the FIFO threshold is specified in terms on multiple bursts.
>>
>> Currently, the ADMA driver programs the FIFO threshold values in the
>> FIFO_CTRL register, but never enables the transfer mode that uses
>> these threshold values. Given that these have never been used so far,
>> simplify the ADMA driver by removing the programming of these threshold
>> values.
>>
>> Signed-off-by: Jonathan Hunter <jonathanh@nvidia.com>
>> Acked-by: Thierry Reding <treding@nvidia.com>
>> ---
>>
>> Resending the patch rebased on top next-20190704. I have added Thierry's
>> ACK as well.
>
> Thanks but this fails as well. I had applied few tegra patches so I
> suspect that is causing issues now. It would have been nice to have them
> in series.
>
> Would you rebase on
> git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git next (yeah
> this is different location, i dont see to push to infradead today)
So this patch should apply cleanly on top of the fixes series I sent for
v5.2 [0] which you merged and is now in mainline. So if I rebase on the
above, I wondering if it is then going to conflict with mainline? Looks
like the above branch is based upon v5.2-rc1 and hence the conflict.
Cheers
Jon
[0] https://patchwork.kernel.org/cover/10946849/
--
nvpublic
next prev parent reply other threads:[~2019-07-10 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 9:15 [RESEND PATCH] dmaengine: tegra210-adma: Don't program FIFO threshold Jon Hunter
2019-07-05 9:25 ` Sameer Pujar
2019-07-05 13:05 ` Vinod Koul
2019-07-10 9:11 ` Jon Hunter [this message]
2019-07-25 12:56 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac13d007-4b42-c3af-70db-de06703eb154@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=dmaengine@vger.kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).