* question about drivers/dma/mediatek/mtk-cqdma.c
@ 2020-05-08 21:57 Julia Lawall
0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2020-05-08 21:57 UTC (permalink / raw)
To: sean.wang, vkoul, matthias.bgg; +Cc: dmaengine, linux-mediatek, Nic Volanschi
Hello,
The function mtk_cqdma_find_active_desc contains the following code:
struct virt_dma_desc *vd;
unsigned long flags;
spin_lock_irqsave(&cvc->pc->lock, flags);
list_for_each_entry(vd, &cvc->pc->queue, node)
if (vd->tx.cookie == cookie) {
spin_unlock_irqrestore(&cvc->pc->lock, flags);
return vd;
}
That is, from a &cvc->pc->queue there is an iteration over elements of
type virt_dma_desc. But other uses of &cvc->pc->queue, such as in
mtk_cqdma_is_vchan_active, seem to indicate that the elements of this list
have type mtk_cqdma_vdesc. It is not clear to me how the body of the loop
should be updated to account for this.
thanks,
julia
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-05-08 21:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 21:57 question about drivers/dma/mediatek/mtk-cqdma.c Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).