From: Lokesh Vutla <lokeshvutla@ti.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>, <vkoul@kernel.org>,
<robh+dt@kernel.org>, <nm@ti.com>, <ssantosh@kernel.org>
Cc: <dan.j.williams@intel.com>, <dmaengine@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<grygorii.strashko@ti.com>, <t-kristo@ti.com>, <tony@atomide.com>,
<j-keerthy@ti.com>
Subject: Re: [PATCH v3 02/14] soc: ti: k3: add navss ringacc driver
Date: Tue, 29 Oct 2019 14:22:14 +0530 [thread overview]
Message-ID: <b5f47303-b6d2-190b-d38c-d3557a93b111@ti.com> (raw)
In-Reply-To: <20191001061704.2399-3-peter.ujfalusi@ti.com>
Hi Grygorii,
[...snip..]
> +
> +static int k3_ringacc_ring_access_io(struct k3_ring *ring, void *elem,
> + enum k3_ringacc_access_mode access_mode)
> +{
> + void __iomem *ptr;
> +
> + switch (access_mode) {
> + case K3_RINGACC_ACCESS_MODE_PUSH_HEAD:
> + case K3_RINGACC_ACCESS_MODE_POP_HEAD:
> + ptr = (void __iomem *)&ring->fifos->head_data;
> + break;
> + case K3_RINGACC_ACCESS_MODE_PUSH_TAIL:
> + case K3_RINGACC_ACCESS_MODE_POP_TAIL:
> + ptr = (void __iomem *)&ring->fifos->tail_data;
> + break;
> + default:
> + return -EINVAL;
> + }
> +
> + ptr += k3_ringacc_ring_get_fifo_pos(ring);
> +
> + switch (access_mode) {
> + case K3_RINGACC_ACCESS_MODE_POP_HEAD:
> + case K3_RINGACC_ACCESS_MODE_POP_TAIL:
> + dev_dbg(ring->parent->dev,
> + "memcpy_fromio(x): --> ptr(%p), mode:%d\n", ptr,
> + access_mode);
> + memcpy_fromio(elem, ptr, (4 << ring->elm_size));
Does this work for any elem_size < 64 or any element size not aligned with 64?
IIUC, in message mode, ring element should be inserted in a single burst write
and there is no doorbell facility. If the above conditions are not met, we are
supposed to use proxy.
In this driver, I don't see any restrictions on the ring element size for
message mode and directly written to io. Am I missing something?
Thanks and regards,
Lokesh
> + ring->occ--;
> + break;
> + case K3_RINGACC_ACCESS_MODE_PUSH_TAIL:
> + case K3_RINGACC_ACCESS_MODE_PUSH_HEAD:
> + dev_dbg(ring->parent->dev,
> + "memcpy_toio(x): --> ptr(%p), mode:%d\n", ptr,
> + access_mode);
> + memcpy_toio(ptr, elem, (4 << ring->elm_size));
> + ring->free--;
> + break;
> + default:
> + return -EINVAL;
> + }
> +
> + dev_dbg(ring->parent->dev, "free%d index%d occ%d index%d\n", ring->free,
> + ring->windex, ring->occ, ring->rindex);
> + return 0;
> +}
> +
> +static int k3_ringacc_ring_push_head_io(struct k3_ring *ring, void *elem)
> +{
> + return k3_ringacc_ring_access_io(ring, elem,
> + K3_RINGACC_ACCESS_MODE_PUSH_HEAD);
> +}
> +
> +static int k3_ringacc_ring_push_io(struct k3_ring *ring, void *elem)
> +{
> + return k3_ringacc_ring_access_io(ring, elem,
> + K3_RINGACC_ACCESS_MODE_PUSH_TAIL);
> +}
> +
> +static int k3_ringacc_ring_pop_io(struct k3_ring *ring, void *elem)
> +{
> + return k3_ringacc_ring_access_io(ring, elem,
> + K3_RINGACC_ACCESS_MODE_POP_HEAD);
> +}
> +
> +static int k3_ringacc_ring_pop_tail_io(struct k3_ring *ring, void *elem)
> +{
> + return k3_ringacc_ring_access_io(ring, elem,
> + K3_RINGACC_ACCESS_MODE_POP_HEAD);
> +}
> +
next prev parent reply other threads:[~2019-10-29 8:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 6:16 [PATCH v3 00/14] dmaengine/soc: Add Texas Instruments UDMA support Peter Ujfalusi
2019-10-01 6:16 ` [PATCH v3 01/14] bindings: soc: ti: add documentation for k3 ringacc Peter Ujfalusi
2019-10-01 6:16 ` [PATCH v3 02/14] soc: ti: k3: add navss ringacc driver Peter Ujfalusi
2019-10-09 7:14 ` Tero Kristo
2019-10-09 13:27 ` Lokesh Vutla
2019-10-25 9:30 ` Peter Ujfalusi
2019-10-29 8:52 ` Lokesh Vutla [this message]
2019-10-30 13:10 ` Grygorii Strashko
2019-10-01 6:16 ` [PATCH v3 03/14] dmaengine: doc: Add sections for per descriptor metadata support Peter Ujfalusi
2019-10-09 7:30 ` Tero Kristo
2019-10-01 6:16 ` [PATCH v3 04/14] dmaengine: Add metadata_ops for dma_async_tx_descriptor Peter Ujfalusi
2019-10-09 7:37 ` Tero Kristo
2019-10-01 6:16 ` [PATCH v3 05/14] dmaengine: Add support for reporting DMA cached data amount Peter Ujfalusi
2019-10-09 9:17 ` Tero Kristo
2019-10-01 6:16 ` [PATCH v3 06/14] dmaengine: ti: Add cppi5 header for UDMA Peter Ujfalusi
2019-10-09 9:13 ` Tero Kristo
2019-10-01 6:16 ` [PATCH v3 07/14] dt-bindings: dma: ti: Add document for K3 UDMA Peter Ujfalusi
2019-10-10 17:52 ` Rob Herring
2019-10-11 7:30 ` Peter Ujfalusi
2019-10-15 17:30 ` Peter Ujfalusi
2019-10-17 14:03 ` Rob Herring
2019-10-22 11:46 ` Peter Ujfalusi
2019-10-01 6:16 ` [PATCH v3 08/14] dmaengine: ti: New driver for K3 UDMA - split#1: defines, structs, io func Peter Ujfalusi
2019-10-09 13:40 ` Tero Kristo
2019-10-01 6:16 ` [PATCH v3 09/14] dmaengine: ti: New driver for K3 UDMA - split#2: probe/remove, xlate and filter_fn Peter Ujfalusi
2019-10-03 8:35 ` Peter Ujfalusi
2019-10-01 6:17 ` [PATCH v3 10/14] dmaengine: ti: New driver for K3 UDMA - split#3: alloc/free chan_resources Peter Ujfalusi
2019-10-01 6:17 ` [PATCH v3 11/14] dmaengine: ti: New driver for K3 UDMA - split#4: dma_device callbacks 1 Peter Ujfalusi
2019-10-01 6:17 ` [PATCH v3 12/14] dmaengine: ti: New driver for K3 UDMA - split#5: dma_device callbacks 2 Peter Ujfalusi
2019-10-01 6:17 ` [PATCH v3 13/14] dmaengine: ti: New driver for K3 UDMA - split#6: Kconfig and Makefile Peter Ujfalusi
2019-10-01 6:17 ` [PATCH v3 14/14] dmaengine: ti: k3-udma: Add glue layer for non DMAengine users Peter Ujfalusi
2019-10-04 16:35 ` [PATCH v3 00/14] dmaengine/soc: Add Texas Instruments UDMA support santosh.shilimkar
2019-10-08 10:09 ` Peter Ujfalusi
2019-10-09 16:02 ` santosh.shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5f47303-b6d2-190b-d38c-d3557a93b111@ti.com \
--to=lokeshvutla@ti.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).