First patch is to make mux_configure32() static to avoid sparse warning, the second patch is to chage alignment of two functions. v2: change subject from "drivers: dma: Fix sparse warning for mux_configure32" to "drivers: dma: make mux_configure32 static", and cleanup the log. And add one patch to change alignment of two functions. Mao Wenan (2): drivers: dma: make mux_configure32 static drivers: dma: change alignment of mux_configure32 and fsl_edma_chan_mux drivers/dma/fsl-edma-common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.20.1
There is one sparse warning in drivers/dma/fsl-edma-common.c: drivers/dma/fsl-edma-common.c:93:6: warning: symbol 'mux_configure32' was not declared. Should it be static? Fix it by setting mux_configure32() as static. Fixes: 232a7f18cf8ec ("dmaengine: fsl-edma: add i.mx7ulp edma2 version support") Signed-off-by: Mao Wenan <maowenan@huawei.com> --- drivers/dma/fsl-edma-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c index 6d6d8a4e8e38..264c448de409 100644 --- a/drivers/dma/fsl-edma-common.c +++ b/drivers/dma/fsl-edma-common.c @@ -90,7 +90,7 @@ static void mux_configure8(struct fsl_edma_chan *fsl_chan, void __iomem *addr, iowrite8(val8, addr + off); } -void mux_configure32(struct fsl_edma_chan *fsl_chan, void __iomem *addr, +static void mux_configure32(struct fsl_edma_chan *fsl_chan, void __iomem *addr, u32 off, u32 slot, bool enable) { u32 val; -- 2.20.1
The alignment of mux_configure32() and fsl_edma_chan_mux() need to be adjusted, it must start precisely at the first column after the openning parenthesis of the first line. Fixes: 9d831528a656 ("dmaengine: fsl-edma: extract common fsl-edma code (no changes in behavior intended)") Signed-off-by: Mao Wenan <maowenan@huawei.com> --- drivers/dma/fsl-edma-common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c index 264c448de409..b1a7ca91701a 100644 --- a/drivers/dma/fsl-edma-common.c +++ b/drivers/dma/fsl-edma-common.c @@ -91,7 +91,7 @@ static void mux_configure8(struct fsl_edma_chan *fsl_chan, void __iomem *addr, } static void mux_configure32(struct fsl_edma_chan *fsl_chan, void __iomem *addr, - u32 off, u32 slot, bool enable) + u32 off, u32 slot, bool enable) { u32 val; @@ -104,7 +104,7 @@ static void mux_configure32(struct fsl_edma_chan *fsl_chan, void __iomem *addr, } void fsl_edma_chan_mux(struct fsl_edma_chan *fsl_chan, - unsigned int slot, bool enable) + unsigned int slot, bool enable) { u32 ch = fsl_chan->vchan.chan.chan_id; void __iomem *muxaddr; -- 2.20.1
On 14-08-19, 15:21, Mao Wenan wrote: > First patch is to make mux_configure32() static to avoid sparse warning, > the second patch is to chage alignment of two functions. The subsystem name is "dmaengine" please use that in future, I have fixed that and applied > v2: change subject from "drivers: dma: Fix sparse warning for mux_configure32" > to "drivers: dma: make mux_configure32 static", and cleanup the log. And add > one patch to change alignment of two functions. > > Mao Wenan (2): > drivers: dma: make mux_configure32 static > drivers: dma: change alignment of mux_configure32 and > fsl_edma_chan_mux > > drivers/dma/fsl-edma-common.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > -- > 2.20.1 -- ~Vinod
On 2019/8/20 19:41, Vinod Koul wrote: > On 14-08-19, 15:21, Mao Wenan wrote: >> First patch is to make mux_configure32() static to avoid sparse warning, >> the second patch is to chage alignment of two functions. > > The subsystem name is "dmaengine" please use that in future, I have > fixed that and applied Okay, thanks. > >> v2: change subject from "drivers: dma: Fix sparse warning for mux_configure32" >> to "drivers: dma: make mux_configure32 static", and cleanup the log. And add >> one patch to change alignment of two functions. >> >> Mao Wenan (2): >> drivers: dma: make mux_configure32 static >> drivers: dma: change alignment of mux_configure32 and >> fsl_edma_chan_mux >> >> drivers/dma/fsl-edma-common.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> -- >> 2.20.1 >