dmaengine Archive on lore.kernel.org
 help / color / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: bp@alien8.de, dan.j.williams@intel.com, tony.luck@intel.com,
	ashok.raj@intel.com, kevin.tian@intel.com, fenghua.yu@intel.com,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 0/5] Add shared workqueue support for idxd driver
Date: Wed, 7 Oct 2020 09:50:17 -0700
Message-ID: <c25b11ce-4588-6663-c9d6-b1177c627c98@intel.com> (raw)
In-Reply-To: <20201007070132.GT2968@vkoul-mobl>



On 10/7/2020 12:01 AM, Vinod Koul wrote:
> On 05-10-20, 08:11, Dave Jiang wrote:
> 
>> == Background ==
>> A typical DMA device requires the driver to translate application buffers to hardware addresses,
>> and a kernel-user transition to notify the hardware of new work. Shared Virtual Addressing (SVA)
>> allows the processor and device to use the same virtual addresses without requiring software to
>> translate between the address spaces. ENQCMD is a new instruction on Intel Platforms that allows
>> user applications to directly notify hardware of new work, much like how doorbells are used in
>> some hardware, but it carries a payload along with it. ENQCMDS is the supervisor version (ring0)
>> of ENQCMD.
>>
>> == ENQCMDS ==
>> Introduce enqcmds(), a helper funciton that copies an input payload to a 64B aligned
>> destination and confirms whether the payload was accepted by the device or not.
>> enqcmds() wraps the new ENQCMDS CPU instruction. The ENQCMDS is a ring 0 CPU instruction that
>> performs similar to the ENQCMD instruction. Descriptor submission must use ENQCMD(S) for shared
>> workqueues (swq) on an Intel DSA device.
>>
>> == Shared WQ support ==
>> Introduce shared workqueue (swq) support for the idxd driver. The current idxd driver contains
>> dedicated workqueue (dwq) support only. A dwq accepts descriptors from a MOVDIR64B instruction.
>> MOVDIR64B is a posted instruction on the PCIe bus, it does not wait for any response from the
>> device. If the wq is full, submitted descriptors are dropped. A swq utilizes the ENQCMDS in
>> ring 0, which is a non-posted instruction. The zero flag would be set to 1 if the device rejects
>> the descriptor or if the wq is full. A swq can be shared between multiple users
>> (kernel or userspace) due to not having to keep track of the wq full condition for submission.
>> A swq requires PASID and can only run with SVA support.
>>
>> == IDXD SVA support ==
>> Add utilization of PASID to support Shared Virtual Addressing (SVA). With PASID support,
>> the descriptors can be programmed with host virtual address (HVA) rather than IOVA.
>> The hardware will work with the IOMMU in fulfilling page requests. With SVA support,
>> a user app using the char device interface can now submit descriptors without having to pin the
>> virtual memory range it wants to DMA in its own address space.
>>
>> The series does not add SVA support for the dmaengine subsystem. That support is coming at a
>> later time.
> 
> Applied, thanks
> 

Thanks Vinod!

      parent reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-05 15:11 Dave Jiang
2020-10-05 15:11 ` [PATCH v7 1/5] x86/asm: Carve out a generic movdir64b() helper for general usage Dave Jiang
2020-10-05 15:11 ` [PATCH v7 2/5] x86/asm: Add an enqcmds() wrapper for the ENQCMDS instruction Dave Jiang
2020-10-05 15:11 ` [PATCH v7 3/5] dmaengine: idxd: Add shared workqueue support Dave Jiang
2020-10-05 15:11 ` [PATCH v7 4/5] dmaengine: idxd: Clean up descriptors with fault error Dave Jiang
2020-10-05 15:11 ` [PATCH v7 5/5] dmaengine: idxd: Add ABI documentation for shared wq Dave Jiang
2020-10-07  7:01 ` [PATCH v7 0/5] Add shared workqueue support for idxd driver Vinod Koul
2020-10-07  8:48   ` Borislav Petkov
2020-10-07  9:53     ` Vinod Koul
2020-10-07 10:04       ` Borislav Petkov
2020-10-07 14:57         ` Vinod Koul
2020-10-07 16:16           ` Borislav Petkov
2020-10-07 16:50   ` Dave Jiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c25b11ce-4588-6663-c9d6-b1177c627c98@intel.com \
    --to=dave.jiang@intel.com \
    --cc=ashok.raj@intel.com \
    --cc=bp@alien8.de \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=fenghua.yu@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git