From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "vkoul@kernel.org" <vkoul@kernel.org>
Cc: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
Subject: Re: [PATCH 4/4] dmaengine: axi-dmac: add regmap support
Date: Fri, 14 Jun 2019 08:14:34 +0000 [thread overview]
Message-ID: <d39019156021aabb2bf8ddc822b6f38b70e46bb5.camel@analog.com> (raw)
In-Reply-To: <20190614055212.GC2962@vkoul-mobl>
On Fri, 2019-06-14 at 11:22 +0530, Vinod Koul wrote:
> [External]
>
>
> On 06-06-19, 13:45, Alexandru Ardelean wrote:
>
> > +static bool axi_dmac_regmap_rdwr(struct device *dev, unsigned int reg)
> > +{
> > + switch (reg) {
> > + case AXI_DMAC_REG_IRQ_MASK:
> > + case AXI_DMAC_REG_IRQ_SOURCE:
> > + case AXI_DMAC_REG_IRQ_PENDING:
> > + case AXI_DMAC_REG_CTRL:
> > + case AXI_DMAC_REG_TRANSFER_ID:
> > + case AXI_DMAC_REG_START_TRANSFER:
> > + case AXI_DMAC_REG_FLAGS:
> > + case AXI_DMAC_REG_DEST_ADDRESS:
> > + case AXI_DMAC_REG_SRC_ADDRESS:
> > + case AXI_DMAC_REG_X_LENGTH:
> > + case AXI_DMAC_REG_Y_LENGTH:
> > + case AXI_DMAC_REG_DEST_STRIDE:
> > + case AXI_DMAC_REG_SRC_STRIDE:
> > + case AXI_DMAC_REG_TRANSFER_DONE:
> > + case AXI_DMAC_REG_ACTIVE_TRANSFER_ID :
>
> Space before : ...?
oops
sorry about that
thanks for fixing
Alex
>
> --
> ~Vinod
next prev parent reply other threads:[~2019-06-14 8:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 10:45 [PATCH 1/4] dmaengine: virt-dma: store result on dma descriptor Alexandru Ardelean
2019-06-06 10:45 ` [PATCH 2/4] dmaengine: axi-dmac: populate residue info for completed xfers Alexandru Ardelean
2019-06-06 10:45 ` [PATCH 3/4] dmaengine: axi-dmac: terminate early DMA transfers after a partial one Alexandru Ardelean
2019-06-06 10:45 ` [PATCH 4/4] dmaengine: axi-dmac: add regmap support Alexandru Ardelean
2019-06-14 5:52 ` Vinod Koul
2019-06-14 8:14 ` Ardelean, Alexandru [this message]
2019-06-14 5:53 ` [PATCH 1/4] dmaengine: virt-dma: store result on dma descriptor Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d39019156021aabb2bf8ddc822b6f38b70e46bb5.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=dmaengine@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).