From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Colin King <colin.king@canonical.com>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vkoul@kernel.org>, <dmaengine@vger.kernel.org>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] dmaengine: ti: edma: fix null dereference because of a typo in pointer name
Date: Thu, 27 Feb 2020 09:33:26 +0200 [thread overview]
Message-ID: <d7b23176-2e0c-e771-74a7-432123f74dcb@ti.com> (raw)
In-Reply-To: <20200226185921.351693-1-colin.king@canonical.com>
Colin,
On 26/02/2020 20.59, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently there is a dereference of the null pointer m_ddev. This appears
> to be a typo on the pointer, I believe s_ddev should be used instead.
> Fix this by using the correct pointer.
Thank you for catching it!
This is a mostly unused case to keep supporting the legacy EDMA binding
which should be gone by now for some time, but there might be boards out
there still booting in that way...
I have copied the dma_cap_set() line from the testable code path.
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Addresses-Coverity: ("Explicit null dereferenced")
> Fixes: eb0249d50153 ("dmaengine: ti: edma: Support for interleaved mem to mem transfer")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/dma/ti/edma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
> index 2b1fdd438e7f..c4a5c170c1f9 100644
> --- a/drivers/dma/ti/edma.c
> +++ b/drivers/dma/ti/edma.c
> @@ -1992,7 +1992,7 @@ static void edma_dma_init(struct edma_cc *ecc, bool legacy_mode)
> "Legacy memcpy is enabled, things might not work\n");
>
> dma_cap_set(DMA_MEMCPY, s_ddev->cap_mask);
> - dma_cap_set(DMA_INTERLEAVE, m_ddev->cap_mask);
> + dma_cap_set(DMA_INTERLEAVE, s_ddev->cap_mask);
> s_ddev->device_prep_dma_memcpy = edma_prep_dma_memcpy;
> s_ddev->device_prep_interleaved_dma = edma_prep_dma_interleaved;
> s_ddev->directions = BIT(DMA_MEM_TO_MEM);
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-02-27 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 18:59 [PATCH][next] dmaengine: ti: edma: fix null dereference because of a typo in pointer name Colin King
2020-02-27 7:33 ` Peter Ujfalusi [this message]
2020-03-02 10:09 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7b23176-2e0c-e771-74a7-432123f74dcb@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=colin.king@canonical.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).