From: Baolin Wang <baolin.wang@linaro.org>
To: dan.j.williams@intel.com, vkoul@kernel.org
Cc: eric.long@unisoc.com, orsonzhai@gmail.com, zhang.lyra@gmail.com,
vincent.guittot@linaro.org, baolin.wang@linaro.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/6] dmaengine: sprd: Fix the incorrect start for 2-stage destination channels
Date: Mon, 6 May 2019 15:28:30 +0800 [thread overview]
Message-ID: <dc1c179c93ac1cc2d6f19d0675f3241900813900.1557127239.git.baolin.wang@linaro.org> (raw)
In-Reply-To: <cover.1557127239.git.baolin.wang@linaro.org>
In-Reply-To: <cover.1557127239.git.baolin.wang@linaro.org>
From: Eric Long <eric.long@unisoc.com>
The 2-stage destination channel will be triggered by source channel
automatically, which means we should not trigger it by software request.
Signed-off-by: Eric Long <eric.long@unisoc.com>
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
---
drivers/dma/sprd-dma.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
index 431e289..0f92e60 100644
--- a/drivers/dma/sprd-dma.c
+++ b/drivers/dma/sprd-dma.c
@@ -510,7 +510,9 @@ static void sprd_dma_start(struct sprd_dma_chn *schan)
sprd_dma_set_uid(schan);
sprd_dma_enable_chn(schan);
- if (schan->dev_id == SPRD_DMA_SOFTWARE_UID)
+ if (schan->dev_id == SPRD_DMA_SOFTWARE_UID &&
+ schan->chn_mode != SPRD_DMA_DST_CHN0 &&
+ schan->chn_mode != SPRD_DMA_DST_CHN1)
sprd_dma_soft_request(schan);
}
--
1.7.9.5
next prev parent reply other threads:[~2019-05-06 7:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 7:28 [PATCH v2 0/6] Fix some bugs and add new feature for Spreadtrum DMA engine Baolin Wang
2019-05-06 7:28 ` [PATCH v2 1/6] dmaengine: sprd: Fix the possible crash when getting descriptor status Baolin Wang
2019-05-06 7:28 ` [PATCH v2 2/6] dmaengine: sprd: Add validation of current descriptor in irq handler Baolin Wang
2019-05-06 7:28 ` Baolin Wang [this message]
2019-05-06 7:28 ` [PATCH v2 4/6] dmaengine: sprd: Fix block length overflow Baolin Wang
2019-05-06 7:28 ` [PATCH v2 5/6] dmaengine: sprd: Fix the right place to configure 2-stage transfer Baolin Wang
2019-05-06 7:28 ` [PATCH v2 6/6] dmaengine: sprd: Add interrupt support for " Baolin Wang
2019-05-21 13:54 ` [PATCH v2 0/6] Fix some bugs and add new feature for Spreadtrum DMA engine Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc1c179c93ac1cc2d6f19d0675f3241900813900.1557127239.git.baolin.wang@linaro.org \
--to=baolin.wang@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=eric.long@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=vkoul@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).