dmaengine Archive on lore.kernel.org
 help / color / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Vinod Koul <vkoul@kernel.org>, dmaengine@vger.kernel.org
Cc: "Allen Pais" <allen.lkml@gmail.com>,
	"Romain Perier" <romain.perier@gmail.com>,
	linux-kernel@vger.kernel.org,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Rafał Hibner" <rafal.hibner@secom.com.pl>,
	"Radhey Shyam Pandey" <radhey.shyam.pandey@xilinx.com>,
	"Appana Durga Kedareswara rao" <appana.durga.rao@xilinx.com>
Subject: Re: [PATCH 3/5] dmaengine: xilinx_dma: fix kernel-doc style for tasklet
Date: Wed, 7 Oct 2020 10:36:47 +0200
Message-ID: <e7877311-d880-0215-b77b-82b7c62b05f8@xilinx.com> (raw)
In-Reply-To: <20201007083113.567559-4-vkoul@kernel.org>



On 07. 10. 20 10:31, Vinod Koul wrote:
> Commit f19a11d40a78 ("dmaengine: xilinx: convert tasklets to use new
> tasklet_setup() API") updated driver to use new tasklet_setup() API but
> missed to update the documentation for the tasklet function.
> 
> Fixes: f19a11d40a78 ("dmaengine: xilinx: convert tasklets to use new tasklet_setup() API")
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>  drivers/dma/xilinx/xilinx_dma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index a9eb85ee6daf..ecff35402860 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -1044,7 +1044,7 @@ static void xilinx_dma_chan_desc_cleanup(struct xilinx_dma_chan *chan)
>  
>  /**
>   * xilinx_dma_do_tasklet - Schedule completion tasklet
> - * @data: Pointer to the Xilinx DMA channel structure
> + * @t: Pointer to the Xilinx DMA channel structure
>   */
>  static void xilinx_dma_do_tasklet(struct tasklet_struct *t)
>  {
> 

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

  reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07  8:31 [PATCH 0/5] Fix warning in dmaengine subsystem Vinod Koul
2020-10-07  8:31 ` [PATCH 1/5] dmaengine: altera-msgdma: fix kernel-doc style for tasklet Vinod Koul
2020-10-07  8:31 ` [PATCH 2/5] dmaengine: qcom: bam_dma: " Vinod Koul
2020-10-07  8:31 ` [PATCH 3/5] dmaengine: xilinx_dma: " Vinod Koul
2020-10-07  8:36   ` Michal Simek [this message]
2020-10-07  8:31 ` [PATCH 4/5] dmaengine: zynqmp_dma: " Vinod Koul
2020-10-07  8:36   ` Michal Simek
2020-10-07  8:31 ` [PATCH 5/5] dmaengine: owl-dma: fix kernel-doc style for enum Vinod Koul
2020-10-08 14:04   ` Manivannan Sadhasivam
2020-10-09  4:18     ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7877311-d880-0215-b77b-82b7c62b05f8@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=allen.lkml@gmail.com \
    --cc=appana.durga.rao@xilinx.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=radhey.shyam.pandey@xilinx.com \
    --cc=rafal.hibner@secom.com.pl \
    --cc=romain.perier@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git