dmaengine Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] dmaengine: ti: k3-udma: Use PTR_ERR_OR_ZERO() to simplify code
@ 2020-05-06  9:25 Samuel Zou
  2020-05-13 14:52 ` Vinod Koul
  2020-05-14  8:33 ` Peter Ujfalusi
  0 siblings, 2 replies; 4+ messages in thread
From: Samuel Zou @ 2020-05-06  9:25 UTC (permalink / raw)
  To: dan.j.williams, vkoul; +Cc: dmaengine, linux-kernel, Samuel Zou

Fixes coccicheck warnings:

drivers/dma/ti/k3-udma.c:1294:1-3: WARNING: PTR_ERR_OR_ZERO can be used
drivers/dma/ti/k3-udma.c:1311:1-3: WARNING: PTR_ERR_OR_ZERO can be used
drivers/dma/ti/k3-udma.c:1376:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Samuel Zou <zou_wei@huawei.com>
---
 drivers/dma/ti/k3-udma.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
index 0a04174..f5775ca 100644
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -1291,10 +1291,8 @@ static int udma_get_tchan(struct udma_chan *uc)
 	}
 
 	uc->tchan = __udma_reserve_tchan(ud, uc->config.channel_tpl, -1);
-	if (IS_ERR(uc->tchan))
-		return PTR_ERR(uc->tchan);
 
-	return 0;
+	return PTR_ERR_OR_ZERO(uc->tchan);
 }
 
 static int udma_get_rchan(struct udma_chan *uc)
@@ -1308,10 +1306,8 @@ static int udma_get_rchan(struct udma_chan *uc)
 	}
 
 	uc->rchan = __udma_reserve_rchan(ud, uc->config.channel_tpl, -1);
-	if (IS_ERR(uc->rchan))
-		return PTR_ERR(uc->rchan);
 
-	return 0;
+	return PTR_ERR_OR_ZERO(uc->rchan);
 }
 
 static int udma_get_chan_pair(struct udma_chan *uc)
@@ -1373,10 +1369,8 @@ static int udma_get_rflow(struct udma_chan *uc, int flow_id)
 	}
 
 	uc->rflow = __udma_get_rflow(ud, flow_id);
-	if (IS_ERR(uc->rflow))
-		return PTR_ERR(uc->rflow);
 
-	return 0;
+	return PTR_ERR_OR_ZERO(uc->rflow);
 }
 
 static void udma_put_rchan(struct udma_chan *uc)
-- 
2.6.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] dmaengine: ti: k3-udma: Use PTR_ERR_OR_ZERO() to simplify code
  2020-05-06  9:25 [PATCH -next] dmaengine: ti: k3-udma: Use PTR_ERR_OR_ZERO() to simplify code Samuel Zou
@ 2020-05-13 14:52 ` Vinod Koul
  2020-05-14  8:33 ` Peter Ujfalusi
  1 sibling, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2020-05-13 14:52 UTC (permalink / raw)
  To: Samuel Zou; +Cc: dan.j.williams, dmaengine, linux-kernel

On 06-05-20, 17:25, Samuel Zou wrote:
> Fixes coccicheck warnings:
> 
> drivers/dma/ti/k3-udma.c:1294:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> drivers/dma/ti/k3-udma.c:1311:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> drivers/dma/ti/k3-udma.c:1376:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] dmaengine: ti: k3-udma: Use PTR_ERR_OR_ZERO() to simplify code
  2020-05-06  9:25 [PATCH -next] dmaengine: ti: k3-udma: Use PTR_ERR_OR_ZERO() to simplify code Samuel Zou
  2020-05-13 14:52 ` Vinod Koul
@ 2020-05-14  8:33 ` Peter Ujfalusi
  2020-05-14  9:09   ` Samuel Zou
  1 sibling, 1 reply; 4+ messages in thread
From: Peter Ujfalusi @ 2020-05-14  8:33 UTC (permalink / raw)
  To: Samuel Zou, dan.j.williams, vkoul; +Cc: dmaengine, linux-kernel


[-- Attachment #1: Type: text/plain, Size: 1999 bytes --]

Hi Samuel,

On 06/05/2020 12.25, Samuel Zou wrote:
> Fixes coccicheck warnings:
> 
> drivers/dma/ti/k3-udma.c:1294:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> drivers/dma/ti/k3-udma.c:1311:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> drivers/dma/ti/k3-udma.c:1376:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Thanks for the patch, I have missed it as I was not in CC for it.
scripts/get_maintainer.pl would have tipped for a wider recipient list..

> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Samuel Zou <zou_wei@huawei.com>
> ---
>  drivers/dma/ti/k3-udma.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index 0a04174..f5775ca 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -1291,10 +1291,8 @@ static int udma_get_tchan(struct udma_chan *uc)
>  	}
>  
>  	uc->tchan = __udma_reserve_tchan(ud, uc->config.channel_tpl, -1);
> -	if (IS_ERR(uc->tchan))
> -		return PTR_ERR(uc->tchan);
>  
> -	return 0;
> +	return PTR_ERR_OR_ZERO(uc->tchan);
>  }
>  
>  static int udma_get_rchan(struct udma_chan *uc)
> @@ -1308,10 +1306,8 @@ static int udma_get_rchan(struct udma_chan *uc)
>  	}
>  
>  	uc->rchan = __udma_reserve_rchan(ud, uc->config.channel_tpl, -1);
> -	if (IS_ERR(uc->rchan))
> -		return PTR_ERR(uc->rchan);
>  
> -	return 0;
> +	return PTR_ERR_OR_ZERO(uc->rchan);
>  }
>  
>  static int udma_get_chan_pair(struct udma_chan *uc)
> @@ -1373,10 +1369,8 @@ static int udma_get_rflow(struct udma_chan *uc, int flow_id)
>  	}
>  
>  	uc->rflow = __udma_get_rflow(ud, flow_id);
> -	if (IS_ERR(uc->rflow))
> -		return PTR_ERR(uc->rflow);
>  
> -	return 0;
> +	return PTR_ERR_OR_ZERO(uc->rflow);
>  }
>  
>  static void udma_put_rchan(struct udma_chan *uc)
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 1783 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] dmaengine: ti: k3-udma: Use PTR_ERR_OR_ZERO() to simplify code
  2020-05-14  8:33 ` Peter Ujfalusi
@ 2020-05-14  9:09   ` Samuel Zou
  0 siblings, 0 replies; 4+ messages in thread
From: Samuel Zou @ 2020-05-14  9:09 UTC (permalink / raw)
  To: Peter Ujfalusi, dan.j.williams, vkoul; +Cc: dmaengine, linux-kernel

Hi Peter,

I'm sorry for my mistake.
Thanks for your comments and suggestions.

On 2020/5/14 16:33, Peter Ujfalusi wrote:
> Hi Samuel,
> 
> On 06/05/2020 12.25, Samuel Zou wrote:
>> Fixes coccicheck warnings:
>>
>> drivers/dma/ti/k3-udma.c:1294:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>> drivers/dma/ti/k3-udma.c:1311:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>> drivers/dma/ti/k3-udma.c:1376:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> Thanks for the patch, I have missed it as I was not in CC for it.
> scripts/get_maintainer.pl would have tipped for a wider recipient list..
> 
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Samuel Zou <zou_wei@huawei.com>
>> ---
>>   drivers/dma/ti/k3-udma.c | 12 +++---------
>>   1 file changed, 3 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
>> index 0a04174..f5775ca 100644
>> --- a/drivers/dma/ti/k3-udma.c
>> +++ b/drivers/dma/ti/k3-udma.c
>> @@ -1291,10 +1291,8 @@ static int udma_get_tchan(struct udma_chan *uc)
>>   	}
>>   
>>   	uc->tchan = __udma_reserve_tchan(ud, uc->config.channel_tpl, -1);
>> -	if (IS_ERR(uc->tchan))
>> -		return PTR_ERR(uc->tchan);
>>   
>> -	return 0;
>> +	return PTR_ERR_OR_ZERO(uc->tchan);
>>   }
>>   
>>   static int udma_get_rchan(struct udma_chan *uc)
>> @@ -1308,10 +1306,8 @@ static int udma_get_rchan(struct udma_chan *uc)
>>   	}
>>   
>>   	uc->rchan = __udma_reserve_rchan(ud, uc->config.channel_tpl, -1);
>> -	if (IS_ERR(uc->rchan))
>> -		return PTR_ERR(uc->rchan);
>>   
>> -	return 0;
>> +	return PTR_ERR_OR_ZERO(uc->rchan);
>>   }
>>   
>>   static int udma_get_chan_pair(struct udma_chan *uc)
>> @@ -1373,10 +1369,8 @@ static int udma_get_rflow(struct udma_chan *uc, int flow_id)
>>   	}
>>   
>>   	uc->rflow = __udma_get_rflow(ud, flow_id);
>> -	if (IS_ERR(uc->rflow))
>> -		return PTR_ERR(uc->rflow);
>>   
>> -	return 0;
>> +	return PTR_ERR_OR_ZERO(uc->rflow);
>>   }
>>   
>>   static void udma_put_rchan(struct udma_chan *uc)
>>
> 
> - Péter
> 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06  9:25 [PATCH -next] dmaengine: ti: k3-udma: Use PTR_ERR_OR_ZERO() to simplify code Samuel Zou
2020-05-13 14:52 ` Vinod Koul
2020-05-14  8:33 ` Peter Ujfalusi
2020-05-14  9:09   ` Samuel Zou

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git