From: Jon Hunter <jonathanh@nvidia.com>
To: Sameer Pujar <spujar@nvidia.com>, <vkoul@kernel.org>,
<dan.j.williams@intel.com>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>
Cc: <thierry.reding@gmail.com>, <ldewangan@nvidia.com>,
<dmaengine@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/6] Add support for Tegra186/Tegra194 and generic fixes
Date: Thu, 2 May 2019 14:36:10 +0100 [thread overview]
Message-ID: <f8486dab-f95b-a4b1-36f2-89b98086d0cb@nvidia.com> (raw)
In-Reply-To: <1556801717-31507-1-git-send-email-spujar@nvidia.com>
On 02/05/2019 13:55, Sameer Pujar wrote:
> Audio DMA(ADMA) interface is a gateway in the AHUB for facilitating DMA
> transfers between memory and all of its clients. Currently the driver
> supports Tegra210 based platforms. This series adds support for Tegra186
> and Tegra194 based platforms and fixes few functional issues.
>
> Patches in the series are classified into three categories,
> 1. Add support for Tegra186 and Tegra194
> 2. Add DMA pause/resume feature
> 3. Fixes common to differernt Tegra generations
>
> Below change log describes the patches in detail.
>
> Change log:
> =====================================
> v1
> ----
> The series can be classified into 3 categories,
> 1. Add support for Tegra186 and Tegra194
> [Patch 1/6] dmaengine: tegra210-adma: prepare for supporting newer
> Tegra chips
> * The support was there only for Tegra210
> * This is a preparation for adding support for newer Tegra chips
> * chip_data is enhanced to support differences between Tegra210 and
> Tegra186/Tegra194
> [Patch 2/6] Documentation: DT: Add compatibility binding for Tegra186
> * New compatibility string is required for driver to work for
> Tegra186 and Tegra194. Hence new compatibility is introduced.
> * Tegra194 can use the same compatibility as Tegra186
> [Patch 3/6] dmaengine: tegra210-adma: add support for Tegra186/
> Tegra194
> * Populates chip specific information for Tegra186
> * There is a difference in the way ADMA CH_CONFIG registers are
> encoded for Tegra210 and Tegra186. Added helper fucntions to
> support different versions of burst size configuration
>
> 2. Add DMA pause/resume feature
> [Patch 4/6] dmaengine: tegra210-adma: add pause/resume support
> * Adds support for ADMA pause/resume, otherwise audio loss was seen
> during continuous pause/resume of audio playback.
>
> 3. Fixes common to differernt Tegra generations
> [Patch 5/6] dmaengine: tegra210-dma: free dma controller in remove()
> * Fixes kernel panic observed during driver reload. DMA controller
> needs to be freed when driver is unloaded
> [Patch 6/6] dmaengine: tegra210-adma: restore channel status
> * Fixes resume across system suspend. If the channel state is not
> restored, the transfers won't resume from the state from where it
> was left during suspend entry. In this case, audio playback did
> not resume properly once system exited from low power state.
>
> ===============================
> Sameer Pujar (6):
> dmaengine: tegra210-adma: prepare for supporting newer Tegra chips
> Documentation: DT: Add compatibility binding for Tegra186
> dmaengine: tegra210-adma: add support for Tegra186/Tegra194
> dmaengine: tegra210-adma: add pause/resume support
> dmaengine: tegra210-dma: free dma controller in remove()
> dmaengine: tegra210-adma: restore channel status
>
> .../bindings/dma/nvidia,tegra210-adma.txt | 4 +-
> drivers/dma/tegra210-adma.c | 232 +++++++++++++++++----
> 2 files changed, 193 insertions(+), 43 deletions(-)
>
Thanks!
For the series ...
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2019-05-02 13:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 12:55 [PATCH 0/6] Add support for Tegra186/Tegra194 and generic fixes Sameer Pujar
2019-05-02 12:55 ` [PATCH 1/6] dmaengine: tegra210-adma: prepare for supporting newer Tegra chips Sameer Pujar
2019-05-02 12:55 ` [PATCH 2/6] Documentation: DT: Add compatibility binding for Tegra186 Sameer Pujar
2019-05-02 12:55 ` [PATCH 3/6] dmaengine: tegra210-adma: add support for Tegra186/Tegra194 Sameer Pujar
2019-05-02 12:55 ` [PATCH 4/6] dmaengine: tegra210-adma: add pause/resume support Sameer Pujar
2019-05-02 12:55 ` [PATCH 5/6] dmaengine: tegra210-dma: free dma controller in remove() Sameer Pujar
2019-05-02 12:55 ` [PATCH 6/6] dmaengine: tegra210-adma: restore channel status Sameer Pujar
2019-05-02 13:36 ` Jon Hunter [this message]
2019-05-04 10:43 ` [PATCH 0/6] Add support for Tegra186/Tegra194 and generic fixes Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8486dab-f95b-a4b1-36f2-89b98086d0cb@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).