From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: YueHaibing <yuehaibing@huawei.com>, <dan.j.williams@intel.com>,
<vkoul@kernel.org>, <arnd@arndb.de>
Cc: <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] dmaengine: ti: edma: remove unused code
Date: Thu, 5 Sep 2019 11:02:33 +0300 [thread overview]
Message-ID: <fb0b8690-e8c7-549c-b966-66d278dbe68a@ti.com> (raw)
In-Reply-To: <20190905060249.23928-1-yuehaibing@huawei.com>
On 05/09/2019 9.02, YueHaibing wrote:
> drivers/dma/ti/edma.c: In function edma_probe:
> drivers/dma/ti/edma.c:2252:11: warning:
> variable off set but not used [-Wunused-but-set-variable]
>
> 'off' is not used now, so remove it.
This reminds me that this whole in EDMA driver xbar handling is mostly
broken...
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/dma/ti/edma.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
> index ba7c4f0..54fd981 100644
> --- a/drivers/dma/ti/edma.c
> +++ b/drivers/dma/ti/edma.c
> @@ -2249,10 +2249,8 @@ static int edma_probe(struct platform_device *pdev)
> {
> struct edma_soc_info *info = pdev->dev.platform_data;
> s8 (*queue_priority_mapping)[2];
> - int i, off;
> const s16 (*rsv_slots)[2];
> - const s16 (*xbar_chans)[2];
> - int irq;
> + int i, irq;
> char *irq_name;
> struct resource *mem;
> struct device_node *node = pdev->dev.of_node;
> @@ -2349,14 +2347,6 @@ static int edma_probe(struct platform_device *pdev)
> edma_write_slot(ecc, i, &dummy_paramset);
> }
>
> - /* Clear the xbar mapped channels in unused list */
> - xbar_chans = info->xbar_chans;
> - if (xbar_chans) {
> - for (i = 0; xbar_chans[i][1] != -1; i++) {
> - off = xbar_chans[i][1];
originally we had
clear_bits(off, 1, ecc->channel_unused);
here, but I have removed it for some reason with
1be5336bc7ba050ee07d352643bf4c01c513553c
> - }
> - }
> -
> irq = platform_get_irq_byname(pdev, "edma3_ccint");
> if (irq < 0 && node)
> irq = irq_of_parse_and_map(node, 0);
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-09-05 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 6:02 [PATCH -next] dmaengine: ti: edma: remove unused code YueHaibing
2019-09-05 8:02 ` Peter Ujfalusi [this message]
2019-09-25 20:27 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb0b8690-e8c7-549c-b966-66d278dbe68a@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).