From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB134C433E0 for ; Tue, 30 Jun 2020 04:23:02 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 8C3DC206CB for ; Tue, 30 Jun 2020 04:23:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C3DC206CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C873D1BEA6; Tue, 30 Jun 2020 06:23:01 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 6DCED1BE90 for ; Tue, 30 Jun 2020 06:22:59 +0200 (CEST) IronPort-SDR: aCghpIAQYKt2D7ifPl6KF990+QfbHF5KtpA4sa3f/eke7Dpe931RIpD2VXFeuwj2/peV53nL9K xbdbPVnG2e+Q== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="126266781" X-IronPort-AV: E=Sophos;i="5.75,296,1589266800"; d="scan'208,217";a="126266781" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 21:22:58 -0700 IronPort-SDR: AN55BRKdbH8j5r5/XJjeWlgHYHH2/NgOt9S2uaJncEavamGlRRPFy/jeWbK8wYThs6DpD6fOmp lFi7EkxLW1bQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,296,1589266800"; d="scan'208,217";a="281092381" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.180]) ([10.67.68.180]) by orsmga006.jf.intel.com with ESMTP; 29 Jun 2020 21:22:56 -0700 To: Chenxu Di , dev@dpdk.org Cc: beilei.xing@intel.com, Yang Qiming References: <20200611060142.75465-1-chenxux.di@intel.com> <20200615021858.13985-1-chenxux.di@intel.com> <20200615021858.13985-2-chenxux.di@intel.com> From: Jeff Guo Message-ID: <012af5fb-d997-0c56-9ca3-9f2e66da3dfd@intel.com> Date: Tue, 30 Jun 2020 12:22:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200615021858.13985-2-chenxux.di@intel.com> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/i40e: add private APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hi, chenxu On 6/15/2020 10:18 AM, Chenxu Di wrote: > The legacy filter API will be superseded by rte_flow. > There are also several small features which can not be > implemented in rte_flow. This patch re-implemented these > features as private API. > Three APIs are added: > rte_pmd_i40e_get_fdir_info. > rte_pmd_i40e_get_fdir_stats. > rte_pmd_i40e_set_gre_key_len. > > Signed-off-by: Chenxu Di > --- > doc/guides/rel_notes/release_20_08.rst | 14 +++++++ > drivers/net/i40e/i40e_ethdev.c | 2 +- > drivers/net/i40e/i40e_ethdev.h | 5 +++ > drivers/net/i40e/i40e_fdir.c | 4 +- > drivers/net/i40e/rte_pmd_i40e.c | 51 +++++++++++++++++++++++ > drivers/net/i40e/rte_pmd_i40e.h | 49 ++++++++++++++++++++++ > drivers/net/i40e/rte_pmd_i40e_version.map | 3 ++ > 7 files changed, 125 insertions(+), 3 deletions(-) > > diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst > index dee4ccbb5..550ad33aa 100644 > --- a/doc/guides/rel_notes/release_20_08.rst > +++ b/doc/guides/rel_notes/release_20_08.rst > @@ -62,6 +62,20 @@ New Features > > * Added new PMD devarg ``reclaim_mem_mode``. > > +* **Updated the Intel i40e driver.** > + > + Updated the Intel i40e driver with new features and improvements, including: > + > + * Re-implemented get_fdir_info and get_fdir_stat in private API. > + * Re-implemented set_gre_key_len in private API. > + * Added support for flow query RSS. > + > +* **Updated the Intel ixgbe driver.** > + > + Updated the Intel ixgbe driver with new features and improvements, including: > + > + * Re-implemented get_fdir_info and get_fdir_stat in private API. > + > Should the ixgbe part of document remove into the next ixgbe patch [2/5]? > Removed Items > ------------- > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index 970a31cb2..674b711d9 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -8787,7 +8787,7 @@ i40e_tunnel_filter_param_check(struct i40e_pf *pf, > > #define I40E_GL_PRS_FVBM_MSK_ENA 0x80000000 > #define I40E_GL_PRS_FVBM(_i) (0x00269760 + ((_i) * 4)) > -static int > +int > i40e_dev_set_gre_key_len(struct i40e_hw *hw, uint8_t len) > { > struct i40e_pf *pf = &((struct i40e_adapter *)hw->back)->pf; > diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h > index e5d0ce53f..192636927 100644 > --- a/drivers/net/i40e/i40e_ethdev.h > +++ b/drivers/net/i40e/i40e_ethdev.h > @@ -1270,6 +1270,11 @@ enum i40e_filter_pctype > uint16_t flow_type); > uint16_t i40e_pctype_to_flowtype(const struct i40e_adapter *adapter, > enum i40e_filter_pctype pctype); > +int i40e_dev_set_gre_key_len(struct i40e_hw *hw, uint8_t len); > +void i40e_fdir_info_get(struct rte_eth_dev *dev, > + struct rte_eth_fdir_info *fdir); > +void i40e_fdir_stats_get(struct rte_eth_dev *dev, > + struct rte_eth_fdir_stats *stat); Please check the alignment. > int i40e_fdir_ctrl_func(struct rte_eth_dev *dev, > enum rte_filter_op filter_op, > void *arg); > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c > index d59399afe..4a778db4c 100644 > --- a/drivers/net/i40e/i40e_fdir.c > +++ b/drivers/net/i40e/i40e_fdir.c > @@ -2169,7 +2169,7 @@ i40e_fdir_info_get_flex_mask(struct i40e_pf *pf, > * @fdir: a pointer to a structure of type *rte_eth_fdir_info* to be filled with > * the flow director information. > */ > -static void > +void > i40e_fdir_info_get(struct rte_eth_dev *dev, struct rte_eth_fdir_info *fdir) > { > struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private); > @@ -2214,7 +2214,7 @@ i40e_fdir_info_get(struct rte_eth_dev *dev, struct rte_eth_fdir_info *fdir) > * @stat: a pointer to a structure of type *rte_eth_fdir_stats* to be filled with > * the flow director statistics. > */ > -static void > +void > i40e_fdir_stats_get(struct rte_eth_dev *dev, struct rte_eth_fdir_stats *stat) > { > struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private); > diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c > index 446e31710..e216e6783 100644 > --- a/drivers/net/i40e/rte_pmd_i40e.c > +++ b/drivers/net/i40e/rte_pmd_i40e.c > @@ -3209,6 +3209,57 @@ rte_pmd_i40e_inset_set(uint16_t port, uint8_t pctype, > return 0; > } > > +int > +rte_pmd_i40e_get_fdir_info(uint16_t port, struct rte_eth_fdir_info *fdir_info) > +{ > + struct rte_eth_dev *dev; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > + > + dev = &rte_eth_devices[port]; > + if (!is_i40e_supported(dev)) > + return -ENOTSUP; > + > + i40e_fdir_info_get(dev, fdir_info); > + > + return 0; > +} > + > +int > +rte_pmd_i40e_get_fdir_stats(uint16_t port, struct rte_eth_fdir_stats *fdir_stat) > +{ > + struct rte_eth_dev *dev; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > + > + dev = &rte_eth_devices[port]; > + if (!is_i40e_supported(dev)) > + return -ENOTSUP; > + > + i40e_fdir_stats_get(dev, fdir_stat); > + > + return 0; > +} > + > +int > +rte_pmd_i40e_set_gre_key_len(uint16_t port, uint8_t len) > +{ > + struct rte_eth_dev *dev; > + struct i40e_pf *pf; > + struct i40e_hw *hw; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > + > + dev = &rte_eth_devices[port]; > + if (!is_i40e_supported(dev)) > + return -ENOTSUP; > + > + pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private); > + hw = I40E_PF_TO_HW(pf); > + > + return i40e_dev_set_gre_key_len(hw, len); > +} > + > int > rte_pmd_i40e_set_switch_dev(uint16_t port_id, struct rte_eth_dev *switch_dev) > { > diff --git a/drivers/net/i40e/rte_pmd_i40e.h b/drivers/net/i40e/rte_pmd_i40e.h > index 915cdf076..0f6715efc 100644 > --- a/drivers/net/i40e/rte_pmd_i40e.h > +++ b/drivers/net/i40e/rte_pmd_i40e.h > @@ -1061,6 +1061,55 @@ rte_pmd_i40e_inset_field_clear(uint64_t *inset, uint8_t field_idx) > return 0; > } > > +/** > + * Get port fdir info > + * > + * @param port > + * The port identifier of the Ethernet device. > + * @param fdir_info > + * The fdir info of the port > + * @return > + * - (0) if successful. > + * - (-ENODEV) if *port* invalid. > + * - (-ENOTSUP) if operation not supported. > + */ > +__rte_experimental > +int > +rte_pmd_i40e_get_fdir_info(uint16_t port, struct rte_eth_fdir_info *fdir_info); > + > +/** > + * Get port fdir status > + * > + * @param port > + * The port identifier of the Ethernet device. > + * @param fdir_stat > + * The fdir status of the port > + * @return > + * - (0) if successful. > + * - (-ENODEV) if *port* invalid. > + * - (-ENOTSUP) if operation not supported. > + */ > +__rte_experimental > +int > +rte_pmd_i40e_get_fdir_stats(uint16_t port, > + struct rte_eth_fdir_stats *fdir_stat); > + > +/** > + * Set GRE key length > + * > + * @param port > + * The port identifier of the Ethernet device. > + * @param len > + * Length of gre-key > + * @return > + * - (0) if successful. > + * - (-ENODEV) if *port* invalid. > + * - (-ENOTSUP) if operation not supported. > + */ > +__rte_experimental > +int > +rte_pmd_i40e_set_gre_key_len(uint16_t port, uint8_t len); > + > /** > * For ipn3ke, i40e works with FPGA. > * In this situation, i40e get link status from fpga, > diff --git a/drivers/net/i40e/rte_pmd_i40e_version.map b/drivers/net/i40e/rte_pmd_i40e_version.map > index c92c0cf46..f6cd3b356 100644 > --- a/drivers/net/i40e/rte_pmd_i40e_version.map > +++ b/drivers/net/i40e/rte_pmd_i40e_version.map > @@ -42,5 +42,8 @@ DPDK_20.0 { > EXPERIMENTAL { > global: > > + rte_pmd_i40e_get_fdir_info; > + rte_pmd_i40e_get_fdir_stats; > + rte_pmd_i40e_set_gre_key_len; > rte_pmd_i40e_set_switch_dev; > };