From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 262A9C2BA2B for ; Fri, 10 Apr 2020 15:17:48 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 9AFF320753 for ; Fri, 10 Apr 2020 15:17:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=semihalf-com.20150623.gappssmtp.com header.i=@semihalf-com.20150623.gappssmtp.com header.b="vINVNuFL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AFF320753 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=semihalf.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D02AD1D52F; Fri, 10 Apr 2020 17:17:46 +0200 (CEST) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by dpdk.org (Postfix) with ESMTP id 5BF821D52F for ; Fri, 10 Apr 2020 17:17:45 +0200 (CEST) Received: by mail-lf1-f66.google.com with SMTP id t11so1588602lfe.4 for ; Fri, 10 Apr 2020 08:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KPHG4sFfmXB4iSm9tnHcpJpI10CF+pIqq17FnAauXlY=; b=vINVNuFLfBEmtcajshpLXmUCuLrQuk131IB6iNQGsI5K9pb67/BipE7nJcgU1dIK2Y 73ZMVwGTB4iNuw2Rh/oD1ApKrs4hWD+GheW3h1xCykWI2TwPaj7sPn74R5dA4SVoEwci 7Fy7zOzX2lu0RvDixOmz03763j8nZ6PpsZ9qYS0QfKzIT9L/SvDvJgRZDO3WXNzDATSD /UJULOHjYTMxRR5/VL/VEONhA+X4tFUx06enbZ7cFCOr/Zz77gR4kgW0sJRFA1TVhNtc GPszvaXFy6pAG4AZSHSHSlhN0+NHoEQ0yjLK1DbwvWDe7Jy9eNd4zPSzg1ZZnlW32E7N T1Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KPHG4sFfmXB4iSm9tnHcpJpI10CF+pIqq17FnAauXlY=; b=VqM6+gdHUUMuTiMd4Kh6hpOCo3M+SuUGsHkcJVEb1+2nObtzmKQ5cNwcA6qO8x7ndl cSRuqlhZlyhV4ihFmRZFNLiR0THJfetTy1A73ofasvWn72lPT/lDdXZBheDpG22kFN/q Ha/3CgTep2TgPkepWKi8AMe2rW6ualZfpFrwnwhgufk7xclAXakplZuQwBMAABR/Z+oF IpPzak6+uzo8ZOqUuMz7IOQvKQC71scrzOgdWg7WOPCj3tcOF41hoGNqOG1e5ehMiBSX K9vfYlJ4qm9Gxu8wFTb7DD5pkwMdMUu2Z20+6502bEHvNDvTljjfOq7ZYTvCBvpm8RAs nJyQ== X-Gm-Message-State: AGi0Pua+QQ0MEK1ozEqlKzZA5jkt6QlfsEEW66MHbdKNuHwMybewUhIC TForkA9IfgrsZz2/iDFHeBpQQfndM62LoA== X-Google-Smtp-Source: APiQypKliOCPFukt8E7Wet3I0LobZMtR0iLx4CgrE2tt2pSPOkYrUnH4IPdWoyPhDdP4d7Lx+tpTvw== X-Received: by 2002:ac2:51c9:: with SMTP id u9mr3029511lfm.184.1586531864118; Fri, 10 Apr 2020 08:17:44 -0700 (PDT) Received: from [192.168.8.100] (user-5-173-40-139.play-internet.pl. [5.173.40.139]) by smtp.gmail.com with ESMTPSA id k3sm1243635lji.43.2020.04.10.08.17.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Apr 2020 08:17:43 -0700 (PDT) To: Nithin Dabilpuram Cc: dev@dpdk.org References: <20200331192945.2466880-1-jerinj@marvell.com> <20200405085613.1336841-1-jerinj@marvell.com> <20200405085613.1336841-20-jerinj@marvell.com> <20200410102006.GA15933@outlook.office365.com> <20200410144130.GA4537@outlook.office365.com> From: Andrzej Ostruszka Message-ID: <0216c538-89f9-4d64-d859-9ad1e46314dd@semihalf.com> Date: Fri, 10 Apr 2020 17:17:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200410144130.GA4537@outlook.office365.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 19/29] node: add generic ipv4 lookup node X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/10/20 4:41 PM, Nithin Dabilpuram wrote: > On Fri, Apr 10, 2020 at 03:50:06PM +0530, Nithin Dabilpuram wrote: >> On Fri, Apr 10, 2020 at 01:07:34AM +0200, Andrzej Ostruszka wrote: [...] >>>> + next_hop = (rc == 0) ? next_hop : drop_nh; >>> >>> Maybe simple if here? I see the same in other patches. >> >> Will fix it in V5. > > I now see it is better to leave this statement > instead of putting an "if(unlikely(rc))" that might force an > explicit branch instruction. On other hand, conditional might > be making use of an "csel" instruction in arm64 or "cmov" in x86. > Are you ok with leaving this line as it is ? or you have a strong opinion > to change it to if ? It is fine - if you think the generated code will be better then leave it. With regards Andrzej Ostruszka