DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] net/i40e: remove queue_stats_mapping_set
@ 2019-05-28 19:43 Stephen Hemminger
  2019-05-29  9:11 ` Maxime Coquelin
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2019-05-28 19:43 UTC (permalink / raw)
  To: beilei.xing, qi.z.zhang; +Cc: dev, Stephen Hemminger

This driver was inserting its own stub for queue_stats_mapping which
did nothing but cause this device to return a different errno
than every other device driver.  All devices that don't implement
queue stats mapping should return the same error.

Maybe the plan originally was to implement something, if that
ever happens, just put in the right code.

Fixes: 4861cde46116 ("i40e: new poll mode driver")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/i40e/i40e_ethdev.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index cab440f5a8f6..5bbcbb4fc608 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -237,10 +237,6 @@ static int i40e_dev_xstats_get_names(struct rte_eth_dev *dev,
 				     struct rte_eth_xstat_name *xstats_names,
 				     unsigned limit);
 static void i40e_dev_stats_reset(struct rte_eth_dev *dev);
-static int i40e_dev_queue_stats_mapping_set(struct rte_eth_dev *dev,
-					    uint16_t queue_id,
-					    uint8_t stat_idx,
-					    uint8_t is_rx);
 static int i40e_fw_version_get(struct rte_eth_dev *dev,
 				char *fw_version, size_t fw_size);
 static void i40e_dev_info_get(struct rte_eth_dev *dev,
@@ -456,7 +452,6 @@ static const struct eth_dev_ops i40e_eth_dev_ops = {
 	.xstats_get_names             = i40e_dev_xstats_get_names,
 	.stats_reset                  = i40e_dev_stats_reset,
 	.xstats_reset                 = i40e_dev_stats_reset,
-	.queue_stats_mapping_set      = i40e_dev_queue_stats_mapping_set,
 	.fw_version_get               = i40e_fw_version_get,
 	.dev_infos_get                = i40e_dev_info_get,
 	.dev_supported_ptypes_get     = i40e_dev_supported_ptypes_get,
@@ -3431,17 +3426,6 @@ i40e_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,
 	return count;
 }
 
-static int
-i40e_dev_queue_stats_mapping_set(__rte_unused struct rte_eth_dev *dev,
-				 __rte_unused uint16_t queue_id,
-				 __rte_unused uint8_t stat_idx,
-				 __rte_unused uint8_t is_rx)
-{
-	PMD_INIT_FUNC_TRACE();
-
-	return -ENOSYS;
-}
-
 static int
 i40e_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size)
 {
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/i40e: remove queue_stats_mapping_set
  2019-05-28 19:43 [dpdk-dev] [PATCH] net/i40e: remove queue_stats_mapping_set Stephen Hemminger
@ 2019-05-29  9:11 ` Maxime Coquelin
  2019-06-18 14:09   ` Zhang, Qi Z
  0 siblings, 1 reply; 3+ messages in thread
From: Maxime Coquelin @ 2019-05-29  9:11 UTC (permalink / raw)
  To: Stephen Hemminger, beilei.xing, qi.z.zhang; +Cc: dev



On 5/28/19 9:43 PM, Stephen Hemminger wrote:
> This driver was inserting its own stub for queue_stats_mapping which
> did nothing but cause this device to return a different errno
> than every other device driver.  All devices that don't implement
> queue stats mapping should return the same error.
> 
> Maybe the plan originally was to implement something, if that
> ever happens, just put in the right code.
> 
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>   drivers/net/i40e/i40e_ethdev.c | 16 ----------------
>   1 file changed, 16 deletions(-)
> 


Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/i40e: remove queue_stats_mapping_set
  2019-05-29  9:11 ` Maxime Coquelin
@ 2019-06-18 14:09   ` Zhang, Qi Z
  0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2019-06-18 14:09 UTC (permalink / raw)
  To: Maxime Coquelin, Stephen Hemminger, Xing, Beilei; +Cc: dev



> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Wednesday, May 29, 2019 5:12 PM
> To: Stephen Hemminger <stephen@networkplumber.org>; Xing, Beilei
> <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: remove queue_stats_mapping_set
> 
> 
> 
> On 5/28/19 9:43 PM, Stephen Hemminger wrote:
> > This driver was inserting its own stub for queue_stats_mapping which
> > did nothing but cause this device to return a different errno than
> > every other device driver.  All devices that don't implement queue
> > stats mapping should return the same error.
> >
> > Maybe the plan originally was to implement something, if that ever
> > happens, just put in the right code.
> >
> > Fixes: 4861cde46116 ("i40e: new poll mode driver")
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> >   drivers/net/i40e/i40e_ethdev.c | 16 ----------------
> >   1 file changed, 16 deletions(-)
> >
> 
> 
> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied to dpdk-next-net-intel.

Thanks
Qi


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-28 19:43 [dpdk-dev] [PATCH] net/i40e: remove queue_stats_mapping_set Stephen Hemminger
2019-05-29  9:11 ` Maxime Coquelin
2019-06-18 14:09   ` Zhang, Qi Z

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox