From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CE6FC76188 for ; Fri, 19 Jul 2019 05:26:38 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 2BA6820873 for ; Fri, 19 Jul 2019 05:26:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BA6820873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C8901DBF; Fri, 19 Jul 2019 07:26:37 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 28CC11B53; Fri, 19 Jul 2019 07:26:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 22:26:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,280,1559545200"; d="scan'208";a="173405778" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 18 Jul 2019 22:26:32 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 22:26:32 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.232]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.109]) with mapi id 14.03.0439.000; Fri, 19 Jul 2019 13:26:30 +0800 From: "Zhang, Qi Z" To: "Wang, Haiyue" , "Zhang, Xiao" , "dev@dpdk.org" CC: "Xing, Beilei" , "stable@dpdk.org" Thread-Topic: [v4] net/i40e: fix SFP X722 not work with FW4.16 Thread-Index: AQHVPdZPzTeufSUjBE2D56CU0nTCfabQrnuAgAC6wDA= Date: Fri, 19 Jul 2019 05:26:30 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153D6977C@SHSMSX105.ccr.corp.intel.com> References: <1563531994-10076-1-git-send-email-xiao.zhang@intel.com> <1563533997-10878-1-git-send-email-xiao.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTVmOGI0YWYtMDI5NS00ZTM0LThhM2YtY2MyZjUxYTFhNjhhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNWJCV2dkaFJRV08waTJMTjV1WW1oejdqT1k2SEw4TEE0UW4wMWwzTlZsVjlraXpVNExaQ0Zja1kyMHIrNUI4eCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [v4] net/i40e: fix SFP X722 not work with FW4.16 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Haiyue > Sent: Friday, July 19, 2019 10:18 AM > To: Zhang, Xiao ; dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > stable@dpdk.org > Subject: RE: [v4] net/i40e: fix SFP X722 not work with FW4.16 >=20 > > -----Original Message----- > > From: Zhang, Xiao > > Sent: Friday, July 19, 2019 19:00 > > To: dev@dpdk.org > > Cc: Xing, Beilei ; Wang, Haiyue > > ; Zhang, Qi Z ; Zhang, > > Xiao ; stable@dpdk.org > > Subject: [v4] net/i40e: fix SFP X722 not work with FW4.16 > > > > The code checked the NVM API version of FW to check if support adminq > > operation, when version is 1.7 or above adminq operation is support > > and the adminq flag will be set. The code will use adminq to set TPID > > if the flags set or to use register. The NVM API version of SFP X722 > > old versions are lowwer than 1.7 and for FW4.16 is 1.8. But FW4.16 of > > SFP > > X722 does not support adminq operation, the legacy logic is not > > compatible with device SFP X722 currently. Check the device id to > > unset adminq flag to use resigter setting to make it work. > > > > Fixes: 73cd7d6dc8e1 ("net/i40e: use set switch AQ instead of register > > setting") > > Cc: stable@dpdk.org > > > > Signed-off-by: Xiao Zhang > > --- >=20 > Reviewed-by: Haiyue Wang Applied to dpdk-next-net-intel. Thanks Qi