From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Cc: <linuxarm@huawei.com>, <xavier_huwei@163.com>,
<liudongdong3@huawei.com>, <forest.zhouchang@huawei.com>
Subject: Re: [dpdk-dev] [PATCH 04/22] net/hns3: add support for cmd of hns3 PMD driver
Date: Fri, 6 Sep 2019 14:49:52 +0800
Message-ID: <082a2b54-0641-42ea-d327-0614ebbef8fc@huawei.com> (raw)
In-Reply-To: <30af42d3-c582-fac0-c13f-8c52f063bd14@intel.com>
Hi, Ferruh Yigit
On 2019/8/30 23:02, Ferruh Yigit wrote:
> On 8/23/2019 2:46 PM, Wei Hu (Xavier) wrote:
>> This patch adds support for cmd of hns3 PMD driver, driver can interact
>> with firmware through command to complete hardware configuration.
>>
>> Signed-off-by: Hao Chen <chenhao164@huawei.com>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>> Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> <...>
>
>> diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h
>> index bfb54f2..84fcf34 100644
>> --- a/drivers/net/hns3/hns3_ethdev.h
>> +++ b/drivers/net/hns3/hns3_ethdev.h
>> @@ -39,7 +39,6 @@
>>
>> #define HNS3_4_TCS 4
>> #define HNS3_8_TCS 8
>> -#define HNS3_MAX_TC_NUM 8
> This definition is used by 'hns3_ethdev.h' but moved to 'hns3_cmd.h', and
> 'hns3_ethdev.h' doesn't include 'hns3_cmd.h', which will force whatever .c file
> include 'hns3_ethdev.h' to include 'hns3_cmd.h' before it and these kind of .h
> order dependencies are easy to break.
> Would it work if 'hns3_ethdev.h' includes 'hns3_cmd.h'
>
We will update it and send patch V2.
Thanks for your suggestion.
Regards
Xavier
>
next prev parent reply index
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 13:46 [dpdk-dev] [PATCH 00/22] add hns3 ethernet " Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 01/22] net/hns3: add hardware registers definition Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 02/22] net/hns3: add some definitions for data structure and macro Wei Hu (Xavier)
2019-08-30 8:25 ` Gavin Hu (Arm Technology China)
2019-09-05 6:01 ` Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 03/22] net/hns3: register hns3 PMD driver Wei Hu (Xavier)
2019-08-30 15:01 ` Ferruh Yigit
2019-09-06 6:20 ` Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 04/22] net/hns3: add support for cmd of " Wei Hu (Xavier)
2019-08-30 15:02 ` Ferruh Yigit
2019-09-06 6:49 ` Wei Hu (Xavier) [this message]
2019-08-23 13:46 ` [dpdk-dev] [PATCH 05/22] net/hns3: add the initialization " Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 06/22] net/hns3: add support for MAC address related operations Wei Hu (Xavier)
2019-08-30 15:03 ` Ferruh Yigit
2019-09-05 5:40 ` Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 07/22] net/hns3: add support for some misc operations Wei Hu (Xavier)
2019-08-30 15:04 ` Ferruh Yigit
2019-08-23 13:46 ` [dpdk-dev] [PATCH 08/22] net/hns3: add support for link update operation Wei Hu (Xavier)
2019-08-30 15:04 ` Ferruh Yigit
2019-09-06 6:56 ` Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 09/22] net/hns3: add support for flow directory of hns3 PMD driver Wei Hu (Xavier)
2019-08-30 15:06 ` Ferruh Yigit
2019-09-06 8:23 ` Wei Hu (Xavier)
2019-09-06 11:08 ` Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 10/22] net/hns3: add support for RSS " Wei Hu (Xavier)
2019-08-30 15:07 ` Ferruh Yigit
2019-08-31 9:16 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 11/22] net/hns3: add support for flow control " Wei Hu (Xavier)
2019-08-30 15:07 ` Ferruh Yigit
2019-08-31 8:04 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 12/22] net/hns3: add support for VLAN " Wei Hu (Xavier)
2019-08-30 15:08 ` Ferruh Yigit
2019-08-31 9:04 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 13/22] net/hns3: add support for mailbox " Wei Hu (Xavier)
2019-08-30 15:08 ` Ferruh Yigit
2019-09-06 11:25 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 14/22] net/hns3: add support for hns3 VF " Wei Hu (Xavier)
2019-08-30 15:11 ` Ferruh Yigit
2019-08-31 9:03 ` Wei Hu (Xavier)
2019-09-06 11:27 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 15/22] net/hns3: add package and queue related operation Wei Hu (Xavier)
2019-08-23 15:42 ` Aaron Conole
2019-08-30 15:13 ` Ferruh Yigit
2019-09-11 11:40 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 16/22] net/hns3: add start stop configure promiscuous ops Wei Hu (Xavier)
2019-08-30 15:14 ` Ferruh Yigit
2019-09-06 11:51 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 17/22] net/hns3: add dump register ops for hns3 PMD driver Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 18/22] net/hns3: add abnormal interrupt process " Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 19/22] net/hns3: add stats related ops " Wei Hu (Xavier)
2019-08-30 15:20 ` Ferruh Yigit
2019-08-31 8:49 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 20/22] net/hns3: add reset related process " Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 21/22] net/hns3: add multiple process support " Wei Hu (Xavier)
2019-08-30 15:14 ` Ferruh Yigit
2019-09-02 13:41 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files Wei Hu (Xavier)
2019-08-23 14:08 ` Jerin Jacob Kollanukkaran
2019-08-30 3:22 ` Wei Hu (Xavier)
2019-08-31 2:10 ` Wei Hu (Xavier)
2019-08-30 14:57 ` Ferruh Yigit
2019-08-30 6:16 ` Stephen Hemminger
2019-08-31 8:46 ` Wei Hu (Xavier)
2019-08-30 6:17 ` Stephen Hemminger
2019-08-31 8:44 ` Wei Hu (Xavier)
2019-09-03 15:27 ` Ye Xiaolong
2019-09-11 11:36 ` Wei Hu (Xavier)
2019-08-30 14:58 ` Ferruh Yigit
2019-09-10 11:43 ` Wei Hu (Xavier)
2019-08-30 15:00 ` Ferruh Yigit
2019-08-31 8:07 ` Wei Hu (Xavier)
2019-08-30 15:12 ` Ferruh Yigit
2019-08-31 8:07 ` Wei Hu (Xavier)
2019-08-30 15:23 ` [dpdk-dev] [PATCH 00/22] add hns3 ethernet PMD driver Ferruh Yigit
2019-08-31 8:06 ` Wei Hu (Xavier)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=082a2b54-0641-42ea-d327-0614ebbef8fc@huawei.com \
--to=xavier.huwei@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=forest.zhouchang@huawei.com \
--cc=linuxarm@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=xavier_huwei@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
dev@dpdk.org
public-inbox-index dpdk-dev
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.dpdk.dev
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git