Re: [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files

["Wei Hu (Xavier)" <xavier.huwei@huawei.com>]

On 2019/9/2 12:24, Jerin Jacob Kollanukkaran wrote:
>> -----Original Message-----
>> From: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>> Sent: Saturday, August 31, 2019 7:41 AM
>> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; dev@dpdk.org
>> Cc: xavier_huwei@163.com; linuxarm@huawei.com;
>> forest.zhouchang@huawei.com
>> Subject: [EXT] Re: [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files
>>
>>>>> +- Arch support: ARMv8.
>>>> Is it an integrated NIC controller? Why it is supported only on ARMv8?
>>>> The reason why I asking because, Enabling
>>>> CONFIG_RTE_LIBRTE_HNS3_PMD=y only on arm64 will create a case
>> where
>>>> build fails for arm64 and passes for x86. I would like to avoid such
>>>> disparity. If the build is passing on x86 make it enable in the common
>> code, not in arm64 config.
>>> Currently this network engine is integrated in the SoCs, the SoCs can
>>> be used as a PCIe EP integrated NIC controllers or be used as
>>> universal cpus on the device, such as servers. The network engine is
>>> accessed by ARM cores in the SoCs.
>>> We will enabling CONFIG_RTE_LIBRTE_HNS3_PMD=y in common_linux
>> config in V2.
>>> Thanks.
>> Hi,  Jerin
> Hi Xaiver,
>
>>     as a PCIe EP integrated NIC controllers -> as a PCIe EP Intelligent NIC
>> controllers
>>
>>     Since it is currently only accessed by ARM cores on SoCs,
>>     maybe it is also reasonable to compile only on ARMv8, right?
> Since it is using PCIe infra to probe the devices and it will be always
> Probed only on the intended system and if there is no armv8 specific
> Instructions used then I prefer to build it for all archs to avoid the case
> where build fails only with arm64 and not with other arch incase
> If there is build issue with this PMD.
Hi, Jerin
    We will ensure it can be built successfully with arm64 and x86-64
arch in patch V2.
    Thanks for your suggestion.

    Regards
Xavier
>
>