From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F7B5CA9EAF for ; Sun, 27 Oct 2019 17:13:08 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 8B71E214AF for ; Sun, 27 Oct 2019 17:13:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="GyqB0uf8"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="uEdIboWt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B71E214AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CEC2E1BF01; Sun, 27 Oct 2019 18:13:06 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 7CD191BEFD for ; Sun, 27 Oct 2019 18:13:05 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 4B3E0562; Sun, 27 Oct 2019 13:13:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 27 Oct 2019 13:13:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Q/WITKaaqKgRBBPBi+NsX67x2/wZAKYcooh75NytcOA=; b=GyqB0uf8UqoY iZc34DuUnCekpJ04DeoWmINQkcDHRZ+HSvfKAFx0fIzhObTmdWf1bOHOm5Vnj8vK D9sdEamRTtrI5lk8OD+aJVh0ik3c2mbYKcFnMzY22CpJXbzHu2EQLqMulWAm0zIN /51K7vV/zu8HY3QgftG5ahPwIucYL0s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Q/WITKaaqKgRBBPBi+NsX67x2/wZAKYcooh75Nytc OA=; b=uEdIboWt7eKexEIVDzedzywlZokb+HIK+L4ZNpQQUzykapegJ3wwqwxwA U4wHnjjovzmvkhdknP04YKSCvNt2UY+xxdcvVvv91A5trR3Y7Xa8JArPYuhJcd3y XXx2FI16PFFgBqMlR745OvF0yCgEGOYlXyXfYZSkzOmyfmbFVLp3Q//rG07qXK/J qjuKEvN++ndUOnWSxzfaSfJFhsHLVOcFcY9OWEfRvbcfDE6Zc7rfbGX+YaQParrA 1xgRx34QjYKdIRd6gROokmdNeBUwW158RG6NeMZHkmZrUJpRi27I460NQUT7f4ct wpx1SrVVbURlxxBY9ryRe6N4GsFLA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrleejgddutddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 57459D6005E; Sun, 27 Oct 2019 13:13:02 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson , Stephen Hemminger Cc: dev@dpdk.org, olivier.matz@6wind.com Date: Sun, 27 Oct 2019 18:13:01 +0100 Message-ID: <10078998.bm3lhGYCMG@xps> In-Reply-To: <20191010104623.10090-1-bruce.richardson@intel.com> References: <20191010104623.10090-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ether: remove packing and set two-byte alignment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/10/2019 12:46, Bruce Richardson: > The ether header does not need to be packed since that makes no sense for > structures with only bytes in them, but it should be aligned to a two-byte > boundary to simplify access to it from code. Other packed structures that > use this also need to be updated to take account of the change, either by > removing packing - where it is clearly unneeded - or by explicitly giving > those structures 2-byte alignment also. > > Signed-off-by: Stephen Hemminger > Signed-off-by: Bruce Richardson Applied, thanks