From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F9E5C432C0 for ; Mon, 25 Nov 2019 21:55:03 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id AD08620740 for ; Mon, 25 Nov 2019 21:55:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="X1zaqP3p"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="QXMU5RhX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD08620740 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F21628EE; Mon, 25 Nov 2019 22:55:01 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 4C23F235 for ; Mon, 25 Nov 2019 22:54:59 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id ADA0522768; Mon, 25 Nov 2019 16:54:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 25 Nov 2019 16:54:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=PopPyfhpbRKf566Uxxd5JnTILqd9B5ewxFsZkOf09WE=; b=X1zaqP3pHxFA pA+InF0AALLdLOQYBLxhfaHbty6l4BRv5DUH/nS3dk09DaEi0ERt5yErQ+MUJdEc 0wz/2TFf6wy5LDgWJ/EdPAq0/ZxQAIahydrHdR6+zkG6qatSKhNQdOdD/WJnSMSk 5tti9YG1OfRthb8hrFmcv7GvKymlIPE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=PopPyfhpbRKf566Uxxd5JnTILqd9B5ewxFsZkOf09 WE=; b=QXMU5RhX7r0HeXOvO90bBv42wkvebIdWfUmaig2dBhX8djmC4a5aUpKGd OB9c1e6UC27AhoZoUV7FEiQRnS0vKKv2psfpFTxQzkjOmxkYlyOn8Pc05y+lJ2AA iI8HwYmim9vgrXmcb7TymAksSFbF7/jNUlUSugpA8GGB9iBCLiC/7N0iDelgyQal TfPYswMJLsYNGZ+bui3d3twaeX7aaCDqQrtTXwweG8cGMGfaZb9J9UTkGcI2YKKW i3kGZJlqCzu88JOBQgF4YraexIvhTZpxQ6C8clM84vuFVAZrht6GMoHzHq2V+tuU w9kS4C7ptwBxN+3JboCt7jxSSCtyg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeiuddgudehhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ffohhmrghinhephhhurghrmhdrtghomhenucfkphepjeejrddufeegrddvtdefrddukeeg necurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvg htnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DDB5A8005B; Mon, 25 Nov 2019 16:54:55 -0500 (EST) From: Thomas Monjalon To: "Wang, Yipeng1" , Dharmik Thakkar Cc: dev@dpdk.org, "Gobriel, Sameh" , "Richardson, Bruce" , "honnappa.nagarahalli@arm.com" Date: Mon, 25 Nov 2019 22:54:54 +0100 Message-ID: <10640783.jF6kOFs2fc@xps> In-Reply-To: References: <20191121181759.11401-1-dharmik.thakkar@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] lib/hash: remove unnecessary locks in lock-free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/11/2019 19:49, Wang, Yipeng1: > >-----Original Message----- > >From: Dharmik Thakkar [mailto:dharmik.thakkar@arm.com] > >Sent: Thursday, November 21, 2019 10:18 AM > >To: Wang, Yipeng1 ; Gobriel, Sameh ; Richardson, Bruce > > > >Cc: dev@dpdk.org; honnappa.nagarahalli@arm.com; Dharmik Thakkar > >Subject: [PATCH] lib/hash: remove unnecessary locks in lock-free > > > >Remove __hash_rw_reader_unlock() calls from lock free hash lookup > > > >Signed-off-by: Dharmik Thakkar > >Reviewed-by: Gavin Hu > >Reviewed-by: Honnappa Nagarahalli > >--- > Acked-by: Yipeng Wang > > Thanks for the patch! Excuse me, there is no motivation (the why) in this patch. Is it critical? which gain?