From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, URIBL_SBL,URIBL_SBL_A,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33EDBC4321A for ; Fri, 28 Jun 2019 08:08:08 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 855E82063F for ; Fri, 28 Jun 2019 08:08:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 855E82063F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E57271B993; Fri, 28 Jun 2019 10:08:05 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 52EFD58C6 for ; Fri, 28 Jun 2019 10:08:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2019 01:08:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,426,1557212400"; d="scan'208";a="337840819" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.30]) ([10.237.221.30]) by orsmga005.jf.intel.com with ESMTP; 28 Jun 2019 01:08:02 -0700 To: Jerin Jacob Kollanukkaran Cc: "dev@dpdk.org" , Thomas Monjalon , Amit Gupta References: From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQkI71rKFiEE 0jZTh0IuwoTjmYHH+TPrQ98TYR8FAlznMMQFCwkIBwMFFQoJCAsFFgIDAQAACgkQ+TPrQ98T YR/B9Q//a57esjq996nfZVm7AsUl7zbvhN+Ojity25ib2gcSVVsAN2j6lcQS4hf6/OVvRj3q CgebJ4o2gXR6X12UzWBJL7NE8Xpc70MvUIe0r11ykurQ9n9jUaWMjxdSqBPF93hU+Z/MZe5M 1rW5O2VJLuTJzkDw3EYUCbHOwPjeaS8Qqj3RI0LYbGthbHBIp9CsjkgsJSjTT5GQ8AQWkE7I z+hvPx6f1rllfjxFyi4DI3jLhAI+j1Nm+l+ESyoX59HrLTHAvq4RPkLpTnGBj9gOnJ+5sVEr GE0fcffsNcuMSkpqSEoJCPAHmChoLgezskhhsy0BiU3xlSIj1Dx2XMDerUXFOK3ftlbYNRte HQy4EKubfZRB8H5Rvcpksom3fRBDcJT8zw+PTH14htRApU9f8I/RamQ7Ujks7KuaB7JX5QaG gMjfPzHGYX9PfF6KIchaFmAWLytIP1t0ht8LpJkjtvUCSQZ2VxpCXwKyUzPDIF3co3tp90o7 X07uiC5ymX0K0+Owqs6zeslLY6DMxNdt8ye+h1TVkSZ5g4dCs4C/aiEF230+luL1CnejOv/K /s1iSbXQzJNM7be3FlRUz4FdwsfKiJJF7xYALSBnSvEB04R7I2P2V9Zpudkq6DRT6HZjBeJ1 pBF2J655cdoenPBIeimjnnh4K7YZBzwOLJf2c6u76fe5Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXOcvZgUJBvIWKAAKCRD5M+tD3xNhHxhBD/9toXMIaPIVFd9w1nKsRDM1GE6gZe4jie8q MJpeHB9O+936fSXA0W2X0het60wJQQ45O8TpTcxpc9nGzcE4MTaLAI3E8TjIXAO0cPqUNLyp g0DXezmTw5BU+SKZ51+jSKOtFmzJCHOJZQaMeCHD+G3CrdUHQVQBb5AeuH3KFv9ltgDcWsc8 YO70o3+tGHwcEnyXLdrI0q05wV7ncnLdkgVo+VUN4092bNMPwYly1TZWcU3Jw5gczOUEfTY7 sgo6E/sGX3B+FzgIs5t4yi1XOweCAQ/mPnb6uFeNENEFyGKyMG1HtjwBqnftbiFO3qitEIUY xWGQH23oKscv7i9lT0gg2D+ktzZhVWwHJVY/2vWSB9aCSWChcH2BT+lWrkwSpoPhy+almM84 Qz2wF72/d4ce4L27pSrS+vOXtXHLGOOGcAn8yr9TV0kM4aR+NbGBRXGKhG6w4lY54uNd9IBa ARIPUhij5JSygxZCBaJKo+X64AHGkk5bXq+f0anwAMNuJXbYC/lz4DEdKmPgQGShOWNs1Y1a N3cI87Hun/RBVwQ0a3Tr1g6OWJ6xK8cYbMcoR8NZ7L9ALMeJeuUDQR39+fEeHg/6sQN0P0mv 0sL+//BAJphCzDk8ztbrFw+JaPtgzZpRSM6JhxnY+YMAsatJRXA0WSpYP5zzl7yu/GZJIgsv VQ== Message-ID: <108634f5-5918-7ce5-9a4e-caebd34407ae@intel.com> Date: Fri, 28 Jun 2019 09:08:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 00/27] OCTEON TX2 common and mempool driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/28/2019 7:14 AM, Jerin Jacob Kollanukkaran wrote: > > >> -----Original Message----- >> From: dev On Behalf Of Jerin Jacob Kollanukkaran >> Sent: Thursday, June 27, 2019 1:45 PM >> To: Ferruh Yigit >> Cc: dev@dpdk.org; Thomas Monjalon ; Amit Gupta >> >> Subject: Re: [dpdk-dev] [PATCH v4 00/27] OCTEON TX2 common and >> mempool driver >>> >>> Hi Jerin, >>> >>> There are some build errors with ICC, there are multiple but mainly >>> two type of them [1a] & [1b]. >>> >>> I think [1b] can be fixed quickly [2b] and what do you think about >>> ignoring the warning for [1a] as done in [2a]? >>> >>> If fix makes sense, can you please send a patch for it? >> >> Will install ICC and send the patches(excluding >> http://mails.dpdk.org/archives/dev/2019-June/135950.html) > > Not able to reproduce the issue with latest ICC compiler. > $ icc -v > > icc version 19.0.4.235 (gcc version 8.3.1 compatibility) > > If you think, it can happen with old ICC compiler. Then we will send a patch with > CFLAGS += -diag-disable 2259 for ICC. We use almost same version, icc (ICC) 19.0.4.227 20190416, build error is from 32-bits [1] [1] Building i686-native-linuxapp-icc ... In file included from .../dpdk/drivers/common/octeontx2/otx2_dev.h(13), from .../dpdk/drivers/common/octeontx2/otx2_common.c(10): .../dpdk/drivers/mempool/octeontx2/otx2_mempool.h(94): error #2259: non-pointer conversion from "unsigned long long" to "int64_t={__int64_t={signed long long}} *" may lose significant bits (int64_t *)(npa_lf_aura_handle_to_base(aura_handle) + ^ In file included from .../dpdk/drivers/common/octeontx2/otx2_dev.h(13), from .../dpdk/drivers/common/octeontx2/otx2_common.c(10): .../dpdk/drivers/mempool/octeontx2/otx2_mempool.h(106): error #2259: non-pointer conversion from "unsigned long long" to "void *" may lose significant bits otx2_store_pair(iova, reg, ^ In file included from .../dpdk/drivers/common/octeontx2/otx2_dev.h(13), from .../dpdk/drivers/common/octeontx2/otx2_common.c(10): .../dpdk/drivers/mempool/octeontx2/otx2_mempool.h(106): error #2259: non-pointer conversion from "unsigned long long" to "uint8_t={__uint8_t={unsigned char}} *" may lose significant bits otx2_store_pair(iova, reg, ^ In file included from .../dpdk/drivers/common/octeontx2/otx2_dev.h(13), from .../dpdk/drivers/common/octeontx2/otx2_common.c(10): .../dpdk/drivers/mempool/octeontx2/otx2_mempool.h(119): error #2259: non-pointer conversion from "unsigned long long" to "int64_t={__int64_t={signed long long}} *" may lose significant bits (int64_t *)(npa_lf_aura_handle_to_base(aura_handle) + ^ In file included from .../dpdk/drivers/common/octeontx2/otx2_dev.h(13), from .../dpdk/drivers/common/octeontx2/otx2_common.c(10): .../dpdk/drivers/mempool/octeontx2/otx2_mempool.h(138): error #2259: non-pointer conversion from "unsigned long long" to "void *" may lose significant bits otx2_write64(reg, ^ In file included from .../dpdk/drivers/common/octeontx2/otx2_dev.h(13), from .../dpdk/drivers/common/octeontx2/otx2_common.c(10): .../dpdk/drivers/mempool/octeontx2/otx2_mempool.h(151): error #2259: non-pointer conversion from "unsigned long long" to "int64_t={__int64_t={signed long long}} *" may lose significant bits (int64_t *)(npa_lf_aura_handle_to_base(aura_handle) + ^ In file included from .../dpdk/drivers/common/octeontx2/otx2_dev.h(13), from .../dpdk/drivers/common/octeontx2/otx2_common.c(10): .../dpdk/drivers/mempool/octeontx2/otx2_mempool.h(167): error #2259: non-pointer conversion from "unsigned long long" to "void *" may lose significant bits otx2_write64(reg, ^ In file included from .../dpdk/drivers/common/octeontx2/otx2_dev.h(13), from .../dpdk/drivers/common/octeontx2/otx2_common.c(10): .../dpdk/drivers/mempool/octeontx2/otx2_mempool.h(180): error #2259: non-pointer conversion from "unsigned long long" to "int64_t={__int64_t={signed long long}} *" may lose significant bits (int64_t *)(npa_lf_aura_handle_to_base( ^ It goes on with same kind of error > > Let us know > >> >> >>> >>> Thanks, >>> ferruh >>> >>> >>> >>> [1a] error #2259 >>> .../dpdk/drivers/common/octeontx2/otx2_mbox.c(47): error #2259: non- >>> pointer conversion from "unsigned long long" to "struct mbox_hdr *" >>> may lose significant bits >>> (struct mbox_hdr *)((uintptr_t)mdev->mbase + mbox->tx_start); >>> ^ >>> >>> >> /tmp/dpdk_maintain/self/dpdk/drivers/mempool/octeontx2/otx2_mempo >> ol.h( >>> 9 >>> 4): error >>> #2259: non-pointer conversion from "unsigned long long" to >>> "int64_t={__int64_t={signed long long}} *" may lose significant bits >>> >>> >>> (int64_t *)(npa_lf_aura_handle_to_base(aura_handle) + >>> >>> >>> >>> ^ >>> >>> [1b] error #191 >>> .../dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c(344): error >> #191: >>> type qualifier is meaningless on cast type >>> int64_t * const addr = (int64_t * const) >>> ^ >>> >>> >>> [2a] >>> diff --git a/drivers/common/octeontx2/Makefile >>> b/drivers/common/octeontx2/Makefile >>> index fabc32537..b78995e12 100644 >>> --- a/drivers/common/octeontx2/Makefile >>> +++ b/drivers/common/octeontx2/Makefile >>> @@ -19,6 +19,10 @@ CFLAGS += -Wno-int-to-pointer-cast >>> CFLAGS += -Wno-pointer-to-int-cast >>> endif >>> >>> +ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) +CFLAGS += -diag-disable 2259 >>> # non-pointer conversion may lose significant bits +endif + >>> EXPORT_MAP := rte_common_octeontx2_version.map >>> >>> LIBABIVER := 1 >>> diff --git a/drivers/mempool/octeontx2/Makefile >>> b/drivers/mempool/octeontx2 /Makefile index b3568443e..37bcebdf3 >>> 100644 >>> --- a/drivers/mempool/octeontx2/Makefile >>> +++ b/drivers/mempool/octeontx2/Makefile >>> @@ -20,6 +20,10 @@ CFLAGS += -Wno-int-to-pointer-cast >>> CFLAGS += -Wno-pointer-to-int-cast >>> endif >>> >>> +ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) +CFLAGS += -diag-disable 2259 >>> # non-pointer conversion may lose significant bits +endif + >>> EXPORT_MAP := rte_mempool_octeontx2_version.map >>> >>> LIBABIVER := 1 >>> >>> >>> [2b] >>> - int64_t * const addr = (int64_t * const) >>> + int64_t * const addr = (int64_t *)