From: Yongseok Koh <yskoh@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix 32b compilation
Date: Wed, 12 Jun 2019 21:25:34 +0000 [thread overview]
Message-ID: <10BD7CE0-1B5A-4756-955B-66754A9F2CF1@mellanox.com> (raw)
In-Reply-To: <20190612053215.5682-1-shahafs@mellanox.com>
> On Jun 11, 2019, at 10:32 PM, Shahaf Shuler <shahafs@mellanox.com> wrote:
>
> 32b Compilation output the below error:
>
> drivers/net/mlx5/mlx5_txq.c: In function 'mlx5_txq_ibv_new':
> error: format '%lx' expects argument of type 'long unsigned int', but
> argument 8 has type 'off_t' [-Werror=format=]
> DRV_LOG(DEBUG, "port %u: uar_mmap_offset 0x%lx",
> ^
off_t would have same size as pointer.
Changing lx to PRIxPTR would work?
> Fixes: 6bf10ab69be0 ("net/mlx5: support 32-bit systems")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_txq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
> index ebb42cbffb..a421139e3c 100644
> --- a/drivers/net/mlx5/mlx5_txq.c
> +++ b/drivers/net/mlx5/mlx5_txq.c
> @@ -566,8 +566,8 @@ mlx5_txq_ibv_new(struct rte_eth_dev *dev, uint16_t idx)
> txq_uar_init(txq_ctrl);
> if (qp.comp_mask & MLX5DV_QP_MASK_UAR_MMAP_OFFSET) {
> txq_ctrl->uar_mmap_offset = qp.uar_mmap_offset;
> - DRV_LOG(DEBUG, "port %u: uar_mmap_offset 0x%lx",
> - dev->data->port_id, txq_ctrl->uar_mmap_offset);
> + DRV_LOG(DEBUG, "port %u: uar_mmap_offset 0x%x",
> + dev->data->port_id, (int)(txq_ctrl->uar_mmap_offset));
> } else {
> DRV_LOG(ERR,
> "port %u failed to retrieve UAR info, invalid"
> --
> 2.12.0
>
next prev parent reply other threads:[~2019-06-12 21:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 5:32 [dpdk-dev] [PATCH] net/mlx5: fix 32b compilation Shahaf Shuler
2019-06-12 21:25 ` Yongseok Koh [this message]
2019-06-13 13:29 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-06-13 13:35 ` Ferruh Yigit
2020-01-13 14:22 ` [dpdk-dev] [PATCH] net/mlx5: fix doorbell register offset type Viacheslav Ovsiienko
2020-01-13 14:29 ` Matan Azrad
2020-01-15 10:09 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10BD7CE0-1B5A-4756-955B-66754A9F2CF1@mellanox.com \
--to=yskoh@mellanox.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).