DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: "Chautru, Nicolas" <nicolas.chautru@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Mokhtar, Amr" <amr.mokhtar@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/3] docs/guides: updating turbo_sw building steps
Date: Thu, 6 Jun 2019 17:03:45 +0000
Message-ID: <1183128033837D43A851F70F33ED5C575C18C639@FMSMSX109.amr.corp.intel.com> (raw)
In-Reply-To: <c0473833-0254-1580-f853-c33a1757e10b@intel.com>

>-----Original Message-----
>From: Yigit, Ferruh 
>Sent: Thursday, June 6, 2019 3:34 AM
>
>On 6/5/2019 9:10 PM, Nicolas Chautru wrote:
>> The documentation is clarified to point to steps on building the SDK 
>> libraries which are now publicly available.
>> 
>
>I can see new SDK link is in the documentation, but can you please put that information into the commit log too, to highlight it?

Fine with me. 

>
>> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
>> ---
>>  doc/guides/bbdevs/turbo_sw.rst | 84 
>> +++++++++++++++++++++++-------------------
>>  1 file changed, 46 insertions(+), 38 deletions(-)
>> 
>> diff --git a/doc/guides/bbdevs/turbo_sw.rst 
>> b/doc/guides/bbdevs/turbo_sw.rst index 29f7ec9..196b3d6 100644
>> --- a/doc/guides/bbdevs/turbo_sw.rst
>> +++ b/doc/guides/bbdevs/turbo_sw.rst
>> @@ -1,26 +1,43 @@
>>  ..  SPDX-License-Identifier: BSD-3-Clause
>>      Copyright(c) 2017 Intel Corporation
>>  
>> -SW Turbo Poll Mode Driver
>> +SW FEC Poll Mode Driver
>
>There seems two groups of changes in this patch,
>- new SDK related changes,
>- and renaming 's/Turbo/FEC'
>For second one can you please put a brief description into commit log? Why Turbo needs to be FEC. (This even can be a separate patch)
>

Fair enough. Name could be more accurate as Turbo means so different things but this is fairly cosmetic and we can change this in a future patchset. 
This would also require changes in the code which is not required now. So will put it back as before now. 

>>  =========================
>>  
>> -The SW Turbo PMD (**baseband_turbo_sw**) provides a poll mode bbdev 
>> driver that utilizes -Intel optimized libraries for LTE Layer 1 
>> workloads acceleration. This PMD -supports the functions: Turbo FEC, Rate Matching and CRC functions.
>> +The SW FEC PMD (**baseband_turbo_sw**) provides a software only poll 
>> +mode bbdev driver that can optionally utilize Intel optimized 
>> +libraries for LTE and 5GNR Layer 1 workloads acceleration.
>
>Is 5GNR Layer 1 workloads acceleration available in this stage of the PMD?
>

The SDK provided on the link supports both standards and set of libraries and these how they are referred on the webpage : "FlexRAN LTE and 5G NR FEC Software Development Kit Modules".
Still if you reckon this is confusing given this current PMD only links to the 4G ones then I can remove any mention of 5GNR. 
The related turbo_sw in patchwork v1 is extending this and hence documentation will eventually mention back 5GNR anyway. Will change now. 

>> +
>> +Note that the driver can also be built without any dependency with 
>> +reduced functionality for maintenance purpose.
>> +
>> +To enable linking to the SDK libraries see detailed installation section below.
>> +Two flags can be enabled depending on whether the target machine can 
>> +support
>> +AVX2 and AVX512 instructions sets and the related SDK libraries for 
>> +vectorized signal processing functions are installed :
>> +- CONFIG_RTE_BBDEV_SDK_AVX2
>> +- CONFIG_RTE_BBDEV_SDK_AVX512
>
>This flag is not available (yet), can you please remove from this doc and add with the patch that adds this flag?

No problem. The intention was to highlight where this is going with 2 sets of functionality depending on HW dependency as it is not necessarily obvious now that these are split into 2 patchsets. 
But you are right that this can be rephrased to be limited to AVX2 for now. 

Thanks

>
><...>
>


  reply index

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 17:38 [dpdk-dev] [PATCH] BBDEV turbo_sw PMD compilation fix Nicolas Chautru
2019-06-05 17:38 ` [dpdk-dev] [PATCH] baseband/turbo_sw: Option to build turbosw PMD without SDK Nicolas Chautru
2019-06-05 17:47   ` Thomas Monjalon
2019-06-05 20:10   ` [dpdk-dev] [PATCH v2 0/3] BBDEV turbo_sw PMD compilation fix Nicolas Chautru
2019-06-05 20:10     ` [dpdk-dev] [PATCH v2 1/3] baseband/turbo_sw: option to build turbosw PMD without SDK Nicolas Chautru
2019-06-05 20:10     ` [dpdk-dev] [PATCH v2 2/3] docs/guides: updating turbo_sw building steps Nicolas Chautru
2019-06-06 10:34       ` Ferruh Yigit
2019-06-06 17:03         ` Chautru, Nicolas [this message]
2019-06-05 20:10     ` [dpdk-dev] [PATCH v2 3/3] baseband/turbo_sw: meson build support for PMD driver Nicolas Chautru
2019-06-05 21:20   ` [dpdk-dev] [PATCH v2 0/3] baseband/fpga_lte_fec: adding driver for FEC on FPGA Nicolas Chautru
2019-06-05 21:20     ` [dpdk-dev] [PATCH v2 1/3] " Nicolas Chautru
2019-06-06  9:04       ` [dpdk-dev] [PATCH v3] " Nicolas Chautru
2019-06-06  9:04         ` Nicolas Chautru
2019-06-08  0:17           ` [dpdk-dev] [PATCH v4] " Nicolas Chautru
2019-06-08  0:17             ` Nicolas Chautru
2019-06-10 17:01           ` Nicolas Chautru
2019-06-10 17:01             ` Nicolas Chautru
     [not found]               ` <EEA9FF629BF25B47BD67ADE995041EE2496A888B@IRSMSX103.ger.corp.intel.com>
2019-06-13 17:05                 ` Chautru, Nicolas
2019-06-13 17:28               ` [dpdk-dev] [PATCH v5] " Nicolas Chautru
2019-06-13 17:28                 ` Nicolas Chautru
2019-06-14 16:12               ` [dpdk-dev] [PATCH v6] " Nicolas Chautru
2019-06-14 16:12                 ` [dpdk-dev] [PATCH v5] " Nicolas Chautru
2019-06-14 16:17               ` [dpdk-dev] [PATCH v6] " Nicolas Chautru
2019-06-14 16:17                 ` Nicolas Chautru
2019-06-19 15:20                   ` Chautru, Nicolas
     [not found]                   ` <EEA9FF629BF25B47BD67ADE995041EE2496B2975@IRSMSX103.ger.corp.intel.com>
2019-06-20 13:35                     ` Ferruh Yigit
2019-06-25 12:37                       ` Akhil Goyal
2019-06-06 10:17       ` [dpdk-dev] [PATCH v3 0/3] BBDEV turbo_sw PMD compilation fix Nicolas Chautru
2019-06-06 10:17         ` [dpdk-dev] [PATCH v3 1/3] baseband/turbo_sw: option to build turbosw PMD without SDK Nicolas Chautru
2019-06-07 23:54           ` [dpdk-dev] [PATCH v4 0/3] BBDEV turbo_sw PMD compilation fix Nicolas Chautru
2019-06-07 23:54             ` [dpdk-dev] [PATCH v4 1/3] baseband/turbo_sw: option to build turbosw PMD without SDK Nicolas Chautru
2019-06-13 16:51               ` [dpdk-dev] [PATCH v5 0/3] BBDEV turbo_sw PMD compilation fix Nicolas Chautru
2019-06-13 16:51                 ` [dpdk-dev] [PATCH v5 1/3] baseband/turbo_sw: option to build turbosw PMD without SDK Nicolas Chautru
2019-06-19 17:11                   ` [dpdk-dev] [PATCH v6 0/3] BBDEV turbo_sw PMD compilation fix Nicolas Chautru
2019-06-19 17:11                     ` [dpdk-dev] [PATCH v6 1/3] baseband/turbo_sw: option to build turbosw PMD without SDK Nicolas Chautru
2019-06-19 17:48                       ` [dpdk-dev] [PATCH v7 0/3] BBDEV turbo_sw PMD compilation fix Nicolas Chautru
2019-06-19 17:48                         ` [dpdk-dev] [PATCH v7 1/3] baseband/turbo_sw: option to build turbosw PMD without SDK Nicolas Chautru
2019-06-20 22:42                           ` Mokhtar, Amr
2019-06-19 17:48                         ` [dpdk-dev] [PATCH v7 2/3] docs/guides: updating turbo_sw building steps Nicolas Chautru
2019-07-07  8:59                           ` Thomas Monjalon
2019-06-19 17:48                         ` [dpdk-dev] [PATCH v7 3/3] baseband/turbo_sw: meson build support for PMD driver Nicolas Chautru
2019-06-20 17:33                         ` [dpdk-dev] [PATCH v7 0/3] BBDEV turbo_sw PMD compilation fix Ferruh Yigit
2019-06-25 12:41                           ` Akhil Goyal
2019-06-19 17:11                     ` [dpdk-dev] [PATCH v6 2/3] docs/guides: updating turbo_sw building steps Nicolas Chautru
2019-06-19 17:11                     ` [dpdk-dev] [PATCH v6 3/3] baseband/turbo_sw: meson build support for PMD driver Nicolas Chautru
2019-06-20  0:05                       ` Aaron Conole
2019-06-20  0:34                         ` Chautru, Nicolas
2019-06-13 16:51                 ` [dpdk-dev] [PATCH v5 2/3] docs/guides: updating turbo_sw building steps Nicolas Chautru
2019-06-13 16:51                 ` [dpdk-dev] [PATCH v5 3/3] baseband/turbo_sw: meson build support for PMD driver Nicolas Chautru
2019-06-07 23:54             ` [dpdk-dev] [PATCH v4 2/3] docs/guides: updating turbo_sw building steps Nicolas Chautru
2019-06-07 23:54             ` [dpdk-dev] [PATCH v4 3/3] baseband/turbo_sw: meson build support for PMD driver Nicolas Chautru
2019-06-06 10:17         ` [dpdk-dev] [PATCH v3 2/3] docs/guides: updating turbo_sw building steps Nicolas Chautru
2019-06-06 10:17         ` [dpdk-dev] [PATCH v3 3/3] baseband/turbo_sw: meson build support for PMD driver Nicolas Chautru
2019-06-05 21:20     ` [dpdk-dev] [PATCH v2 2/3] doc/guides: documentation for the FPGA BBDEV PMD Nicolas Chautru
2019-06-05 21:21     ` [dpdk-dev] [PATCH v2 3/3] baseband/fpga_lte_fec: meson support Nicolas Chautru
2019-06-06  8:25       ` Bruce Richardson
2019-06-06 10:16         ` Ferruh Yigit
2019-06-06 16:39           ` Chautru, Nicolas

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1183128033837D43A851F70F33ED5C575C18C639@FMSMSX109.amr.corp.intel.com \
    --to=nicolas.chautru@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=amr.mokhtar@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox