From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] kni: fix compilation under RHEL 7.5
Date: Thu, 19 Apr 2018 22:49:21 +0100
Message-ID: <1524174561.14582.2.camel@debian.org>
References: <1519946435-3574-1-git-send-email-lee.roberts@hpe.com>
 <1b24f058-2a55-73a9-14ab-5002637a7c92@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Maxime Coquelin <maxime.coquelin@redhat.com>, Lee Roberts
 <lee.roberts@hpe.com>, ferruh.yigit@intel.com, Thomas Monjalon
 <thomas@monjalon.net>, Yuanhan Liu <yliu@fridaylinux.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com
 [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 426568D90
 for <dev@dpdk.org>; Thu, 19 Apr 2018 23:49:24 +0200 (CEST)
Received: by mail-wr0-f195.google.com with SMTP id d1-v6so17785148wrj.13
 for <dev@dpdk.org>; Thu, 19 Apr 2018 14:49:24 -0700 (PDT)
In-Reply-To: <1b24f058-2a55-73a9-14ab-5002637a7c92@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 2018-04-19 at 15:09 +0200, Maxime Coquelin wrote:
> Hi Luca, Yuanhan,
>=20
> On 03/02/2018 12:20 AM, Lee Roberts wrote:
> > Fix kni compilation under RHEL 7.5.
> >=20
> > Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
> > ---
> > =C2=A0 lib/librte_eal/linuxapp/kni/compat.h | 5 +++++
> > =C2=A0 1 file changed, 5 insertions(+)
> >=20
> > diff --git a/lib/librte_eal/linuxapp/kni/compat.h
> > b/lib/librte_eal/linuxapp/kni/compat.h
> > index 3f8c0bc..6a6968d 100644
> > --- a/lib/librte_eal/linuxapp/kni/compat.h
> > +++ b/lib/librte_eal/linuxapp/kni/compat.h
> > @@ -101,6 +101,11 @@
> > =C2=A0 #undef NET_NAME_UNKNOWN
> > =C2=A0 #endif
> > =C2=A0=C2=A0
> > +#if (defined(RHEL_RELEASE_CODE) && \
> > +	(RHEL_RELEASE_CODE >=3D RHEL_RELEASE_VERSION(7, 5)))
> > +#define ndo_change_mtu ndo_change_mtu_rh74
> > +#endif
> > +
> > =C2=A0 #if LINUX_VERSION_CODE >=3D KERNEL_VERSION(4, 11, 0)
> > =C2=A0 #define HAVE_SIGNAL_FUNCTIONS_OWN_HEADER
> > =C2=A0 #endif
> >=20
>=20
> Any chance we pick these patches in stable branches so that
> we can build them with RHEL 7.5 without disabling KNI?
>=20
> I think it should apply cleanly on all of them, but I can send the
> backport patches for each of them if necessary.
>=20
> Thanks,
> Maxime

Sure, I can have a look early next week for 16.11.

--=20
Kind regards,
Luca Boccassi