From: David Marchand <david.marchand@redhat.com> To: dev@dpdk.org Cc: thomas@monjalon.net, aconole@redhat.com, msantana@redhat.com Subject: [dpdk-dev] [PATCH 11/14] test/eal: check number of cores before running subtests Date: Tue, 4 Jun 2019 10:59:49 +0200 [thread overview] Message-ID: <1559638792-8608-12-git-send-email-david.marchand@redhat.com> (raw) In-Reply-To: <1559638792-8608-1-git-send-email-david.marchand@redhat.com> From: Michael Santana <msantana@redhat.com> The eal flags unit test assumes that a certain number of cores are available (4 and 8 cores), however this may not always be the case. Individual developers may run the unit test on their local desktop which typically have 2 to 4 cores, in said case the test is bound to fail for lacking 4 or 8 cores. Additionally, as we push forward introducing CI into DPDK we are limited to the hardware specification of CI services (e.g. Travis CI) that only have 2 cores on their servers, in which case the test would fail. To fix this we check available cores before running a subtest. This applies to subtests that are dedicated to test that the -l and --lcore flags work correctly. If not enough cores are available the subtest is simply skipped, otherwise the subtest is run. Signed-off-by: Michael Santana <msantana@redhat.com> Signed-off-by: David Marchand <david.marchand@redhat.com> --- app/test/test_eal_flags.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index 5e11b9f..cfa8a61 100644 --- a/app/test/test_eal_flags.c +++ b/app/test/test_eal_flags.c @@ -19,7 +19,7 @@ #include <limits.h> #include <fcntl.h> -#include <rte_per_lcore.h> +#include <rte_lcore.h> #include <rte_debug.h> #include <rte_string_fns.h> @@ -560,7 +560,9 @@ enum hugepage_action { "process ran without error with invalid -l flag\n"); return -1; } - if (launch_proc(argv15) != 0) { + if (rte_lcore_is_enabled(0) && rte_lcore_is_enabled(1) && + rte_lcore_is_enabled(2) && rte_lcore_is_enabled(3) && + launch_proc(argv15) != 0) { printf("Error - " "process did not run ok with valid corelist value\n"); return -1; @@ -579,7 +581,11 @@ enum hugepage_action { return -1; } - if (launch_proc(argv29) != 0) { + if (rte_lcore_is_enabled(0) && rte_lcore_is_enabled(1) && + rte_lcore_is_enabled(2) && rte_lcore_is_enabled(3) && + rte_lcore_is_enabled(3) && rte_lcore_is_enabled(5) && + rte_lcore_is_enabled(4) && rte_lcore_is_enabled(7) && + launch_proc(argv29) != 0) { printf("Error - " "process did not run ok with valid corelist value\n"); return -1; @@ -606,6 +612,9 @@ enum hugepage_action { snprintf(prefix, sizeof(prefix), "--file-prefix=%s", tmp); #endif + if (!rte_lcore_is_enabled(0) || !rte_lcore_is_enabled(1)) + return TEST_SKIPPED; + /* --master-lcore flag but no value */ const char *argv1[] = { prgname, prefix, mp_flag, "-c", "3", "--master-lcore"}; -- 1.8.3.1
next prev parent reply other threads:[~2019-06-04 9:01 UTC|newest] Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-04 8:59 [dpdk-dev] [PATCH 00/14] Unit tests fixes for CI David Marchand 2019-06-04 8:59 ` [dpdk-dev] [PATCH 01/14] test/bonding: add missing sources for link bonding RSS David Marchand 2019-06-04 12:59 ` Aaron Conole 2019-06-04 8:59 ` [dpdk-dev] [PATCH 02/14] test/crypto: move tests to the driver specific list David Marchand 2019-06-04 13:00 ` Aaron Conole 2019-06-04 8:59 ` [dpdk-dev] [PATCH 03/14] test/eventdev: " David Marchand 2019-06-04 13:04 ` Aaron Conole 2019-06-04 8:59 ` [dpdk-dev] [PATCH 04/14] test/hash: fix off-by-one check on core count David Marchand 2019-06-04 13:05 ` Aaron Conole 2019-06-05 20:02 ` Wang, Yipeng1 2019-06-04 8:59 ` [dpdk-dev] [PATCH 05/14] test/hash: rectify slaveid to point to valid cores David Marchand 2019-06-05 20:02 ` Wang, Yipeng1 2019-06-04 8:59 ` [dpdk-dev] [PATCH 06/14] test/hash: clean remaining trace of scaling autotest David Marchand 2019-06-04 13:31 ` Aaron Conole 2019-06-04 8:59 ` [dpdk-dev] [PATCH 07/14] test/latencystats: fix stack smashing David Marchand 2019-06-04 13:38 ` Aaron Conole 2019-06-04 8:59 ` [dpdk-dev] [PATCH 08/14] test/stack: fix lock-free test name David Marchand 2019-06-04 13:06 ` Aaron Conole 2019-06-04 8:59 ` [dpdk-dev] [PATCH 09/14] test/eal: set memory channel config only in dedicated test David Marchand 2019-06-04 13:11 ` Aaron Conole 2019-06-26 9:44 ` Burakov, Anatoly 2019-06-04 8:59 ` [dpdk-dev] [PATCH 10/14] test/eal: set core mask/list " David Marchand 2019-06-04 13:12 ` Aaron Conole 2019-06-26 9:45 ` Burakov, Anatoly 2019-06-04 8:59 ` David Marchand [this message] 2019-06-04 13:26 ` [dpdk-dev] [PATCH 11/14] test/eal: check number of cores before running subtests Aaron Conole 2019-06-26 9:47 ` Burakov, Anatoly 2019-06-04 8:59 ` [dpdk-dev] [PATCH 12/14] test/eal: make the test pass again David Marchand 2019-06-04 13:29 ` Aaron Conole 2019-06-04 13:50 ` David Marchand 2019-06-26 9:49 ` Burakov, Anatoly 2019-06-26 10:03 ` David Marchand 2019-06-04 8:59 ` [dpdk-dev] [PATCH 13/14] test: do not start tests in parallel David Marchand 2019-06-04 8:59 ` [dpdk-dev] [PATCH 14/14] test: skip tests when missing requirements David Marchand 2019-06-07 20:54 ` Honnappa Nagarahalli 2019-06-08 8:01 ` David Marchand 2019-06-11 4:08 ` Honnappa Nagarahalli 2019-06-04 15:49 ` [dpdk-dev] [PATCH 00/14] Unit tests fixes for CI Michael Santana Francisco 2019-06-27 16:34 ` Thomas Monjalon 2019-07-01 12:17 ` Aaron Conole 2019-06-15 6:42 ` [dpdk-dev] [PATCH v2 00/15] " David Marchand 2019-06-15 6:42 ` [dpdk-dev] [PATCH v2 01/15] test/bonding: add missing sources for link bonding RSS David Marchand 2019-06-15 6:42 ` [dpdk-dev] [PATCH v2 02/15] test/crypto: move tests to the driver specific list David Marchand 2019-06-15 6:42 ` [dpdk-dev] [PATCH v2 03/15] test/eventdev: " David Marchand 2019-06-15 6:42 ` [dpdk-dev] [PATCH v2 04/15] test/hash: fix off-by-one check on core count David Marchand 2019-06-15 6:42 ` [dpdk-dev] [PATCH v2 05/15] test/hash: rectify slaveid to point to valid cores David Marchand 2019-06-15 6:42 ` [dpdk-dev] [PATCH v2 06/15] test/hash: clean remaining trace of scaling autotest David Marchand 2019-06-15 6:42 ` [dpdk-dev] [PATCH v2 07/15] test/latencystats: fix stack smashing David Marchand 2019-06-15 6:42 ` [dpdk-dev] [PATCH v2 08/15] test/rcu: remove arbitrary limit on max core count David Marchand 2019-06-28 12:56 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit 2019-06-28 13:32 ` David Marchand 2019-06-15 6:42 ` [dpdk-dev] [PATCH v2 09/15] test/stack: fix lock-free test name David Marchand 2019-06-15 6:42 ` [dpdk-dev] [PATCH v2 10/15] test/eal: set memory channel config only in dedicated test David Marchand 2019-06-15 6:42 ` [dpdk-dev] [PATCH v2 11/15] test/eal: set core mask/list " David Marchand 2019-06-15 6:42 ` [dpdk-dev] [PATCH v2 12/15] test/eal: check number of cores before running subtests David Marchand 2019-06-15 6:42 ` [dpdk-dev] [PATCH v2 13/15] test: split into shorter subtests for CI David Marchand 2019-06-15 6:42 ` [dpdk-dev] [PATCH v2 14/15] test: do not start tests in parallel David Marchand 2019-06-15 6:42 ` [dpdk-dev] [PATCH v2 15/15] test: skip tests when missing requirements David Marchand 2019-06-17 10:00 ` [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI Bruce Richardson 2019-06-17 10:46 ` David Marchand 2019-06-17 11:17 ` Bruce Richardson 2019-06-17 11:41 ` David Marchand 2019-06-17 11:56 ` Bruce Richardson 2019-06-17 13:44 ` David Marchand 2019-06-27 20:36 ` Thomas Monjalon 2019-07-01 16:04 ` Aaron Conole 2019-07-01 16:22 ` Thomas Monjalon 2019-07-01 16:45 ` David Marchand 2019-07-01 18:07 ` Michael Santana Francisco 2019-07-09 15:50 ` Michael Santana Francisco 2019-07-10 8:18 ` David Marchand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1559638792-8608-12-git-send-email-david.marchand@redhat.com \ --to=david.marchand@redhat.com \ --cc=aconole@redhat.com \ --cc=dev@dpdk.org \ --cc=msantana@redhat.com \ --cc=thomas@monjalon.net \ --subject='Re: [dpdk-dev] [PATCH 11/14] test/eal: check number of cores before running subtests' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).