From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 913C3C282DD for ; Mon, 10 Jun 2019 13:08:50 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 2070920679 for ; Mon, 10 Jun 2019 13:08:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2070920679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DAA861C039; Mon, 10 Jun 2019 15:08:48 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 226E91C038 for ; Mon, 10 Jun 2019 15:08:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jun 2019 06:08:28 -0700 X-ExtLoop1: 1 Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga004.fm.intel.com with ESMTP; 10 Jun 2019 06:08:27 -0700 Received: from wgcvswdev001.ir.intel.com (wgcvswdev001.ir.intel.com [10.102.246.100]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id x5AD8QOV020322; Mon, 10 Jun 2019 14:08:26 +0100 Received: from wgcvswdev001.ir.intel.com (localhost [127.0.0.1]) by wgcvswdev001.ir.intel.com with ESMTP id x5AD81Km011016; Mon, 10 Jun 2019 14:08:01 +0100 Received: (from lgovin3x@localhost) by wgcvswdev001.ir.intel.com with œ id x5AD81X4011012; Mon, 10 Jun 2019 14:08:01 +0100 From: Lavanya Govindarajan To: dev@dpdk.org Cc: reshma.pattan@intel.com, jingjing.wu@intel.com, wenzhuo.lu@intel.com, jananeex.m.parthasarathy@intel.com, Lavanya Govindarajan Date: Mon, 10 Jun 2019 14:07:38 +0100 Message-Id: <1560172058-10742-1-git-send-email-lavanyax.govindarajan@intel.com> X-Mailer: git-send-email 1.7.0.7 Subject: [dpdk-dev] [PATCH] net/iavf: move debug dump desc flag to config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" DEBUG_DUMP_DESC flag is commented out in IAVF Makefile and to enable it user needs to edit the Makefile. It is felt that this method is not good. Hence removing this flag from IAVF makefile and adding a flag CONFIG_RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC to config/common_base. Signed-off-by: Lavanya Govindarajan --- config/common_base | 1 + drivers/net/iavf/Makefile | 3 --- drivers/net/iavf/iavf_rxtx.h | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/config/common_base b/config/common_base index 6b96e0e80..86cd27bb2 100644 --- a/config/common_base +++ b/config/common_base @@ -327,6 +327,7 @@ CONFIG_RTE_LIBRTE_IAVF_INC_VECTOR=y CONFIG_RTE_LIBRTE_IAVF_DEBUG_TX=n CONFIG_RTE_LIBRTE_IAVF_DEBUG_TX_FREE=n CONFIG_RTE_LIBRTE_IAVF_DEBUG_RX=n +CONFIG_RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC=n CONFIG_RTE_LIBRTE_IAVF_16BYTE_RX_DESC=n # # Compile burst-oriented IPN3KE PMD driver diff --git a/drivers/net/iavf/Makefile b/drivers/net/iavf/Makefile index 3a0eb79ca..cd74e14ab 100644 --- a/drivers/net/iavf/Makefile +++ b/drivers/net/iavf/Makefile @@ -13,9 +13,6 @@ LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash LDLIBS += -lrte_bus_pci -# used to dump HW descriptor for debugging -# CFLAGS += -DDEBUG_DUMP_DESC - EXPORT_MAP := rte_pmd_iavf_version.map LIBABIVER := 1 diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h index e821dcae6..c86720bda 100644 --- a/drivers/net/iavf/iavf_rxtx.h +++ b/drivers/net/iavf/iavf_rxtx.h @@ -255,7 +255,7 @@ void iavf_dump_tx_descriptor(const struct iavf_tx_queue *txq, tx_desc->cmd_type_offset_bsz); } -#ifdef DEBUG_DUMP_DESC +#ifdef RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC #define IAVF_DUMP_RX_DESC(rxq, desc, rx_id) \ iavf_dump_rx_descriptor(rxq, desc, rx_id) #define IAVF_DUMP_TX_DESC(txq, desc, tx_id) \ -- 2.17.2